[Qemu-commits] [qemu/qemu] 6979a8: sockets: add ability to disable DNS resolution for...

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: 6979a813f38d221bf68c3928a8d2b810cefc34b5
      
https://github.com/qemu/qemu/commit/6979a813f38d221bf68c3928a8d2b810cefc34b5
  Author: Daniel P. Berrange <address@hidden>
  Date:   2017-01-23 (Mon, 23 Jan 2017)

  Changed paths:
    M qapi-schema.json
    M util/qemu-sockets.c

  Log Message:
  -----------
  sockets: add ability to disable DNS resolution for InetSocketAddress

Add a 'numeric' flag to the InetSocketAddress struct to allow the
caller to indicate that DNS should be skipped for the host/port
fields. This is useful if the caller knows the address is already
numeric and wants to guarantee no (potentially blocking) DNS
lookups are attempted.

Reviewed-by: Eric Blake <address@hidden>
Signed-off-by: Daniel P. Berrange <address@hidden>


  Commit: 937470bb5470825e781ae50e92ff973a6b54d80f
      
https://github.com/qemu/qemu/commit/937470bb5470825e781ae50e92ff973a6b54d80f
  Author: Daniel P. Berrange <address@hidden>
  Date:   2017-01-23 (Mon, 23 Jan 2017)

  Changed paths:
    M include/io/task.h
    M io/channel-socket.c
    M io/channel-tls.c
    M io/task.c
    M tests/test-io-task.c

  Log Message:
  -----------
  io: stop incrementing reference in qio_task_get_source

Incrementing the reference in qio_task_get_source is
not necessary, since we're not running concurrently
with any other code touching the QIOTask. This
minimizes chances of further memory leaks.

Reviewed-by: Eric Blake <address@hidden>
Signed-off-by: Daniel P. Berrange <address@hidden>


  Commit: e8c8adecada7a3e59bffcc0207327aae472ffcda
      
https://github.com/qemu/qemu/commit/e8c8adecada7a3e59bffcc0207327aae472ffcda
  Author: Daniel P. Berrange <address@hidden>
  Date:   2017-01-23 (Mon, 23 Jan 2017)

  Changed paths:
    M include/io/task.h

  Log Message:
  -----------
  io: fix typo in docs for QIOTask

The GDestroyNotify parameter is already a pointer, so does
not need a '*' suffix on the type.

Reviewed-by: Eric Blake <address@hidden>
Signed-off-by: Daniel P. Berrange <address@hidden>


  Commit: 52dd99e8a4df8ace2fdf8cd173a3338357776bff
      
https://github.com/qemu/qemu/commit/52dd99e8a4df8ace2fdf8cd173a3338357776bff
  Author: Daniel P. Berrange <address@hidden>
  Date:   2017-01-23 (Mon, 23 Jan 2017)

  Changed paths:
    M include/io/task.h
    M io/task.c

  Log Message:
  -----------
  io: add ability to associate an opaque "result" with with a task

Currently there is no data associated with a successful
task completion. This adds an opaque pointer to the task
to store an arbitrary result.

Reviewed-by: Eric Blake <address@hidden>
Signed-off-by: Daniel P. Berrange <address@hidden>


  Commit: 1a447e4f0266d757687b38146795b95525d37d94
      
https://github.com/qemu/qemu/commit/1a447e4f0266d757687b38146795b95525d37d94
  Author: Daniel P. Berrange <address@hidden>
  Date:   2017-01-23 (Mon, 23 Jan 2017)

  Changed paths:
    M include/io/task.h
    M io/task.c

  Log Message:
  -----------
  io: add ability to associate an error with a task

Currently when a task fails, the error is never explicitly
associated with the task object, it is just passed along
through the completion callback. This adds the ability to
explicitly associate an error with the task.

Signed-off-by: Daniel P. Berrange <address@hidden>


  Commit: 60e705c51c66373f78e536e0462744a610c27cf6
      
https://github.com/qemu/qemu/commit/60e705c51c66373f78e536e0462744a610c27cf6
  Author: Daniel P. Berrange <address@hidden>
  Date:   2017-01-23 (Mon, 23 Jan 2017)

  Changed paths:
    M include/io/task.h
    M io/channel-tls.c
    M io/channel-websock.c
    M io/task.c
    M io/trace-events
    M migration/socket.c
    M migration/tls.c
    M nbd/common.c
    M nbd/nbd-internal.h
    M qemu-char.c
    M tests/test-io-channel-socket.c
    M tests/test-io-channel-tls.c
    M tests/test-io-task.c
    M ui/vnc-auth-vencrypt.c
    M ui/vnc-ws.c

  Log Message:
  -----------
  io: change the QIOTask callback signature

Currently the QIOTaskFunc signature takes an Object * for
the source, and an Error * for any error. We also need to
be able to provide a result pointer. Rather than continue
to add parameters to QIOTaskFunc, remove the existing
ones and simply pass the QIOTask object instead. This
has methods to access all the other data items required
in the callback impl.

Reviewed-by: Eric Blake <address@hidden>
Signed-off-by: Daniel P. Berrange <address@hidden>


  Commit: 59de517d8d482416a079da7ee8344187d513d4a4
      
https://github.com/qemu/qemu/commit/59de517d8d482416a079da7ee8344187d513d4a4
  Author: Daniel P. Berrange <address@hidden>
  Date:   2017-01-23 (Mon, 23 Jan 2017)

  Changed paths:
    M include/io/task.h
    M io/channel-socket.c
    M io/task.c
    M tests/test-io-task.c

  Log Message:
  -----------
  io: remove Error parameter from QIOTask thread worker

Now that task objects have a directly associated error,
there's no need for an an Error **errp parameter to
the QIOTask thread worker function. It already has a
QIOTask object, so can directly set the error on it.

Reviewed-by: Eric Blake <address@hidden>
Signed-off-by: Daniel P. Berrange <address@hidden>


  Commit: c1b412f1d94ba717896f876dbf59fffa91e596fc
      
https://github.com/qemu/qemu/commit/c1b412f1d94ba717896f876dbf59fffa91e596fc
  Author: Daniel P. Berrange <address@hidden>
  Date:   2017-01-23 (Mon, 23 Jan 2017)

  Changed paths:
    A include/io/dns-resolver.h
    M include/qemu/sockets.h
    M io/Makefile.objs
    A io/dns-resolver.c
    M util/qemu-sockets.c

  Log Message:
  -----------
  io: introduce a DNS resolver API

Currently DNS resolution is done automatically as part
of the creation of a QIOChannelSocket object instance.
This works ok for network clients where you just end
up a single network socket, but for servers, the results
of DNS resolution may require creation of multiple
sockets.

Introducing a DNS resolver API allows DNS resolution
to be separated from the socket object creation. This
will make it practical to create multiple QIOChannelSocket
instances for servers.

Reviewed-by: Eric Blake <address@hidden>
Signed-off-by: Daniel P. Berrange <address@hidden>


  Commit: 3879284d6517dc22529395bdb259f4183b589127
      
https://github.com/qemu/qemu/commit/3879284d6517dc22529395bdb259f4183b589127
  Author: Peter Maydell <address@hidden>
  Date:   2017-01-23 (Mon, 23 Jan 2017)

  Changed paths:
    A include/io/dns-resolver.h
    M include/io/task.h
    M include/qemu/sockets.h
    M io/Makefile.objs
    M io/channel-socket.c
    M io/channel-tls.c
    M io/channel-websock.c
    A io/dns-resolver.c
    M io/task.c
    M io/trace-events
    M migration/socket.c
    M migration/tls.c
    M nbd/common.c
    M nbd/nbd-internal.h
    M qapi-schema.json
    M qemu-char.c
    M tests/test-io-channel-socket.c
    M tests/test-io-channel-tls.c
    M tests/test-io-task.c
    M ui/vnc-auth-vencrypt.c
    M ui/vnc-ws.c
    M util/qemu-sockets.c

  Log Message:
  -----------
  Merge remote-tracking branch 'remotes/berrange/tags/pull-qio-2017-01-23-2' 
into staging

Merge io/ 2017-01-23

# gpg: Signature made Mon 23 Jan 2017 15:56:14 GMT
# gpg:                using RSA key 0xBE86EBB415104FDF
# gpg: Good signature from "Daniel P. Berrange <address@hidden>"
# gpg:                 aka "Daniel P. Berrange <address@hidden>"
# Primary key fingerprint: DAF3 A6FD B26B 6291 2D0E  8E3F BE86 EBB4 1510 4FDF

* remotes/berrange/tags/pull-qio-2017-01-23-2:
  io: introduce a DNS resolver API
  io: remove Error parameter from QIOTask thread worker
  io: change the QIOTask callback signature
  io: add ability to associate an error with a task
  io: add ability to associate an opaque "result" with with a task
  io: fix typo in docs for QIOTask
  io: stop incrementing reference in qio_task_get_source
  sockets: add ability to disable DNS resolution for InetSocketAddress

Signed-off-by: Peter Maydell <address@hidden>


Compare: https://github.com/qemu/qemu/compare/598cf1c80527...3879284d6517