[Qemu-commits] [qemu/qemu] 204feb: libqtest: handle zero length memwrite/memread

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: 204febd17f9ebb9e94b1980b42c7f2c2307851c1
      
https://github.com/qemu/qemu/commit/204febd17f9ebb9e94b1980b42c7f2c2307851c1
  Author: Greg Kurz <address@hidden>
  Date:   2017-01-12 (Thu, 12 Jan 2017)

  Changed paths:
    M qtest.c
    M tests/libqtest.c

  Log Message:
  -----------
  libqtest: handle zero length memwrite/memread

Some recently added tests pass a zero length to qtest_memwrite().
Unfortunately, the qtest protocol doesn't implement an on-the-wire
syntax for zero-length writes and the current code happily sends
garbage to QEMU. This causes intermittent failures.

It isn't worth the pain to enhance the protocol, so this patch
simply fixes the issue by "just return, doing nothing". The same
fix is applied to qtest_memread() since the issue also exists in
the QEMU part of the "memread" command.

Suggested-by: Peter Maydell <address@hidden>
Signed-off-by: Greg Kurz <address@hidden>
Reviewed-by: Eric Blake <address@hidden>
Reviewed-by: John Snow <address@hidden>
Message-id: address@hidden
Signed-off-by: Peter Maydell <address@hidden>