[Qemu-commits] [qemu/qemu] e6af1e: block: Don't mark node clean after failed flush

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: e6af1e085416378918cca357bf2abd8b90224667
      
https://github.com/qemu/qemu/commit/e6af1e085416378918cca357bf2abd8b90224667
  Author: Kevin Wolf <address@hidden>
  Date:   2016-11-08 (Tue, 08 Nov 2016)

  Changed paths:
    M block/io.c
    M tests/qemu-iotests/026.out
    M tests/qemu-iotests/026.out.nocache
    M tests/qemu-iotests/071.out

  Log Message:
  -----------
  block: Don't mark node clean after failed flush

Commit 3ff2f67a changed bdrv_co_flush() so that no flush is issues if
the image hasn't been dirtied since the last flush. This is not quite
correct: The condition should be that the image hasn't been dirtied
since the last _successful_ flush. This patch changes the logic
accordingly.

Without this fix, subsequent bdrv_co_flush() calls would return success
without actually doing anything even though the image is still dirty.
The difference is visible in some blkdebug test cases where error
messages incorrectly disappeared after commit 3ff2f67a.

Cc: address@hidden
Signed-off-by: Kevin Wolf <address@hidden>
Reviewed-by: Denis V. Lunev <address@hidden>
Reviewed-by: Stefan Hajnoczi <address@hidden>
Reviewed-by: John Snow <address@hidden>
Message-id: address@hidden
Signed-off-by: Stefan Hajnoczi <address@hidden>


  Commit: 36173ec5f1d3baee62504affd761199693c14c82
      
https://github.com/qemu/qemu/commit/36173ec5f1d3baee62504affd761199693c14c82
  Author: Paolo Bonzini <address@hidden>
  Date:   2016-11-08 (Tue, 08 Nov 2016)

  Changed paths:
    M aio-posix.c

  Log Message:
  -----------
  aio-posix: avoid NULL pointer dereference in aio_epoll_update

aio_epoll_update dereferences parameter "node", but it could have been NULL
if deleting an fd handler that was not registered in the first place.

Signed-off-by: Paolo Bonzini <address@hidden>
Reviewed-by: Fam Zheng <address@hidden>
Message-id: address@hidden
Signed-off-by: Stefan Hajnoczi <address@hidden>


  Commit: 35dd66e23ce96283723de58e10d2877ae2be4a1b
      
https://github.com/qemu/qemu/commit/35dd66e23ce96283723de58e10d2877ae2be4a1b
  Author: Paolo Bonzini <address@hidden>
  Date:   2016-11-08 (Tue, 08 Nov 2016)

  Changed paths:
    M aio-posix.c

  Log Message:
  -----------
  aio-posix: simplify aio_epoll_update

Extract common code out of the "if".

Reviewed-by: Fam Zheng <address@hidden>
Signed-off-by: Paolo Bonzini <address@hidden>
Message-id: address@hidden
Signed-off-by: Stefan Hajnoczi <address@hidden>


  Commit: 3b0fc80dd8ed9bd1ac738898e4fbd70c4a618925
      
https://github.com/qemu/qemu/commit/3b0fc80dd8ed9bd1ac738898e4fbd70c4a618925
  Author: Peter Maydell <address@hidden>
  Date:   2016-11-08 (Tue, 08 Nov 2016)

  Changed paths:
    M docs/tracing.txt

  Log Message:
  -----------
  docs/tracing.txt: Update documentation of default backend

In commit baf86d6b3c we switched the default trace backend from "nop"
to "log". Update the documentation to match.

Signed-off-by: Peter Maydell <address@hidden>
Message-id: address@hidden
Signed-off-by: Stefan Hajnoczi <address@hidden>


  Commit: f70073df4a562efafc2e245515837fba673efb3d
      
https://github.com/qemu/qemu/commit/f70073df4a562efafc2e245515837fba673efb3d
  Author: Stefan Hajnoczi <address@hidden>
  Date:   2016-11-09 (Wed, 09 Nov 2016)

  Changed paths:
    M aio-posix.c
    M block/io.c
    M tests/qemu-iotests/026.out
    M tests/qemu-iotests/026.out.nocache
    M tests/qemu-iotests/071.out

  Log Message:
  -----------
  Merge remote-tracking branch 'public/tags/block-pull-request' into staging

# gpg: Signature made Tue 08 Nov 2016 06:12:29 PM GMT
# gpg:                using RSA key 0x9CA4ABB381AB73C8
# gpg: Good signature from "Stefan Hajnoczi <address@hidden>"
# gpg:                 aka "Stefan Hajnoczi <address@hidden>"
# Primary key fingerprint: 8695 A8BF D3F9 7CDA AC35  775A 9CA4 ABB3 81AB 73C8

* public/tags/block-pull-request:
  aio-posix: simplify aio_epoll_update
  aio-posix: avoid NULL pointer dereference in aio_epoll_update
  block: Don't mark node clean after failed flush

Message-id: address@hidden
Signed-off-by: Stefan Hajnoczi <address@hidden>


  Commit: 9b4b0350264d8164996265d635c8b9599673afb4
      
https://github.com/qemu/qemu/commit/9b4b0350264d8164996265d635c8b9599673afb4
  Author: Stefan Hajnoczi <address@hidden>
  Date:   2016-11-09 (Wed, 09 Nov 2016)

  Changed paths:
    M docs/tracing.txt

  Log Message:
  -----------
  Merge remote-tracking branch 'public/tags/tracing-pull-request' into staging

# gpg: Signature made Tue 08 Nov 2016 06:17:13 PM GMT
# gpg:                using RSA key 0x9CA4ABB381AB73C8
# gpg: Good signature from "Stefan Hajnoczi <address@hidden>"
# gpg:                 aka "Stefan Hajnoczi <address@hidden>"
# Primary key fingerprint: 8695 A8BF D3F9 7CDA AC35  775A 9CA4 ABB3 81AB 73C8

* public/tags/tracing-pull-request:
  docs/tracing.txt: Update documentation of default backend

Message-id: address@hidden
Signed-off-by: Stefan Hajnoczi <address@hidden>


Compare: https://github.com/qemu/qemu/compare/207faf24c588...9b4b0350264d