[Qemu-commits] [qemu/qemu] f279ee: machine: Fix replacement of '_' by '-' in machine ...

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: f279ee45832db52fb801e86a929bc53f575cd2f5
      
https://github.com/qemu/qemu/commit/f279ee45832db52fb801e86a929bc53f575cd2f5
  Author: Markus Armbruster <address@hidden>
  Date:   2016-10-17 (Mon, 17 Oct 2016)

  Changed paths:
    M vl.c

  Log Message:
  -----------
  machine: Fix replacement of '_' by '-' in machine property names

machine_set_property() replaces '_' by '-' in the property name.
Except it fails to replace an initial '_'.  Screwed up in commit
b0ddb8b.  Reproducer: "-M pc,__foo_bar=true" produces "Property
'._-foo-bar' not found".

Error messages using a mangled name rather than the name the user
actually wrote is user-hostile, but that's a different topic.

Signed-off-by: Markus Armbruster <address@hidden>
Reviewed-by: Eric Blake <address@hidden>
Reviewed-by: Eduardo Habkost <address@hidden>
Signed-off-by: Eduardo Habkost <address@hidden>


  Commit: 26b81df45c7f827511d11925b6c666cf667a0aaa
      
https://github.com/qemu/qemu/commit/26b81df45c7f827511d11925b6c666cf667a0aaa
  Author: Eduardo Habkost <address@hidden>
  Date:   2016-10-17 (Mon, 17 Oct 2016)

  Changed paths:
    M hw/core/machine.c

  Log Message:
  -----------
  machine: Register TYPE_MACHINE properties as class properties

When doing the conversion, the NULL errp arguments on the
property registration calls were changed to &error_abort.

Reviewed-by: Igor Mammedov <address@hidden>
Signed-off-by: Eduardo Habkost <address@hidden>


  Commit: 0efc257db9986c3521d098d3d665d26b0b788fa1
      
https://github.com/qemu/qemu/commit/0efc257db9986c3521d098d3d665d26b0b788fa1
  Author: Eduardo Habkost <address@hidden>
  Date:   2016-10-17 (Mon, 17 Oct 2016)

  Changed paths:
    M hw/i386/pc.c

  Log Message:
  -----------
  pc: Register TYPE_PC_MACHINE properties as class properties

Reviewed-by: Igor Mammedov <address@hidden>
Signed-off-by: Eduardo Habkost <address@hidden>


  Commit: e62834ca62a86f057a8bd317137a4ae37d9c0ed2
      
https://github.com/qemu/qemu/commit/e62834ca62a86f057a8bd317137a4ae37d9c0ed2
  Author: Eduardo Habkost <address@hidden>
  Date:   2016-10-17 (Mon, 17 Oct 2016)

  Changed paths:
    M backends/hostmem.c

  Log Message:
  -----------
  hostmem: Register TYPE_MEMORY_BACKEND properties as class properties

The NULL errp arguments on the property registration calls were
changed to &error_abort.

Reviewed-by: Igor Mammedov <address@hidden>
Signed-off-by: Eduardo Habkost <address@hidden>


  Commit: 026ac483c70850c82fad849de656204b16f8415e
      
https://github.com/qemu/qemu/commit/026ac483c70850c82fad849de656204b16f8415e
  Author: Eduardo Habkost <address@hidden>
  Date:   2016-10-17 (Mon, 17 Oct 2016)

  Changed paths:
    M backends/hostmem-file.c

  Log Message:
  -----------
  hostmem-file: Register TYPE_MEMORY_BACKEND_FILE properties as class properties

To do the conversion, the file_backend_class_init() was moved
after the getter/setter functions. The old
file_backend_instance_init() function was removed because it is
not needed anymore.

The NULL errp arguments on the property registration calls were
changed to &error_abort.

Reviewed-by: Igor Mammedov <address@hidden>
Signed-off-by: Eduardo Habkost <address@hidden>


  Commit: f525c8a6cb9e445ceef6e73aeccab553866b2f36
      
https://github.com/qemu/qemu/commit/f525c8a6cb9e445ceef6e73aeccab553866b2f36
  Author: Peter Maydell <address@hidden>
  Date:   2016-10-18 (Tue, 18 Oct 2016)

  Changed paths:
    M backends/hostmem-file.c
    M backends/hostmem.c
    M hw/core/machine.c
    M hw/i386/pc.c
    M vl.c

  Log Message:
  -----------
  Merge remote-tracking branch 'remotes/ehabkost/tags/machine-pull-request' 
into staging

machine + memory backend queue, 2016-10-17

# gpg: Signature made Mon 17 Oct 2016 18:54:57 BST
# gpg:                using RSA key 0x2807936F984DC5A6
# gpg: Good signature from "Eduardo Habkost <address@hidden>"
# Primary key fingerprint: 5A32 2FD5 ABC4 D3DB ACCF  D1AA 2807 936F 984D C5A6

* remotes/ehabkost/tags/machine-pull-request:
  hostmem-file: Register TYPE_MEMORY_BACKEND_FILE properties as class properties
  hostmem: Register TYPE_MEMORY_BACKEND properties as class properties
  pc: Register TYPE_PC_MACHINE properties as class properties
  machine: Register TYPE_MACHINE properties as class properties
  machine: Fix replacement of '_' by '-' in machine property names

Signed-off-by: Peter Maydell <address@hidden>


Compare: https://github.com/qemu/qemu/compare/e8ddc2eae5cc...f525c8a6cb9e