[Qemu-commits] [qemu/qemu] e9db8f: block/gluster: add support to choose libgfapi logf...

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: e9db8ff38e539260a2cb5a7918d1155b7d92a264
      
https://github.com/qemu/qemu/commit/e9db8ff38e539260a2cb5a7918d1155b7d92a264
  Author: Prasanna Kumar Kalever <address@hidden>
  Date:   2016-09-13 (Tue, 13 Sep 2016)

  Changed paths:
    M block/gluster.c
    M qapi/block-core.json

  Log Message:
  -----------
  block/gluster: add support to choose libgfapi logfile

currently all the libgfapi logs defaults to '/dev/stderr' as it was hardcoded
in a call to glfs logging api. When the debug level is chosen to DEBUG/TRACE,
gfapi logs will be huge and fill/overflow the console view.

This patch provides a commandline option to mention log file path which helps
in logging to the specified file and also help in persisting the gfapi logs.

Usage:
-----
 *URI Style:
  ---------
  -drive file=gluster://hostname/volname/image.qcow2,file.debug=9,\
                file.logfile=/var/log/qemu/qemu-gfapi.log

 *JSON Style:
  ----------
  'json:{
     "driver":"qcow2",
     "file":{
        "driver":"gluster",
        "volume":"volname",
        "path":"image.qcow2",
        "debug":"9",
        "logfile":"/var/log/qemu/qemu-gfapi.log",
        "server":[
           {
              "type":"tcp",
              "host":"1.2.3.4",
              "port":24007
           },
           {
              "type":"unix",
              "socket":"/var/run/glusterd.socket"
           }
        ]
     }
  }'

Reviewed-by: Jeff Cody <address@hidden>
Reviewed-by: Markus Armbruster <address@hidden>
Signed-off-by: Prasanna Kumar Kalever <address@hidden>
Signed-off-by: Jeff Cody <address@hidden>


  Commit: c76d7aab81c264e3452e778f030fb3760e5edbb9
      
https://github.com/qemu/qemu/commit/c76d7aab81c264e3452e778f030fb3760e5edbb9
  Author: Prasanna Kumar Kalever <address@hidden>
  Date:   2016-09-13 (Tue, 13 Sep 2016)

  Changed paths:
    M qapi/block-core.json

  Log Message:
  -----------
  qapi/block-core: add doc describing GlusterServer vs. SocketAddress

Added documentation describing relation between GlusterServer and
SocketAddress qapi schemas.

Thanks to Markus Armbruster <address@hidden>

Reviewed-by: Markus Armbruster <address@hidden>
Reviewed-by: Jeff Cody <address@hidden>
Signed-off-by: Prasanna Kumar Kalever <address@hidden>
Message-id: address@hidden
Signed-off-by: Jeff Cody <address@hidden>


  Commit: 8ede883cfaf92e99ed7527c319e62dc13ab934d8
      
https://github.com/qemu/qemu/commit/8ede883cfaf92e99ed7527c319e62dc13ab934d8
  Author: Peter Maydell <address@hidden>
  Date:   2016-09-13 (Tue, 13 Sep 2016)

  Changed paths:
    M block/gluster.c
    M qapi/block-core.json

  Log Message:
  -----------
  Merge remote-tracking branch 'remotes/cody/tags/block-pull-request' into 
staging

# gpg: Signature made Tue 13 Sep 2016 06:41:42 BST
# gpg:                using RSA key 0xBDBE7B27C0DE3057
# gpg: Good signature from "Jeffrey Cody <address@hidden>"
# gpg:                 aka "Jeffrey Cody <address@hidden>"
# gpg:                 aka "Jeffrey Cody <address@hidden>"
# Primary key fingerprint: 9957 4B4D 3474 90E7 9D98  D624 BDBE 7B27 C0DE 3057

* remotes/cody/tags/block-pull-request:
  qapi/block-core: add doc describing GlusterServer vs. SocketAddress
  block/gluster: add support to choose libgfapi logfile

Signed-off-by: Peter Maydell <address@hidden>


Compare: https://github.com/qemu/qemu/compare/7263da78045d...8ede883cfaf9