qemu-commits
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-commits] [qemu/qemu] bccdef: virtio: recalculate vq->inuse after m


From: GitHub
Subject: [Qemu-commits] [qemu/qemu] bccdef: virtio: recalculate vq->inuse after migration
Date: Wed, 24 Aug 2016 12:30:04 -0700

  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: bccdef6b1a204db0f41ffb6e24ce373e4d7890d4
      
https://github.com/qemu/qemu/commit/bccdef6b1a204db0f41ffb6e24ce373e4d7890d4
  Author: Stefan Hajnoczi <address@hidden>
  Date:   2016-08-23 (Tue, 23 Aug 2016)

  Changed paths:
    M hw/virtio/virtio.c

  Log Message:
  -----------
  virtio: recalculate vq->inuse after migration

The vq->inuse field is not migrated.  Many devices don't hold
VirtQueueElements across migration so it doesn't matter that vq->inuse
starts at 0 on the destination QEMU.

At least virtio-serial, virtio-blk, and virtio-balloon migrate while
holding VirtQueueElements.  For these devices we need to recalculate
vq->inuse upon load so the value is correct.

Cc: address@hidden
Signed-off-by: Stefan Hajnoczi <address@hidden>
Reviewed-by: Michael S. Tsirkin <address@hidden>
Reviewed-by: Cornelia Huck <address@hidden>
Reviewed-by: Michael S. Tsirkin <address@hidden>
Signed-off-by: Michael S. Tsirkin <address@hidden>


  Commit: 58a83c61496eeb0d31571a07a51bc1947e3379ac
      
https://github.com/qemu/qemu/commit/58a83c61496eeb0d31571a07a51bc1947e3379ac
  Author: Stefan Hajnoczi <address@hidden>
  Date:   2016-08-23 (Tue, 23 Aug 2016)

  Changed paths:
    M hw/virtio/virtio.c

  Log Message:
  -----------
  virtio: decrement vq->inuse in virtqueue_discard()

virtqueue_discard() moves vq->last_avail_idx back so the element can be
popped again.  It's necessary to decrement vq->inuse to avoid "leaking"
the element count.

Cc: address@hidden
Signed-off-by: Stefan Hajnoczi <address@hidden>
Reviewed-by: Michael S. Tsirkin <address@hidden>
Reviewed-by: Cornelia Huck <address@hidden>
Reviewed-by: Michael S. Tsirkin <address@hidden>
Signed-off-by: Michael S. Tsirkin <address@hidden>


  Commit: e00da552a0dc82f4ec7896281eada7201e69f1db
      
https://github.com/qemu/qemu/commit/e00da552a0dc82f4ec7896281eada7201e69f1db
  Author: Peter Maydell <address@hidden>
  Date:   2016-08-24 (Wed, 24 Aug 2016)

  Changed paths:
    M hw/virtio/virtio.c

  Log Message:
  -----------
  Merge remote-tracking branch 'remotes/mst/tags/for_upstream' into staging

virtio: fixes

some bugfixes for virtio
balloon is still broken wrt migration

Signed-off-by: Michael S. Tsirkin <address@hidden>

# gpg: Signature made Tue 23 Aug 2016 17:33:11 BST
# gpg:                using RSA key 0x281F0DB8D28D5469
# gpg: Good signature from "Michael S. Tsirkin <address@hidden>"
# gpg:                 aka "Michael S. Tsirkin <address@hidden>"
# Primary key fingerprint: 0270 606B 6F3C DF3D 0B17  0970 C350 3912 AFBE 8E67
#      Subkey fingerprint: 5D09 FD08 71C8 F85B 94CA  8A0D 281F 0DB8 D28D 5469

* remotes/mst/tags/for_upstream:
  virtio: decrement vq->inuse in virtqueue_discard()
  virtio: recalculate vq->inuse after migration

Signed-off-by: Peter Maydell <address@hidden>


Compare: https://github.com/qemu/qemu/compare/8c1c230a6e94...e00da552a0dc

reply via email to

[Prev in Thread] Current Thread [Next in Thread]