[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-commits] [qemu/qemu] 8afc22: virtio-gpu: fix missing log.h include
From: |
GitHub |
Subject: |
[Qemu-commits] [qemu/qemu] 8afc22: virtio-gpu: fix missing log.h include file |
Date: |
Tue, 16 Aug 2016 04:00:03 -0700 |
Branch: refs/heads/master
Home: https://github.com/qemu/qemu
Commit: 8afc224ffeca281c9f332e3821831642194797ba
https://github.com/qemu/qemu/commit/8afc224ffeca281c9f332e3821831642194797ba
Author: Daniel P. Berrange <address@hidden>
Date: 2016-08-16 (Tue, 16 Aug 2016)
Changed paths:
M include/hw/virtio/virtio-gpu.h
Log Message:
-----------
virtio-gpu: fix missing log.h include file
The virtio-gpu.h file defines a macro VIRTIO_GPU_FILL_CMD
which includes a call to qemu_log_mask, but does not
include qemu/log.h. In a default configure, it is lucky
and gets qemu/log.h indirectly due to the 'log' trace
backend being enabled. If that trace backend is disabled
though, eg
./configure --enable-trace-backends=nop
Then the build will fail:
In file included from
/home/berrange/src/virt/qemu/hw/display/virtio-gpu-3d.c:19:0:
/home/berrange/src/virt/qemu/hw/display/virtio-gpu-3d.c: In function
‘virgl_cmd_create_resource_2d’:
/home/berrange/src/virt/qemu/include/hw/virtio/virtio-gpu.h:138:13: error:
implicit declaration of function ‘qemu_log_mask’
[-Werror=implicit-function-declaration]
qemu_log_mask(LOG_GUEST_ERROR, \
^
/home/berrange/src/virt/qemu/hw/display/virtio-gpu-3d.c:34:5: note: in
expansion of macro ‘VIRTIO_GPU_FILL_CMD’
VIRTIO_GPU_FILL_CMD(c2d);
^~~~~~~~~~~~~~~~~~~
/home/berrange/src/virt/qemu/hw/display/virtio-gpu-3d.c:34:5: error: nested
extern declaration of ‘qemu_log_mask’ [-Werror=nested-externs]
In file included from
/home/berrange/src/virt/qemu/hw/display/virtio-gpu-3d.c:19:0:
/home/berrange/src/virt/qemu/include/hw/virtio/virtio-gpu.h:138:27: error:
‘LOG_GUEST_ERROR’ undeclared (first use in this function)
qemu_log_mask(LOG_GUEST_ERROR, \
[snip many more errors]
Signed-off-by: Daniel P. Berrange <address@hidden>
Message-id: address@hidden
Reviewed-by: Peter Maydell <address@hidden>
Signed-off-by: Peter Maydell <address@hidden>
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- [Qemu-commits] [qemu/qemu] 8afc22: virtio-gpu: fix missing log.h include file,
GitHub <=