[Qemu-commits] [qemu/qemu] df3c28: error: Strip trailing '\n' from error string argum...

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: df3c286c53ac51e7267f2761c7a0c62e11b6e815
      
https://github.com/qemu/qemu/commit/df3c286c53ac51e7267f2761c7a0c62e11b6e815
  Author: Markus Armbruster <address@hidden>
  Date:   2016-08-08 (Mon, 08 Aug 2016)

  Changed paths:
    M hw/mips/cps.c
    M hw/nvram/fw_cfg.c
    M hw/ppc/spapr_cpu_core.c
    M qemu-img.c
    A scripts/coccinelle/err-bad-newline.cocci
    M slirp/slirp.c
    M target-i386/kvm.c

  Log Message:
  -----------
  error: Strip trailing '\n' from error string arguments (again)

Commit 9af9e0f, 6daf194d, be62a2eb and 312fd5f got rid of a bunch, but
they keep coming back.  checkpatch.pl tries to flag them since commit
5d596c2, but it's not very good at it.  Offenders tracked down with
Coccinelle script scripts/coccinelle/err-bad-newline.cocci, an updated
version of the script from commit 312fd5f.

Signed-off-by: Markus Armbruster <address@hidden>
Message-Id: <address@hidden>
Reviewed-by: Eric Blake <address@hidden>


  Commit: a47eb010983b98d41330878f8b3e3193da40e6ed
      
https://github.com/qemu/qemu/commit/a47eb010983b98d41330878f8b3e3193da40e6ed
  Author: Markus Armbruster <address@hidden>
  Date:   2016-08-08 (Mon, 08 Aug 2016)

  Changed paths:
    M scripts/checkpatch.pl

  Log Message:
  -----------
  checkpatch: Fix newline detection in error_setg() & friends

Commit 5d596c2's regexp assumes the error message string is the first
argument.  Correct for error_report(), wrong for all the others.
Relax the regexp to match newline in anywhere.  This might cause
additional false positives.

While there, update the list of error_reporting functions.

Cc: Jason J. Herne <address@hidden>
Signed-off-by: Markus Armbruster <address@hidden>
Message-Id: <address@hidden>
Reviewed-by: Eric Blake <address@hidden>


  Commit: fea1c0999a67217207ece63a25ed88c796c19515
      
https://github.com/qemu/qemu/commit/fea1c0999a67217207ece63a25ed88c796c19515
  Author: Markus Armbruster <address@hidden>
  Date:   2016-08-08 (Mon, 08 Aug 2016)

  Changed paths:
    M hw/vfio/platform.c

  Log Message:
  -----------
  vfio: Use error_report() instead of error_printf() for errors

Cc: Alex Williamson <address@hidden>
Signed-off-by: Markus Armbruster <address@hidden>
Message-Id: <address@hidden>
Reviewed-by: Eric Blake <address@hidden>


  Commit: 7ea7d36e3493d4dac7f20e46d0ca499bbb3251a6
      
https://github.com/qemu/qemu/commit/7ea7d36e3493d4dac7f20e46d0ca499bbb3251a6
  Author: Markus Armbruster <address@hidden>
  Date:   2016-08-08 (Mon, 08 Aug 2016)

  Changed paths:
    M hw/i386/pc.c
    M kvm-all.c
    M ui/vnc.c

  Log Message:
  -----------
  error: Fix error_printf() calls lacking newlines

Signed-off-by: Markus Armbruster <address@hidden>
Message-Id: <address@hidden>
Reviewed-by: Eric Blake <address@hidden>


  Commit: f5edfcfafbc0fbe2e2270b9fbcbf9009399bc27a
      
https://github.com/qemu/qemu/commit/f5edfcfafbc0fbe2e2270b9fbcbf9009399bc27a
  Author: Peter Maydell <address@hidden>
  Date:   2016-08-08 (Mon, 08 Aug 2016)

  Changed paths:
    M hw/i386/pc.c
    M hw/mips/cps.c
    M hw/nvram/fw_cfg.c
    M hw/ppc/spapr_cpu_core.c
    M hw/vfio/platform.c
    M kvm-all.c
    M qemu-img.c
    M scripts/checkpatch.pl
    A scripts/coccinelle/err-bad-newline.cocci
    M slirp/slirp.c
    M target-i386/kvm.c
    M ui/vnc.c

  Log Message:
  -----------
  Merge remote-tracking branch 'remotes/armbru/tags/pull-error-2016-08-08' into 
staging

Error reporting patches for 2016-08-08

# gpg: Signature made Mon 08 Aug 2016 08:14:49 BST
# gpg:                using RSA key 0x3870B400EB918653
# gpg: Good signature from "Markus Armbruster <address@hidden>"
# gpg:                 aka "Markus Armbruster <address@hidden>"
# Primary key fingerprint: 354B C8B3 D7EB 2A6B 6867  4E5F 3870 B400 EB91 8653

* remotes/armbru/tags/pull-error-2016-08-08:
  error: Fix error_printf() calls lacking newlines
  vfio: Use error_report() instead of error_printf() for errors
  checkpatch: Fix newline detection in error_setg() & friends
  error: Strip trailing '\n' from error string arguments (again)

Signed-off-by: Peter Maydell <address@hidden>


Compare: https://github.com/qemu/qemu/compare/9efaf7f5f572...f5edfcfafbc0