[Qemu-commits] [qemu/qemu] 3bf2b3: wxx: Fix compiler warning for host-libusb.c

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: 3bf2b3a17274e5e3ca41ba01a677ea35e060febc
      
https://github.com/qemu/qemu/commit/3bf2b3a17274e5e3ca41ba01a677ea35e060febc
  Author: Stefan Weil <address@hidden>
  Date:   2016-08-02 (Tue, 02 Aug 2016)

  Changed paths:
    M hw/usb/host-libusb.c

  Log Message:
  -----------
  wxx: Fix compiler warning for host-libusb.c

The local variable i is unsed for Windows.

Signed-off-by: Stefan Weil <address@hidden>
Message-id: address@hidden
Signed-off-by: Gerd Hoffmann <address@hidden>


  Commit: c16e366464a1884c355e85878874afffa790ecbf
      
https://github.com/qemu/qemu/commit/c16e366464a1884c355e85878874afffa790ecbf
  Author: Stefan Weil <address@hidden>
  Date:   2016-08-02 (Tue, 02 Aug 2016)

  Changed paths:
    M hw/usb/host-libusb.c

  Log Message:
  -----------
  wxx: Fix compilation of host-libusb.c

libusb.h uses the WINAPI calling convention for all function callbacks.

Cross compilation with Mingw-w64 on Cygwin fails when this calling
convention is missing.

Signed-off-by: Stefan Weil <address@hidden>
Message-id: address@hidden
Signed-off-by: Gerd Hoffmann <address@hidden>


  Commit: 72aa364b1d9daa889bb5898ea4aded9d27fd1c96
      
https://github.com/qemu/qemu/commit/72aa364b1d9daa889bb5898ea4aded9d27fd1c96
  Author: Evgeny Yakovlev <address@hidden>
  Date:   2016-08-02 (Tue, 02 Aug 2016)

  Changed paths:
    M hw/usb/hcd-ehci.c

  Log Message:
  -----------
  ehci: faster frame index calculation for skipped frames

ehci_update_frindex takes time linearly proportional to a number
of uframes to calculate new frame index and raise FLR interrupts,
which is a problem for large amounts of uframes.

If we experience large delays between echi timer callbacks (i.e. because
other periodic handlers have taken a lot of time to complete) we
get a lot of skipped frames which then delay ehci timer callback more
and this leads to deadlocking the system when ehci schedules next
callback to be too soon.

Observable behaviour is qemu consuming 100% host CPU time while guest
is unresponsive. This misbehavior could happen for a while and QEMU does
not get out from this state automatically without the patch.

This change makes ehci_update_frindex execute in constant time.

Signed-off-by: Evgeny Yakovlev <address@hidden>
Signed-off-by: Denis V. Lunev <address@hidden>
Message-id: address@hidden
CC: Gerd Hoffmann <address@hidden>
Signed-off-by: Gerd Hoffmann <address@hidden>


  Commit: c8e36e865c8a51c60343246d3a97b47559dc8c63
      
https://github.com/qemu/qemu/commit/c8e36e865c8a51c60343246d3a97b47559dc8c63
  Author: Juergen Gross <address@hidden>
  Date:   2016-08-03 (Wed, 03 Aug 2016)

  Changed paths:
    M hw/xen/xen_backend.c

  Log Message:
  -----------
  xen: when removing a backend don't remove many of them

When a Xenstore watch fires indicating a backend has to be removed
don't remove all backends for that domain with the specified device
index, but just the one which has the correct type.

The easiest way to achieve this is to use the already determined
xendev as parameter for xen_be_del_xendev() instead of only the domid
and device index.

This at once removes the open coded QTAILQ_FOREACH_SAVE() in
xen_be_del_xendev() as there is no need to search for the correct
xendev any longer.

Signed-off-by: Juergen Gross <address@hidden>
Reviewed-by: Stefano Stabellini <address@hidden>
Message-id: address@hidden
Signed-off-by: Gerd Hoffmann <address@hidden>


  Commit: 80440ea033b02d9c7330d507daf41d4bf8a8c058
      
https://github.com/qemu/qemu/commit/80440ea033b02d9c7330d507daf41d4bf8a8c058
  Author: Juergen Gross <address@hidden>
  Date:   2016-08-03 (Wed, 03 Aug 2016)

  Changed paths:
    M hw/usb/xen-usb.c

  Log Message:
  -----------
  xen: drain submit queue in xen-usb before removing device

When unplugging a device in the Xen pvusb backend drain the submit
queue before deallocation of the control structures. Otherwise there
will be bogus memory accesses when I/O contracts are finished.

Correlated to this issue is the handling of cancel requests: a packet
cancelled will still lead to the call of complete, so add a flag
to the request indicating it should be just dropped on complete.

Signed-off-by: Juergen Gross <address@hidden>
Acked-by: Anthony PERARD <address@hidden>
Message-id: address@hidden
Signed-off-by: Gerd Hoffmann <address@hidden>


  Commit: 0e39bb022b5fa8c11964968885f3263c02ce42b0
      
https://github.com/qemu/qemu/commit/0e39bb022b5fa8c11964968885f3263c02ce42b0
  Author: Juergen Gross <address@hidden>
  Date:   2016-08-03 (Wed, 03 Aug 2016)

  Changed paths:
    M hw/xen/xen_backend.c
    M hw/xenpv/xen_machine_pv.c
    M include/hw/xen/xen_backend.h
    M xen-hvm.c

  Log Message:
  -----------
  xen: use a common function for pv and hvm guest backend register calls

Instead of calling xen_be_register() for each supported backend type
for hvm and pv guests in their machine init functions use a common
function in order not to have to add new backends twice.

This at once fixes the error that hvm domains couldn't use the qusb
backend.

Signed-off-by: Juergen Gross <address@hidden>
Acked-by: Anthony PERARD <address@hidden>
Message-id: address@hidden
Signed-off-by: Gerd Hoffmann <address@hidden>


  Commit: 6eac5f7bad6cd8f56b3514ac485dd35d79abff66
      
https://github.com/qemu/qemu/commit/6eac5f7bad6cd8f56b3514ac485dd35d79abff66
  Author: Peter Maydell <address@hidden>
  Date:   2016-08-03 (Wed, 03 Aug 2016)

  Changed paths:
    M hw/usb/hcd-ehci.c
    M hw/usb/host-libusb.c
    M hw/usb/xen-usb.c
    M hw/xen/xen_backend.c
    M hw/xenpv/xen_machine_pv.c
    M include/hw/xen/xen_backend.h
    M xen-hvm.c

  Log Message:
  -----------
  Merge remote-tracking branch 'remotes/kraxel/tags/pull-usb-20160803-1' into 
staging

usb: bugfixes for xen-usb and ehci, mingw build fix.

# gpg: Signature made Wed 03 Aug 2016 14:04:26 BST
# gpg:                using RSA key 0x4CB6D8EED3E87138
# gpg: Good signature from "Gerd Hoffmann (work) <address@hidden>"
# gpg:                 aka "Gerd Hoffmann <address@hidden>"
# gpg:                 aka "Gerd Hoffmann (private) <address@hidden>"
# Primary key fingerprint: A032 8CFF B93A 17A7 9901  FE7D 4CB6 D8EE D3E8 7138

* remotes/kraxel/tags/pull-usb-20160803-1:
  xen: use a common function for pv and hvm guest backend register calls
  xen: drain submit queue in xen-usb before removing device
  xen: when removing a backend don't remove many of them
  ehci: faster frame index calculation for skipped frames
  wxx: Fix compilation of host-libusb.c
  wxx: Fix compiler warning for host-libusb.c

Signed-off-by: Peter Maydell <address@hidden>


Compare: https://github.com/qemu/qemu/compare/0cb34ff32e31...6eac5f7bad6c