qemu-commits
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-commits] [qemu/qemu] 7f81db: hw/mips_malta: Fix YAMON API print ro


From: GitHub
Subject: [Qemu-commits] [qemu/qemu] 7f81db: hw/mips_malta: Fix YAMON API print routine
Date: Fri, 29 Jul 2016 06:00:03 -0700

  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: 7f81dbb9a0e89b5306c1337e0cd0e1cea8a03f6d
      
https://github.com/qemu/qemu/commit/7f81dbb9a0e89b5306c1337e0cd0e1cea8a03f6d
  Author: Paul Burton <address@hidden>
  Date:   2016-07-28 (Thu, 28 Jul 2016)

  Changed paths:
    M hw/mips/mips_malta.c

  Log Message:
  -----------
  hw/mips_malta: Fix YAMON API print routine

The print routine provided as part of the in-built bootloader had a bug
in that it attempted to use a jump instruction as part of a loop, but
the target has its upper bits zeroed leading to control flow
transferring to 0xb0000814 rather than the intended 0xbfc00814. Fix this
by using a branch instruction instead, which seems more fit for purpose.

A simple way to test this is to build a Linux kernel with EVA enabled &
attempt to boot it in QEMU. It will attempt to print a message
indicating the configuration mismatch but QEMU would previously
incorrectly jump & wind up printing a continuous stream of the letter E.

Signed-off-by: Paul Burton <address@hidden>
Cc: Aurelien Jarno <address@hidden>
Cc: Leon Alrae <address@hidden>
Reviewed-by: Aurelien Jarno <address@hidden>
Reviewed-by: Leon Alrae <address@hidden>
Signed-off-by: Leon Alrae <address@hidden>


  Commit: 701074a6fc7470d0ed54e4a4bcd4d491ad8da22e
      
https://github.com/qemu/qemu/commit/701074a6fc7470d0ed54e4a4bcd4d491ad8da22e
  Author: Leon Alrae <address@hidden>
  Date:   2016-07-28 (Thu, 28 Jul 2016)

  Changed paths:
    M target-mips/helper.c

  Log Message:
  -----------
  target-mips: fix EntryHi.EHINV being cleared on TLB exception

While implementing TLB invalidation feature we forgot to modify
part of code responsible for updating EntryHi during TLB exception.
Consequently EntryHi.EHINV is unexpectedly cleared on the exception.

Signed-off-by: Leon Alrae <address@hidden>


  Commit: c7e9aafe5c2fc82858a3026862ac05c33d363ffb
      
https://github.com/qemu/qemu/commit/c7e9aafe5c2fc82858a3026862ac05c33d363ffb
  Author: Peter Maydell <address@hidden>
  Date:   2016-07-29 (Fri, 29 Jul 2016)

  Changed paths:
    M hw/mips/mips_malta.c
    M target-mips/helper.c

  Log Message:
  -----------
  Merge remote-tracking branch 'remotes/lalrae/tags/mips-20160729' into staging

MIPS patches 2016-07-29

Changes:
* bug fixes

# gpg: Signature made Fri 29 Jul 2016 09:44:13 BST
# gpg:                using RSA key 0x52118E3C0B29DA6B
# gpg: Good signature from "Leon Alrae <address@hidden>"
# Primary key fingerprint: 8DD3 2F98 5495 9D66 35D4  4FC0 5211 8E3C 0B29 DA6B

* remotes/lalrae/tags/mips-20160729:
  target-mips: fix EntryHi.EHINV being cleared on TLB exception
  hw/mips_malta: Fix YAMON API print routine

Signed-off-by: Peter Maydell <address@hidden>


Compare: https://github.com/qemu/qemu/compare/df2c35902e31...c7e9aafe5c2f

reply via email to

[Prev in Thread] Current Thread [Next in Thread]