[Qemu-commits] [qemu/qemu] f81bb3: xhci: Fix possible side effect from assert()

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: f81bb347ef80e94204b719e1d5e827babb556220
      
https://github.com/qemu/qemu/commit/f81bb347ef80e94204b719e1d5e827babb556220
  Author: Alexey Kardashevskiy <address@hidden>
  Date:   2016-07-20 (Wed, 20 Jul 2016)

  Changed paths:
    M hw/usb/hcd-xhci.c

  Log Message:
  -----------
  xhci: Fix possible side effect from assert()

A static analysis tool called BEAM detected possible side effect from
assert() calling a helper which may change an XHCI ring after every call.

This moves xhci_ring_fetch() out of assert() so it will be called
with and without enabled debug.

Signed-off-by: Alexey Kardashevskiy <address@hidden>
Message-id: address@hidden
Signed-off-by: Gerd Hoffmann <address@hidden>


  Commit: 87ae924b73cbbe13ad800ab2016d011b42456f25
      
https://github.com/qemu/qemu/commit/87ae924b73cbbe13ad800ab2016d011b42456f25
  Author: Gerd Hoffmann <address@hidden>
  Date:   2016-07-20 (Wed, 20 Jul 2016)

  Changed paths:
    M hw/usb/redirect.c

  Log Message:
  -----------
  usbredir: add streams property

Enabled by default, can be used to turn off (usb3) streams support.
xhci has a such a property too (same name, same default).

Signed-off-by: Gerd Hoffmann <address@hidden>
Message-id: address@hidden


  Commit: 6a426eb27ec17684808ab87374f51d6ed3a47835
      
https://github.com/qemu/qemu/commit/6a426eb27ec17684808ab87374f51d6ed3a47835
  Author: Peter Maydell <address@hidden>
  Date:   2016-07-20 (Wed, 20 Jul 2016)

  Changed paths:
    M hw/usb/hcd-xhci.c
    M hw/usb/redirect.c

  Log Message:
  -----------
  Merge remote-tracking branch 'remotes/kraxel/tags/pull-usb-20160720-1' into 
staging

usb: xhci assert fix, add usbredir streams property

# gpg: Signature made Wed 20 Jul 2016 12:32:09 BST
# gpg:                using RSA key 0x4CB6D8EED3E87138
# gpg: Good signature from "Gerd Hoffmann (work) <address@hidden>"
# gpg:                 aka "Gerd Hoffmann <address@hidden>"
# gpg:                 aka "Gerd Hoffmann (private) <address@hidden>"
# Primary key fingerprint: A032 8CFF B93A 17A7 9901  FE7D 4CB6 D8EE D3E8 7138

* remotes/kraxel/tags/pull-usb-20160720-1:
  usbredir: add streams property
  xhci: Fix possible side effect from assert()

Signed-off-by: Peter Maydell <address@hidden>


Compare: https://github.com/qemu/qemu/compare/518cb31fa7d2...6a426eb27ec1