qemu-commits
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-commits] [qemu/qemu] ff9d3e: target-arm: Fix unreachable code in g


From: GitHub
Subject: [Qemu-commits] [qemu/qemu] ff9d3e: target-arm: Fix unreachable code in gicv3_class_na...
Date: Wed, 20 Jul 2016 06:00:06 -0700

  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: ff9d3e9cd9f7c41d8b822c0d12b0176d8e7e530d
      
https://github.com/qemu/qemu/commit/ff9d3e9cd9f7c41d8b822c0d12b0176d8e7e530d
  Author: Peter Maydell <address@hidden>
  Date:   2016-07-19 (Tue, 19 Jul 2016)

  Changed paths:
    M target-arm/machine.c

  Log Message:
  -----------
  target-arm: Fix unreachable code in gicv3_class_name()

Coverity complains that the exit() in gicv3_class_name()
can be unreachable, because if TARGET_AARCH64 is defined
then all code paths return before reaching it. Move the
exit() up to the error_report() that it belongs with.

Signed-off-by: Peter Maydell <address@hidden>
Reviewed-by: Shannon Zhao <address@hidden>
Message-id: address@hidden


  Commit: acd82796211041c5af43c8c523b85d250c2ccebe
      
https://github.com/qemu/qemu/commit/acd82796211041c5af43c8c523b85d250c2ccebe
  Author: Peter Maydell <address@hidden>
  Date:   2016-07-19 (Tue, 19 Jul 2016)

  Changed paths:
    M hw/intc/arm_gicv3_redist.c

  Log Message:
  -----------
  arm_gicv3: Add assert()s to tell Coverity that offsets are aligned

Coverity complains that the GICR_IPRIORITYR case in gicv3_readl()
can overflow an array, because it doesn't know that the offsets
passed to that function must be word aligned. Add some assert()s
which hopefully tell Coverity that this isn't possible.

Signed-off-by: Peter Maydell <address@hidden>
Message-id: address@hidden


  Commit: 338404d061144956b76f9893ca3434d057dff2d4
      
https://github.com/qemu/qemu/commit/338404d061144956b76f9893ca3434d057dff2d4
  Author: Peter Maydell <address@hidden>
  Date:   2016-07-20 (Wed, 20 Jul 2016)

  Changed paths:
    M hw/intc/arm_gicv3_redist.c
    M target-arm/machine.c

  Log Message:
  -----------
  Merge remote-tracking branch 'remotes/pmaydell/tags/pull-target-arm-20160719' 
into staging

target-arm queue:
 * fix two minor Coverity complaints

# gpg: Signature made Tue 19 Jul 2016 18:02:34 BST
# gpg:                using RSA key 0x3C2525ED14360CDE
# gpg: Good signature from "Peter Maydell <address@hidden>"
# gpg:                 aka "Peter Maydell <address@hidden>"
# gpg:                 aka "Peter Maydell <address@hidden>"
# Primary key fingerprint: E1A5 C593 CD41 9DE2 8E83  15CF 3C25 25ED 1436 0CDE

* remotes/pmaydell/tags/pull-target-arm-20160719:
  arm_gicv3: Add assert()s to tell Coverity that offsets are aligned
  target-arm: Fix unreachable code in gicv3_class_name()

Signed-off-by: Peter Maydell <address@hidden>


Compare: https://github.com/qemu/qemu/compare/1ecfb24da987...338404d06114

reply via email to

[Prev in Thread] Current Thread [Next in Thread]