qemu-commits
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-commits] [qemu/qemu] 5a8be0: vnc: make sure we finish disconnect


From: GitHub
Subject: [Qemu-commits] [qemu/qemu] 5a8be0: vnc: make sure we finish disconnect
Date: Tue, 19 Jul 2016 07:00:05 -0700

  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: 5a8be0f73d6f60ff08746377eb09ca459f39deab
      
https://github.com/qemu/qemu/commit/5a8be0f73d6f60ff08746377eb09ca459f39deab
  Author: Gerd Hoffmann <address@hidden>
  Date:   2016-07-15 (Fri, 15 Jul 2016)

  Changed paths:
    M ui/vnc.c

  Log Message:
  -----------
  vnc: make sure we finish disconnect

It may happen that vnc connections linger in disconnecting state forever
because VncState happens to be in a state where vnc_update_client()
exists early and never reaches the vnc_disconnect_finish() call at the
bottom of the function.  Fix that by doing an additinal check at the
start of the function.

https://bugzilla.redhat.com/show_bug.cgi?id=1352799

Signed-off-by: Gerd Hoffmann <address@hidden>
Message-id: address@hidden


  Commit: 3f7e51bca3ef2d64c53b35ab9916c99e4a9e3c69
      
https://github.com/qemu/qemu/commit/3f7e51bca3ef2d64c53b35ab9916c99e4a9e3c69
  Author: Herongguang (Stephen) <address@hidden>
  Date:   2016-07-15 (Fri, 15 Jul 2016)

  Changed paths:
    M ui/vnc-enc-tight.c

  Log Message:
  -----------
  vnc-enc-tight: fix off-by-one bug

In tight_encode_indexed_rect32, buf(or src)’s size is count. In for loop,
the logic is supposed to be that i is an index into src, i should be
incremented when incrementing src.

This is broken when src is incremented but i is not before while loop,
resulting in off-by-one bug in while loop.

Signed-off-by: He Rongguang <address@hidden>
Message-id: address@hidden
Signed-off-by: Gerd Hoffmann <address@hidden>


  Commit: 66668d197fa40747e835e15617eda2f1bc80982f
      
https://github.com/qemu/qemu/commit/66668d197fa40747e835e15617eda2f1bc80982f
  Author: Peter Lieven <address@hidden>
  Date:   2016-07-15 (Fri, 15 Jul 2016)

  Changed paths:
    M ui/vnc-enc-tight.c

  Log Message:
  -----------
  vnc-tight: fix regression with libxenstore

commit 095497ff added thread local storage for the color counting
palette. Unfortunately, a VncPalette is about 7kB on a x86_64 system.
This memory is reserved from the stack of every thread and it
exhausted the stack space of a libxenstore thread.

Fix this by allocating memory only for the VNC encoding thread.

Fixes: 095497ffc66b7f031ff2a17f1e50f5cb105ce588
Reported-by: Juergen Gross <address@hidden>
Tested-by: Juergen Gross <address@hidden>
Signed-off-by: Peter Lieven <address@hidden>
Message-id: address@hidden
Signed-off-by: Gerd Hoffmann <address@hidden>


  Commit: 1df8ffb286b65cd446b77f54418293487a85dc43
      
https://github.com/qemu/qemu/commit/1df8ffb286b65cd446b77f54418293487a85dc43
  Author: Peter Maydell <address@hidden>
  Date:   2016-07-19 (Tue, 19 Jul 2016)

  Changed paths:
    M ui/vnc-enc-tight.c
    M ui/vnc.c

  Log Message:
  -----------
  Merge remote-tracking branch 'remotes/kraxel/tags/pull-vnc-20160719-1' into 
staging

vnc: bugfixes for -rc0

# gpg: Signature made Tue 19 Jul 2016 08:27:05 BST
# gpg:                using RSA key 0x4CB6D8EED3E87138
# gpg: Good signature from "Gerd Hoffmann (work) <address@hidden>"
# gpg:                 aka "Gerd Hoffmann <address@hidden>"
# gpg:                 aka "Gerd Hoffmann (private) <address@hidden>"
# Primary key fingerprint: A032 8CFF B93A 17A7 9901  FE7D 4CB6 D8EE D3E8 7138

* remotes/kraxel/tags/pull-vnc-20160719-1:
  vnc-tight: fix regression with libxenstore
  vnc-enc-tight: fix off-by-one bug
  vnc: make sure we finish disconnect

Signed-off-by: Peter Maydell <address@hidden>


Compare: https://github.com/qemu/qemu/compare/68ab919f0bf3...1df8ffb286b6

reply via email to

[Prev in Thread] Current Thread [Next in Thread]