[Qemu-commits] [qemu/qemu] cde8dc: msmouse: add MouseState, unregister handler on clo...

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: cde8dcbc926d9b960a96c7d637b9c23515e06c0b
      
https://github.com/qemu/qemu/commit/cde8dcbc926d9b960a96c7d637b9c23515e06c0b
  Author: Gerd Hoffmann <address@hidden>
  Date:   2016-07-12 (Tue, 12 Jul 2016)

  Changed paths:
    M backends/msmouse.c

  Log Message:
  -----------
  msmouse: add MouseState, unregister handler on close

Add struct to track serial mouse state.  Store mouse event handler
there.  Unregister properly on chardev close.

Signed-off-by: Gerd Hoffmann <address@hidden>
Acked-by: Paolo Bonzini <address@hidden>
Message-id: address@hidden


  Commit: 57a4e3b92b6e87158c1e5192fb99a5ac3b82dd5a
      
https://github.com/qemu/qemu/commit/57a4e3b92b6e87158c1e5192fb99a5ac3b82dd5a
  Author: Gerd Hoffmann <address@hidden>
  Date:   2016-07-12 (Tue, 12 Jul 2016)

  Changed paths:
    M backends/msmouse.c

  Log Message:
  -----------
  msmouse: fix buffer handling

The msmouse chardev backend writes data without checking whenever there
is enough space.

That happens to work with linux guests, probably by pure luck because
the linux driver enables the fifo and the serial port emulation accepts
more data than announced via qemu_chr_be_can_write() in that case.

Handle this properly by adding a buffer to MouseState.  Hook up a
CharDriverState->accept_input() handler which feeds the buffer to the
serial port.  msmouse_event() only fills the buffer now, and calls the
accept_input handler too to kick off the transmission.

Signed-off-by: Gerd Hoffmann <address@hidden>
Acked-by: Paolo Bonzini <address@hidden>
Message-id: address@hidden


  Commit: 96d7c0720e6a9dff7a8fd61528e6b04bd9aa9673
      
https://github.com/qemu/qemu/commit/96d7c0720e6a9dff7a8fd61528e6b04bd9aa9673
  Author: Gerd Hoffmann <address@hidden>
  Date:   2016-07-12 (Tue, 12 Jul 2016)

  Changed paths:
    M backends/msmouse.c

  Log Message:
  -----------
  msmouse: switch to new input interface

Signed-off-by: Gerd Hoffmann <address@hidden>
Message-id: address@hidden


  Commit: d7b7f526b18dacda8ee559dc18c13d4430a78b68
      
https://github.com/qemu/qemu/commit/d7b7f526b18dacda8ee559dc18c13d4430a78b68
  Author: Gerd Hoffmann <address@hidden>
  Date:   2016-07-12 (Tue, 12 Jul 2016)

  Changed paths:
    M backends/msmouse.c

  Log Message:
  -----------
  msmouse: send short messages if possible.

Keep track of button changes.  Send the extended 4-byte messages for
three button mice only in case we have something to report for the
middle button.  Use the short 3-byte messages (original protocol for
two-button microsoft mouse) otherwise.

Signed-off-by: Gerd Hoffmann <address@hidden>
Message-id: address@hidden


  Commit: c80276b4206d534daaaf87305df5805db1b8db02
      
https://github.com/qemu/qemu/commit/c80276b4206d534daaaf87305df5805db1b8db02
  Author: Gerd Hoffmann <address@hidden>
  Date:   2016-07-12 (Tue, 12 Jul 2016)

  Changed paths:
    M hw/input/hid.c
    M hw/input/trace-events
    M hw/input/virtio-input.c

  Log Message:
  -----------
  input: add trace events for full queues

It isn't unusual to happen, for example during reboot when the guest
doesn't reveice events for a while.  So better don't flood stderr
with alarming messages.  Turn them into tracepoints instead so they
can be enabled in case they are needed for trouble-shooting.

Signed-off-by: Gerd Hoffmann <address@hidden>
Message-id: address@hidden


  Commit: d4df42c43168873521632836bdffecf2f3a9f9f1
      
https://github.com/qemu/qemu/commit/d4df42c43168873521632836bdffecf2f3a9f9f1
  Author: Gerd Hoffmann <address@hidden>
  Date:   2016-07-12 (Tue, 12 Jul 2016)

  Changed paths:
    M ui/input-linux.c

  Log Message:
  -----------
  input-linux: factor out input_linux_handle_mouse

No functional change.

Signed-off-by: Gerd Hoffmann <address@hidden>
Message-id: address@hidden


  Commit: 2330e9e7cca29346df74b21105a587d9478ff296
      
https://github.com/qemu/qemu/commit/2330e9e7cca29346df74b21105a587d9478ff296
  Author: Gerd Hoffmann <address@hidden>
  Date:   2016-07-12 (Tue, 12 Jul 2016)

  Changed paths:
    M ui/input-linux.c

  Log Message:
  -----------
  input-linux: factor out input_linux_handle_keyboard

No functional change.

Signed-off-by: Gerd Hoffmann <address@hidden>
Message-id: address@hidden


  Commit: 2e6a64cb8d7506ad27d3b6c8000bc8d773936932
      
https://github.com/qemu/qemu/commit/2e6a64cb8d7506ad27d3b6c8000bc8d773936932
  Author: Gerd Hoffmann <address@hidden>
  Date:   2016-07-12 (Tue, 12 Jul 2016)

  Changed paths:
    M ui/input-linux.c

  Log Message:
  -----------
  input-linux: better capability checks, merge input_linux_event_{mouse, 
keyboard}

Improve capability checks (count keys and buttons), store results.

Merge the input_linux_event_mouse and input_linux_event_keyboard
functions into one, dispatch into input_linux_handle_mouse and
input_linux_handle_keyboard depending on device capabilities.

Allow calling both handle functions, so we can handle mice which
also send key events, by routing those key events to the keyboard.

Signed-off-by: Gerd Hoffmann <address@hidden>
Message-id: address@hidden


  Commit: 494edbf0b499e342d466e3dea334fd6ae1d56278
      
https://github.com/qemu/qemu/commit/494edbf0b499e342d466e3dea334fd6ae1d56278
  Author: Peter Maydell <address@hidden>
  Date:   2016-07-12 (Tue, 12 Jul 2016)

  Changed paths:
    M backends/msmouse.c
    M hw/input/hid.c
    M hw/input/trace-events
    M hw/input/virtio-input.c
    M ui/input-linux.c

  Log Message:
  -----------
  Merge remote-tracking branch 'remotes/kraxel/tags/pull-input-20160712-1' into 
staging

msmouse: fix misc issues, switch to new input interface.
input: add trace events for full queues.
input-linux: better capability checks and event handling.

# gpg: Signature made Tue 12 Jul 2016 09:20:36 BST
# gpg:                using RSA key 0x4CB6D8EED3E87138
# gpg: Good signature from "Gerd Hoffmann (work) <address@hidden>"
# gpg:                 aka "Gerd Hoffmann <address@hidden>"
# gpg:                 aka "Gerd Hoffmann (private) <address@hidden>"
# Primary key fingerprint: A032 8CFF B93A 17A7 9901  FE7D 4CB6 D8EE D3E8 7138

* remotes/kraxel/tags/pull-input-20160712-1:
  input-linux: better capability checks, merge input_linux_event_{mouse, 
keyboard}
  input-linux: factor out input_linux_handle_keyboard
  input-linux: factor out input_linux_handle_mouse
  input: add trace events for full queues
  msmouse: send short messages if possible.
  msmouse: switch to new input interface
  msmouse: fix buffer handling
  msmouse: add MouseState, unregister handler on close

Signed-off-by: Peter Maydell <address@hidden>


Compare: https://github.com/qemu/qemu/compare/910789c22081...494edbf0b499