qemu-commits
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-commits] [qemu/qemu] 92fe2b: configure: Improve usermode relocatio


From: GitHub
Subject: [Qemu-commits] [qemu/qemu] 92fe2b: configure: Improve usermode relocation linker opti...
Date: Tue, 28 Jun 2016 08:30:04 -0700

  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: 92fe2ba8b0615cce949e593309dd295698e77324
      
https://github.com/qemu/qemu/commit/92fe2ba8b0615cce949e593309dd295698e77324
  Author: Peter Maydell <address@hidden>
  Date:   2016-06-28 (Tue, 28 Jun 2016)

  Changed paths:
    M configure

  Log Message:
  -----------
  configure: Improve usermode relocation linker option probe

The probe we do to determine what flags to use to make the usermode
executables use a non-default text address has some flaws:
 * we run it even if we're not building the user binaries
 * we don't expect "ld --verbose" to fail

The combination of these two results in a harmless but
ugly "ld: unknown option: --verbose" message when running
configure on OSX.

Improve the probe to only run when we need it and to fail
nicely when even the backstop 'ld --verbose' approach fails.

Reported-by: Stefan Weil <address@hidden>
Signed-off-by: Peter Maydell <address@hidden>
Reviewed-by: Stefan Weil <address@hidden>
Message-id: address@hidden


  Commit: 7dd929dfdc5c52ce79b21bf557ff506e89acbf63
      
https://github.com/qemu/qemu/commit/7dd929dfdc5c52ce79b21bf557ff506e89acbf63
  Author: Peter Maydell <address@hidden>
  Date:   2016-06-28 (Tue, 28 Jun 2016)

  Changed paths:
    M configure

  Log Message:
  -----------
  configure: Make AVX2 test robust to non-ELF systems

The AVX2 optimization test assumes that the object format
is ELF and the system has the readelf utility. If this isn't
true then configure might fail or emit a warning (since in
a pipe "foo | bar >/dev/null 2>&1" does not redirect the
stderr of foo, only of bar). Adjust the check so that if
we don't have readelf or don't have an ELF object then we
just don't enable the AVX2 optimization.

Reported-by: Stefan Weil <address@hidden>
Signed-off-by: Peter Maydell <address@hidden>
Reviewed-by: Stefan Weil <address@hidden>
Message-id: address@hidden


Compare: https://github.com/qemu/qemu/compare/b7a511248d10...7dd929dfdc5c

reply via email to

[Prev in Thread] Current Thread [Next in Thread]