[Qemu-commits] [qemu/qemu] f9a8b5: qdev: Use GList for global properties

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: f9a8b5530d438f836f9697639814f585aaec554d
      
https://github.com/qemu/qemu/commit/f9a8b5530d438f836f9697639814f585aaec554d
  Author: Eduardo Habkost <address@hidden>
  Date:   2016-06-17 (Fri, 17 Jun 2016)

  Changed paths:
    M hw/core/qdev-properties.c
    M include/hw/qdev-core.h

  Log Message:
  -----------
  qdev: Use GList for global properties

If the same GlobalProperty struct is registered twice, the list
entry gets corrupted, making tqe_next points to itself, and
qdev_prop_set_globals() gets stuck in a loop. The bug can be
easily reproduced by running:

  $ qemu-system-x86_64 -rtc-td-hack -rtc-td-hack

Change global_props to use GList instead of queue.h, making the
code simpler and able to deal with properties being registered
twice.

Reviewed-by: Michael S. Tsirkin <address@hidden>
Signed-off-by: Eduardo Habkost <address@hidden>


  Commit: a663fbd9e2f65fae81018d81f231ad79510cf9fb
      
https://github.com/qemu/qemu/commit/a663fbd9e2f65fae81018d81f231ad79510cf9fb
  Author: Chao Peng <address@hidden>
  Date:   2016-06-17 (Fri, 17 Jun 2016)

  Changed paths:
    M vl.c

  Log Message:
  -----------
  vnc: Wrap vnc initialization code with CONFIG_VNC

commit f8c75b2486 (vnc: Initialization stubs) removed CONFIG_VNC in vl.c
code. However qemu_find_opts("vnc") is NULL when vnc is configured out.
Crash will happen in qemu_opts_foreach() before stub vnc_init_func() is
called. This patch add it back.

Cc: Eduardo Habkost <address@hidden>
Reviewed-by: Eduardo Habkost <address@hidden>
Signed-off-by: Chao Peng <address@hidden>
Signed-off-by: Eduardo Habkost <address@hidden>


  Commit: da838dfc40cb7e12e2ae7b33236e426e029fed15
      
https://github.com/qemu/qemu/commit/da838dfc40cb7e12e2ae7b33236e426e029fed15
  Author: Peter Maydell <address@hidden>
  Date:   2016-06-17 (Fri, 17 Jun 2016)

  Changed paths:
    M hw/core/qdev-properties.c
    M include/hw/qdev-core.h
    M vl.c

  Log Message:
  -----------
  Merge remote-tracking branch 'remotes/ehabkost/tags/machine-pull-request' 
into staging

Machine queue, 2016-06-17

# gpg: Signature made Fri 17 Jun 2016 14:45:48 BST
# gpg:                using RSA key 0x2807936F984DC5A6
# gpg: Good signature from "Eduardo Habkost <address@hidden>"
# Primary key fingerprint: 5A32 2FD5 ABC4 D3DB ACCF  D1AA 2807 936F 984D C5A6

* remotes/ehabkost/tags/machine-pull-request:
  vnc: Wrap vnc initialization code with CONFIG_VNC
  qdev: Use GList for global properties

Signed-off-by: Peter Maydell <address@hidden>


Compare: https://github.com/qemu/qemu/compare/d121fcdf4520...da838dfc40cb