qemu-commits
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-commits] [qemu/qemu] 1dbfd7: acpi: fix bios linker loadder COMMAND


From: GitHub
Subject: [Qemu-commits] [qemu/qemu] 1dbfd7: acpi: fix bios linker loadder COMMAND_ALLOCATE on ...
Date: Mon, 02 May 2016 04:30:07 -0700

  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: 1dbfd7892b66c757fdf67f346be40233adbad80e
      
https://github.com/qemu/qemu/commit/1dbfd7892b66c757fdf67f346be40233adbad80e
  Author: Igor Mammedov <address@hidden>
  Date:   2016-05-01 (Sun, 01 May 2016)

  Changed paths:
    M hw/acpi/bios-linker-loader.c

  Log Message:
  -----------
  acpi: fix bios linker loadder COMMAND_ALLOCATE on bigendian host

'make check' fails with:

ERROR:tests/bios-tables-test.c:493:load_expected_aml:
   assertion failed: (g_file_test(aml_file, G_FILE_TEST_EXISTS))

since commit:
caf50c7166a6ed96c462ab5db4b495e1234e4cc6
tests: pc: acpi: drop not needed 'expected SSDT' blobs

Assert happens because qemu-system-x86_64 generates
SSDT table and test looks for a corresponding expected
table to compare with.

However there is no expected SSDT blob anymore, since
QEMU souldn't generate one. As it happens BIOS is not
able to read ACPI tables from QEMU and fallbacks to
embeded legacy ACPI codepath, which generates SSDT.
That happens due to wrongly sized endiannes conversion
which makes
 uint8_t BiosLinkerLoaderEntry.alloc.zone
end up with 0 due to truncation of 32 bit integer
which on host is 1 or 2.

Fix it by dropping invalid cpu_to_le32() as uint8_t
doesn't require any conversion.

RHBZ: https://bugzilla.redhat.com/show_bug.cgi?id=1330174

Signed-off-by: Igor Mammedov <address@hidden>
Reviewed-by: Michael S. Tsirkin <address@hidden>
Signed-off-by: Michael S. Tsirkin <address@hidden>
Tested-by: Laurent Vivier <address@hidden>
Reviewed-by: Marcel Apfelbaum <address@hidden>


  Commit: 20b0f5fef66012e12bde32b14eaa64de2b1b9dbe
      
https://github.com/qemu/qemu/commit/20b0f5fef66012e12bde32b14eaa64de2b1b9dbe
  Author: Peter Maydell <address@hidden>
  Date:   2016-05-01 (Sun, 01 May 2016)

  Changed paths:
    M hw/acpi/bios-linker-loader.c

  Log Message:
  -----------
  Merge remote-tracking branch 'remotes/mst/tags/for_upstream' into staging

acpi: last minute fix for 2.6

Minor, obvious fix only affecting BE hosts.

Signed-off-by: Michael S. Tsirkin <address@hidden>

# gpg: Signature made Sun 01 May 2016 13:43:28 BST using RSA key ID D28D5469
# gpg: Good signature from "Michael S. Tsirkin <address@hidden>"
# gpg:                 aka "Michael S. Tsirkin <address@hidden>"

* remotes/mst/tags/for_upstream:
  acpi: fix bios linker loadder COMMAND_ALLOCATE on bigendian host

Signed-off-by: Peter Maydell <address@hidden>


Compare: https://github.com/qemu/qemu/compare/47dac82d8b01...20b0f5fef660

reply via email to

[Prev in Thread] Current Thread [Next in Thread]