[Qemu-commits] [qemu/qemu] f419a6: usb/uhci: move pid check

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: f419a626c76bcb26697883af702862e8623056f9
      
https://github.com/qemu/qemu/commit/f419a626c76bcb26697883af702862e8623056f9
  Author: Gerd Hoffmann <address@hidden>
  Date:   2016-04-25 (Mon, 25 Apr 2016)

  Changed paths:
    M hw/usb/hcd-uhci.c

  Log Message:
  -----------
  usb/uhci: move pid check

commit "5f77e06 usb: add pid check at the first of uhci_handle_td()"
moved the pid verification to the start of the uhci_handle_td function,
to simplify the error handling (we don't have to free stuff which we
didn't allocate in the first place ...).

Problem is now the check fires too often, it raises error IRQs even for
TDs which we are not going to process because they are not set active.

So, lets move down the check a bit, so it is done only for active TDs,
but still before we are going to allocate stuff to process the requested
transfer.

Reported-by: Joe Clifford <address@hidden>
Tested-by: Joe Clifford <address@hidden>
Signed-off-by: Gerd Hoffmann <address@hidden>
Message-id: address@hidden
Signed-off-by: Peter Maydell <address@hidden>