[Qemu-commits] [qemu/qemu] f6b531: qdev-monitor: improve error message when alias dev...

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: f6b5319d412cda360695e2005737f91ca8201af0
      
https://github.com/qemu/qemu/commit/f6b5319d412cda360695e2005737f91ca8201af0
  Author: Sascha Silbe <address@hidden>
  Date:   2016-03-16 (Wed, 16 Mar 2016)

  Changed paths:
    M qdev-monitor.c

  Log Message:
  -----------
  qdev-monitor: improve error message when alias device is unavailable

When trying to instantiate an alias that points to a device class that
doesn't exist, the error message looks like qemu misunderstood the
request:

$ s390x-softmmu/qemu-system-s390x -device virtio-gpu
qemu-system-s390x: -device virtio-gpu: 'virtio-gpu-ccw' is not a valid
device model name

Special-case the error message to make it explicit that alias
expansion is going on:

$ s390x-softmmu/qemu-system-s390x -device virtio-gpu
qemu-system-s390x: -device virtio-gpu: 'virtio-gpu' (alias
'virtio-gpu-ccw') is not a valid device model name

Suggested-By: Cornelia Huck <address@hidden>
Signed-off-by: Sascha Silbe <address@hidden>
Message-Id: <address@hidden>
Reviewed-by: Cornelia Huck <address@hidden>
Reviewed-by: Michael S. Tsirkin <address@hidden>
Signed-off-by: Markus Armbruster <address@hidden>


  Commit: 36e9916811002dc535f0a5cc718d60d6eb902998
      
https://github.com/qemu/qemu/commit/36e9916811002dc535f0a5cc718d60d6eb902998
  Author: Sascha Silbe <address@hidden>
  Date:   2016-03-16 (Wed, 16 Mar 2016)

  Changed paths:
    M qdev-monitor.c

  Log Message:
  -----------
  qdev-monitor: sort alias table by typename

Sort the alias table by typename so it's easier to see which aliases
exist.

Signed-off-by: Sascha Silbe <address@hidden>
Message-Id: <address@hidden>
Reviewed-by: Halil Pasic <address@hidden>
Reviewed-by: Cornelia Huck <address@hidden>
Reviewed-by: Michael S. Tsirkin <address@hidden>
Signed-off-by: Markus Armbruster <address@hidden>


  Commit: 588c36cac7a658758b3e0b60bfd62ebc2e4045c6
      
https://github.com/qemu/qemu/commit/588c36cac7a658758b3e0b60bfd62ebc2e4045c6
  Author: Sascha Silbe <address@hidden>
  Date:   2016-03-16 (Wed, 16 Mar 2016)

  Changed paths:
    M qdev-monitor.c

  Log Message:
  -----------
  qdev-monitor: add missing aliases for virtio device classes

virtio-{blk,balloon,net,serial} are aliases for their actual,
architecture-dependent implementations (*-ccw on s390x, *-pci on other
architectures supporting virtio). This makes it a lot easier to craft
qemu invocations that work on all supported architectures. Complete
the set to cover all existing non-abstract virtio device classes.

For virtio-balloon, only the CCW implementation was missing.

Signed-off-by: Sascha Silbe <address@hidden>
Message-Id: <address@hidden>
Reviewed-by: Cornelia Huck <address@hidden>
Reviewed-by: Michael S. Tsirkin <address@hidden>
Signed-off-by: Markus Armbruster <address@hidden>


  Commit: cad0b273e58842fa9d06f5b53d588fbe5e146852
      
https://github.com/qemu/qemu/commit/cad0b273e58842fa9d06f5b53d588fbe5e146852
  Author: Peter Maydell <address@hidden>
  Date:   2016-03-16 (Wed, 16 Mar 2016)

  Changed paths:
    M qdev-monitor.c

  Log Message:
  -----------
  Merge remote-tracking branch 'remotes/armbru/tags/pull-monitor-2016-03-16' 
into staging

Monitor patches for 2016-03-16

# gpg: Signature made Wed 16 Mar 2016 09:47:23 GMT using RSA key ID EB918653
# gpg: Good signature from "Markus Armbruster <address@hidden>"
# gpg:                 aka "Markus Armbruster <address@hidden>"

* remotes/armbru/tags/pull-monitor-2016-03-16:
  qdev-monitor: add missing aliases for virtio device classes
  qdev-monitor: sort alias table by typename
  qdev-monitor: improve error message when alias device is unavailable

Signed-off-by: Peter Maydell <address@hidden>


Compare: https://github.com/qemu/qemu/compare/f235538e38f4...cad0b273e588