[Qemu-commits] [qemu/qemu] 6411dd: trace: drop trailing empty strings

qemu-commits
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-commits] [qemu/qemu] 6411dd: trace: drop trailing empty strings

From:	GitHub
Subject:	[Qemu-commits] [qemu/qemu] 6411dd: trace: drop trailing empty strings
Date:	Tue, 01 Mar 2016 09:00:07 -0800
  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: 6411dd13349a6430dcefec7b96986ad0b8c6e7ff
      
https://github.com/qemu/qemu/commit/6411dd13349a6430dcefec7b96986ad0b8c6e7ff
  Author: Greg Kurz <address@hidden>
  Date:   2016-03-01 (Tue, 01 Mar 2016)

  Changed paths:
    M trace-events

  Log Message:
  -----------
  trace: drop trailing empty strings

Also fix a typo in the virtio_balloon_handle_output() trace while here.

[The double-quoting was a limitation of the old tracetool.sh script.
The modern tracetool.py script does not require double-quotes at the end
of the line.  See commit cf85cf8e972f3ad79f203be4edb7968d6e052293
("trace: Format strings must begin/end with double quotes").
--Stefan]

Signed-off-by: Greg Kurz <address@hidden>
Reviewed-by: Eric Blake <address@hidden>
Reviewed-by: Markus Armbruster <address@hidden>
Message-id: address@hidden
Signed-off-by: Stefan Hajnoczi <address@hidden>


  Commit: 2c140f5f2c245603c0123956eb6abf20b998b501
      
https://github.com/qemu/qemu/commit/2c140f5f2c245603c0123956eb6abf20b998b501
  Author: Hollis Blanchard <address@hidden>
  Date:   2016-03-01 (Tue, 01 Mar 2016)

  Changed paths:
    M docs/tracing.txt

  Log Message:
  -----------
  trace: docs: "simple" backend does support strings

The simple tracing backend has supported strings for more than three years
(62bab73213ba885426a781eb2741670b9f3cae36).

Signed-off-by: Hollis Blanchard <address@hidden>
Message-id: address@hidden
Signed-off-by: Stefan Hajnoczi <address@hidden>


  Commit: 23d92d68e72503dfb9fa1dba89f02f5488377b6c
      
https://github.com/qemu/qemu/commit/23d92d68e72503dfb9fa1dba89f02f5488377b6c
  Author: Hollis Blanchard <address@hidden>
  Date:   2016-03-01 (Tue, 01 Mar 2016)

  Changed paths:
    M memory.c
    M trace-events

  Log Message:
  -----------
  trace: split subpage MMIOs into their own trace events.

Previously, a single MMIO could trigger the memory_region_ops tracepoint twice:
once on its way into subpage ops, then later on its way into the model's ops.

Also, the fields previously called "addr" are actually offsets into the memory
region. Rename them to "offset" while we're editing the tracepoint definitions.

Signed-off-by: Hollis Blanchard <address@hidden>
Message-id: address@hidden
Signed-off-by: Stefan Hajnoczi <address@hidden>


  Commit: 4779dc1d19f0e3e20d2d4843b988c72b9235bbe0
      
https://github.com/qemu/qemu/commit/4779dc1d19f0e3e20d2d4843b988c72b9235bbe0
  Author: Hollis Blanchard <address@hidden>
  Date:   2016-03-01 (Tue, 01 Mar 2016)

  Changed paths:
    M memory.c
    M trace-events

  Log Message:
  -----------
  trace: use addresses instead of offsets in memory tracepoints

When memory_region_ops tracepoints are enabled, calculate and record the
absolute address being accessed. Otherwise, we only get offsets into the
memory region instead of addresses.

[Fixed "offset" -> "addr" in trace event format strings.
--Stefan]

Signed-off-by: Hollis Blanchard <address@hidden>
Message-id: address@hidden
Signed-off-by: Stefan Hajnoczi <address@hidden>


  Commit: 62cb4145bbc71fcb9754034655a6c7327905efc4
      
https://github.com/qemu/qemu/commit/62cb4145bbc71fcb9754034655a6c7327905efc4
  Author: Denis V. Lunev <address@hidden>
  Date:   2016-03-01 (Tue, 01 Mar 2016)

  Changed paths:
    M vl.c

  Log Message:
  -----------
  vl: fix tracing initialization

we should call trace_init_backends() before trace_init_file() for
CONFIG_TRACE_SIMPLE There is no difference for other cases.

This problem was introduced by the commit
    commit 41fc57e44ed64cd4ab5393d83624afd897dabd4f
    Author: Paolo Bonzini <address@hidden>
    Date:   Thu Jan 7 16:55:24 2016 +0300

    trace: split trace_init_file out of trace_init_backends

'make check' was failed as a result if configured with
  --enable-trace-backends=simple

Spotted by Alex Bennée.

Signed-off-by: Denis V. Lunev <address@hidden>
Reviewed-by: Alex Bennée <address@hidden>
Tested-by: Alex Bennée <address@hidden>
Tested-by: Christian Borntraeger <address@hidden>
Message-id: address@hidden
CC: Alex Bennée <address@hidden>
CC: Paolo Bonzini <address@hidden>
CC: Stefan Hajnoczi <address@hidden>
Signed-off-by: Stefan Hajnoczi <address@hidden>


  Commit: 3596f524d4257ede23f68b7005c4548660db463a
      
https://github.com/qemu/qemu/commit/3596f524d4257ede23f68b7005c4548660db463a
  Author: Lluís Vilanova <address@hidden>
  Date:   2016-03-01 (Tue, 01 Mar 2016)

  Changed paths:
    M scripts/tracetool/__init__.py

  Log Message:
  -----------
  trace: Extend API to manage event arguments

Lets the user manage event arguments as a list, and simplifies argument
concatenation.

Signed-off-by: Lluís Vilanova <address@hidden>
Reviewed-by: Eric Blake <address@hidden>
Message-id: address@hidden
Signed-off-by: Stefan Hajnoczi <address@hidden>


  Commit: 56797b1fbce86b3844cec753100a7260b9132a6e
      
https://github.com/qemu/qemu/commit/56797b1fbce86b3844cec753100a7260b9132a6e
  Author: Lluís Vilanova <address@hidden>
  Date:   2016-03-01 (Tue, 01 Mar 2016)

  Changed paths:
    M scripts/tracetool/__init__.py
    M scripts/tracetool/format/events_h.py
    M scripts/tracetool/format/tcg_h.py

  Log Message:
  -----------
  trace: Remove unnecessary intermediate event copies

The current code forces the use of a chain of ".original" dereferences,
which looks odd.

Signed-off-by: Lluís Vilanova <address@hidden>
Message-id: address@hidden
Signed-off-by: Stefan Hajnoczi <address@hidden>


  Commit: 1bcea73e13b2b059d0cb3301aeaca43e5656ef57
      
https://github.com/qemu/qemu/commit/1bcea73e13b2b059d0cb3301aeaca43e5656ef57
  Author: Lluís Vilanova <address@hidden>
  Date:   2016-03-01 (Tue, 01 Mar 2016)

  Changed paths:
    M target-alpha/translate.c
    M target-arm/translate.c
    M target-arm/translate.h
    M target-cris/translate.c
    M target-i386/translate.c
    M target-lm32/translate.c
    M target-m68k/translate.c
    M target-microblaze/translate.c
    M target-mips/translate.c
    M target-moxie/translate.c
    M target-openrisc/translate.c
    M target-ppc/translate.c
    M target-s390x/translate.c
    M target-sh4/translate.c
    M target-sparc/translate.c
    M target-tilegx/translate.c
    M target-tricore/translate.c
    M target-unicore32/translate.c
    M target-xtensa/translate.c
    M tcg/tcg.h

  Log Message:
  -----------
  tcg: Add type for vCPU pointers

Adds the 'TCGv_env' type for pointers to 'CPUArchState' objects. The
tracing infrastructure later needs to differentiate between regular
pointers and pointers to vCPUs.

Also changes all targets to use the new 'TCGv_env' type instead of the
generic 'TCGv_ptr'. As of now, the change is merely cosmetic ('TCGv_env'
translates into 'TCGv_ptr'), but that could change in the future to
enforce the difference.

Note that a 'TCGv_env' type (for 'CPUState') is not added, since all
helpers currently receive the architecture-specific
pointer ('CPUArchState').

Signed-off-by: Lluís Vilanova <address@hidden>
Acked-by: Richard Henderson <address@hidden>
Message-id: address@hidden
Signed-off-by: Stefan Hajnoczi <address@hidden>


  Commit: 5d4e1a1081d3f1ec2908ff0eaebe312389971ab4
      
https://github.com/qemu/qemu/commit/5d4e1a1081d3f1ec2908ff0eaebe312389971ab4
  Author: Lluís Vilanova <address@hidden>
  Date:   2016-03-01 (Tue, 01 Mar 2016)

  Changed paths:
    M tcg/tcg-op.h
    M tcg/tcg.h

  Log Message:
  -----------
  tcg: Move definition of type TCGv

The target-dependant type TCGv must be defined in "tcg/tcg.h" before
including the tracing helper wrappers in "tcg/tcg-op.h".

It also makes more sense to define it here, where other TCG types are
defined too.

Signed-off-by: Lluís Vilanova <address@hidden>
Message-id: address@hidden
Signed-off-by: Stefan Hajnoczi <address@hidden>


  Commit: bc9beb47c7822628cf7028ba177b390eabbe88a6
      
https://github.com/qemu/qemu/commit/bc9beb47c7822628cf7028ba177b390eabbe88a6
  Author: Lluís Vilanova <address@hidden>
  Date:   2016-03-01 (Tue, 01 Mar 2016)

  Changed paths:
    M scripts/tracetool/__init__.py

  Log Message:
  -----------
  trace: Add helper function to cast event arguments

Signed-off-by: Lluís Vilanova <address@hidden>
Message-id: address@hidden
Signed-off-by: Stefan Hajnoczi <address@hidden>


  Commit: b23197f9cf2f221a6cc6272d36852f4f70cf9c1b
      
https://github.com/qemu/qemu/commit/b23197f9cf2f221a6cc6272d36852f4f70cf9c1b
  Author: Lluís Vilanova <address@hidden>
  Date:   2016-03-01 (Tue, 01 Mar 2016)

  Changed paths:
    M include/qemu/typedefs.h
    M include/qom/cpu.h
    M stubs/target-get-monitor-def.c

  Log Message:
  -----------
  typedefs: Add CPUState

Signed-off-by: Lluís Vilanova <address@hidden>
Message-id: address@hidden
Signed-off-by: Stefan Hajnoczi <address@hidden>


  Commit: 3d211d9f4dbee7483f092c287ef20d8336100445
      
https://github.com/qemu/qemu/commit/3d211d9f4dbee7483f092c287ef20d8336100445
  Author: Lluís Vilanova <address@hidden>
  Date:   2016-03-01 (Tue, 01 Mar 2016)

  Changed paths:
    M docs/tracing.txt
    M scripts/tracetool/__init__.py
    M scripts/tracetool/format/h.py
    M scripts/tracetool/format/tcg_h.py
    M scripts/tracetool/format/tcg_helper_c.py
    M scripts/tracetool/format/tcg_helper_h.py
    M scripts/tracetool/format/tcg_helper_wrapper_h.py
    M scripts/tracetool/format/ust_events_c.py
    M scripts/tracetool/transform.py
    A scripts/tracetool/vcpu.py
    M trace/control.h

  Log Message:
  -----------
  trace: Add 'vcpu' event property to trace guest vCPU

This property identifies events that trace vCPU-specific information.

It adds a "CPUState*" argument to events with the property, identifying
the vCPU raising the event. TCG translation events also have a
"TCGv_env" implicit argument that is later used as the "CPUState*"
argument at execution time.

Signed-off-by: Lluís Vilanova <address@hidden>
Message-id: address@hidden
Signed-off-by: Stefan Hajnoczi <address@hidden>


  Commit: 4ade0541de712fbf151ac7a2403613a1dbdb25b5
      
https://github.com/qemu/qemu/commit/4ade0541de712fbf151ac7a2403613a1dbdb25b5
  Author: Lluís Vilanova <address@hidden>
  Date:   2016-03-01 (Tue, 01 Mar 2016)

  Changed paths:
    M scripts/tracetool/__init__.py

  Log Message:
  -----------
  trace: Add a proper API to manage auto-generated events from the 'tcg' 
property

Formalizes the existence of the 'event_trans' and 'event_exec' event
attributes, which until now were monkey-patched only when necessary.

Signed-off-by: Lluís Vilanova <address@hidden>
Message-id: address@hidden
Signed-off-by: Stefan Hajnoczi <address@hidden>


  Commit: ed6128ebbdd7cd885d39980659dad4b5c8ae8158
      
https://github.com/qemu/qemu/commit/ed6128ebbdd7cd885d39980659dad4b5c8ae8158
  Author: Peter Maydell <address@hidden>
  Date:   2016-03-01 (Tue, 01 Mar 2016)

  Changed paths:
    M docs/tracing.txt
    M include/qemu/typedefs.h
    M include/qom/cpu.h
    M memory.c
    M scripts/tracetool/__init__.py
    M scripts/tracetool/format/events_h.py
    M scripts/tracetool/format/h.py
    M scripts/tracetool/format/tcg_h.py
    M scripts/tracetool/format/tcg_helper_c.py
    M scripts/tracetool/format/tcg_helper_h.py
    M scripts/tracetool/format/tcg_helper_wrapper_h.py
    M scripts/tracetool/format/ust_events_c.py
    M scripts/tracetool/transform.py
    A scripts/tracetool/vcpu.py
    M stubs/target-get-monitor-def.c
    M target-alpha/translate.c
    M target-arm/translate.c
    M target-arm/translate.h
    M target-cris/translate.c
    M target-i386/translate.c
    M target-lm32/translate.c
    M target-m68k/translate.c
    M target-microblaze/translate.c
    M target-mips/translate.c
    M target-moxie/translate.c
    M target-openrisc/translate.c
    M target-ppc/translate.c
    M target-s390x/translate.c
    M target-sh4/translate.c
    M target-sparc/translate.c
    M target-tilegx/translate.c
    M target-tricore/translate.c
    M target-unicore32/translate.c
    M target-xtensa/translate.c
    M tcg/tcg-op.h
    M tcg/tcg.h
    M trace-events
    M trace/control.h
    M vl.c

  Log Message:
  -----------
  Merge remote-tracking branch 'remotes/stefanha/tags/tracing-pull-request' 
into staging

# gpg: Signature made Tue 01 Mar 2016 15:48:04 GMT using RSA key ID 81AB73C8
# gpg: Good signature from "Stefan Hajnoczi <address@hidden>"
# gpg:                 aka "Stefan Hajnoczi <address@hidden>"

* remotes/stefanha/tags/tracing-pull-request:
  trace: Add a proper API to manage auto-generated events from the 'tcg' 
property
  trace: Add 'vcpu' event property to trace guest vCPU
  typedefs: Add CPUState
  trace: Add helper function to cast event arguments
  tcg: Move definition of type TCGv
  tcg: Add type for vCPU pointers
  trace: Remove unnecessary intermediate event copies
  trace: Extend API to manage event arguments
  vl: fix tracing initialization
  trace: use addresses instead of offsets in memory tracepoints
  trace: split subpage MMIOs into their own trace events.
  trace: docs: "simple" backend does support strings
  trace: drop trailing empty strings

Signed-off-by: Peter Maydell <address@hidden>


Compare: https://github.com/qemu/qemu/compare/9c279bec754a...ed6128ebbdd7
[Prev in Thread]
Current Thread
[Next in Thread]
[Qemu-commits] [qemu/qemu] 6411dd: trace: drop trailing empty strings, GitHub <=
Prev by Date: [Qemu-commits] [qemu/qemu] 66fb2d: linux-headers: update against kvm/next
Next by Date: [Qemu-commits] [qemu/qemu] 750cf8: MAINTAINERS: Add an entry for the include/sysemu/r...
Previous by thread: [Qemu-commits] [qemu/qemu] 66fb2d: linux-headers: update against kvm/next
Next by thread: [Qemu-commits] [qemu/qemu] 750cf8: MAINTAINERS: Add an entry for the include/sysemu/r...
Index(es):
- Date
- Thread