qemu-commits
[Top][All Lists]
Advanced
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-commits] [qemu/qemu] 266e77: ide: Prohibit RESET on IDE drives

From: GitHub
Subject: [Qemu-commits] [qemu/qemu] 266e77: ide: Prohibit RESET on IDE drives
Date: Thu, 11 Feb 2016 07:30:03 -0800 
  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: 266e77812ce1630f3f3ff02aadccb151aa01e6f6
      
https://github.com/qemu/qemu/commit/266e77812ce1630f3f3ff02aadccb151aa01e6f6
  Author: John Snow <address@hidden>
  Date:   2016-02-10 (Wed, 10 Feb 2016)

  Changed paths:
    M hw/ide/core.c

  Log Message:
  -----------
  ide: Prohibit RESET on IDE drives

This command is meant for ATAPI devices only, prohibit acknowledging it with
a command aborted response when an IDE device is busy.

Signed-off-by: John Snow <address@hidden>
Reported-by: Kevin Wolf <address@hidden>
Reviewed-by: Stefan Hajnoczi <address@hidden>
Message-id: address@hidden


  Commit: 4590355bb762b6a1bd46968f3b6e85ff319e4141
      
https://github.com/qemu/qemu/commit/4590355bb762b6a1bd46968f3b6e85ff319e4141
  Author: John Snow <address@hidden>
  Date:   2016-02-10 (Wed, 10 Feb 2016)

  Changed paths:
    M hw/ide/core.c

  Log Message:
  -----------
  ide: code motion

Shuffle the reset function upwards.

Signed-off-by: John Snow <address@hidden>
Reported-by: Kevin Wolf <address@hidden>
Reviewed-by: Stefan Hajnoczi <address@hidden>
Message-id: address@hidden


  Commit: 86698a12f7822387720840775b4eabab5f713d7c
      
https://github.com/qemu/qemu/commit/86698a12f7822387720840775b4eabab5f713d7c
  Author: John Snow <address@hidden>
  Date:   2016-02-10 (Wed, 10 Feb 2016)

  Changed paths:
    M hw/ide/core.c
    M hw/ide/internal.h
    M hw/ide/pci.c

  Log Message:
  -----------
  ide: move buffered DMA cancel to core

Buffered DMA cancellation was added to ATAPI devices and implemented
for the BMDMA HBA. Move the code over to common IDE code and allow
it to be used for any HBA.

Signed-off-by: John Snow <address@hidden>
Reported-by: Kevin Wolf <address@hidden>
Reviewed-by: Stefan Hajnoczi <address@hidden>
Message-id: address@hidden


  Commit: 51f7b5b883a2c9cb98ae28f1563b67f4f6d34c90
      
https://github.com/qemu/qemu/commit/51f7b5b883a2c9cb98ae28f1563b67f4f6d34c90
  Author: John Snow <address@hidden>
  Date:   2016-02-10 (Wed, 10 Feb 2016)

  Changed paths:
    M hw/ide/core.c

  Log Message:
  -----------
  ide: replace blk_drain_all by blk_drain

Target the drain for just one device.

Signed-off-by: John Snow <address@hidden>
Reported-by: Kevin Wolf <address@hidden>
Reviewed-by: Stefan Hajnoczi <address@hidden>
Message-id: address@hidden


  Commit: e3044e238302a887cc1a022e358d68b9bdc69573
      
https://github.com/qemu/qemu/commit/e3044e238302a887cc1a022e358d68b9bdc69573
  Author: John Snow <address@hidden>
  Date:   2016-02-10 (Wed, 10 Feb 2016)

  Changed paths:
    M hw/ide/core.c

  Log Message:
  -----------
  ide: Add silent DRQ cancellation

Split apart the ide_transfer_stop function into two versions: one that
interrupts and one that doesn't. The one that doesn't can be used to
halt any PIO transfers that are in the DRQ phase. It will not halt
any PIO transfers that are currently in the process of buffering data
for the guest to read.

Signed-off-by: John Snow <address@hidden>
Reported-by: Kevin Wolf <address@hidden>
Reviewed-by: Stefan Hajnoczi <address@hidden>
[Renamed 'etf' to 'end_transfer_func' --js]
Message-id: address@hidden


  Commit: f34ae00d6d22671d8583892fa702f21f3049ef72
      
https://github.com/qemu/qemu/commit/f34ae00d6d22671d8583892fa702f21f3049ef72
  Author: John Snow <address@hidden>
  Date:   2016-02-10 (Wed, 10 Feb 2016)

  Changed paths:
    M hw/ide/core.c

  Log Message:
  -----------
  ide: fix device_reset to not ignore pending AIO

Signed-off-by: John Snow <address@hidden>
Reported-by: Kevin Wolf <address@hidden>
Reviewed-by: Stefan Hajnoczi <address@hidden>
Message-id: address@hidden


  Commit: c691320faa6a1749042134716a628e22abb81ed2
      
https://github.com/qemu/qemu/commit/c691320faa6a1749042134716a628e22abb81ed2
  Author: John Snow <address@hidden>
  Date:   2016-02-10 (Wed, 10 Feb 2016)

  Changed paths:
    M hw/block/fdc.c

  Log Message:
  -----------
  fdc: always compile-check debug prints

Coverity noticed that some variables are only used by debug prints, and
called them unused. Always compile the print statements. While we're
here, print to stderr as well.

Bonus: Fix a debug printf I broke in f31937aa8

Signed-off-by: John Snow <address@hidden>
Reviewed-by: Eric Blake <address@hidden>
[Touched up commit message. --js]
Message-id: address@hidden


  Commit: 99b4cb71069f109b79b27bc629fc0cf0886dbc4b
      
https://github.com/qemu/qemu/commit/99b4cb71069f109b79b27bc629fc0cf0886dbc4b
  Author: John Snow <address@hidden>
  Date:   2016-02-10 (Wed, 10 Feb 2016)

  Changed paths:
    M hw/ide/ahci.c

  Log Message:
  -----------
  ahci: Do not unmap NULL addresses

Definitely don't try to unmap a garbage address.

Reported-by: Zuozhi fzz <address@hidden>
Signed-off-by: John Snow <address@hidden>
Message-id: address@hidden


  Commit: f32a2f33c2e765addcca7748f9df692e4131a0e2
      
https://github.com/qemu/qemu/commit/f32a2f33c2e765addcca7748f9df692e4131a0e2
  Author: John Snow <address@hidden>
  Date:   2016-02-10 (Wed, 10 Feb 2016)

  Changed paths:
    M hw/ide/ahci.c

  Log Message:
  -----------
  ahci: handle LIST_ON and FIS_ON in map helpers

Instead of relying on ahci_cond_start_engines to maintain the
engine status indicators itself, have the lower-layer CLB and FIS mapper
helpers do it themselves.

This makes the cond_start routine slightly nicer to read, and makes sure
that the status indicators will always be correct.

Signed-off-by: John Snow <address@hidden>
Message-id: address@hidden


  Commit: f8a6c5f3188b32db5c63e0759d390cb341888497
      
https://github.com/qemu/qemu/commit/f8a6c5f3188b32db5c63e0759d390cb341888497
  Author: John Snow <address@hidden>
  Date:   2016-02-10 (Wed, 10 Feb 2016)

  Changed paths:
    M hw/ide/ahci.c

  Log Message:
  -----------
  ahci: explicitly reject bad engine states on post_load

Currently, we let ahci_cond_start_engines reject weird configurations
where either the DMA (CLB) or FIS engines are said to be started, but
their matching on/off control bit is toggled off.

There should be no way to achieve this, since any time you toggle the
control bit off, the status bit should always follow synchronously.

Preparing for a refactor in cond_start_engines, move the rejection logic
straight up into post_load.

Signed-off-by: John Snow <address@hidden>
Message-id: address@hidden


  Commit: d590474922d37372c56075adb229c86d3aeae967
      
https://github.com/qemu/qemu/commit/d590474922d37372c56075adb229c86d3aeae967
  Author: John Snow <address@hidden>
  Date:   2016-02-10 (Wed, 10 Feb 2016)

  Changed paths:
    M hw/ide/ahci.c

  Log Message:
  -----------
  ahci: prohibit "restarting" the FIS or CLB engines

If the FIS or DMA engines are already started, do not allow them to be
"restarted." As a side-effect of this change, the migration post-load
routine must be modified to cope. If the engines are listed as "on"
in the migrated registers, they must be cleared to allow the startup
routine to see the transition from "off" to "on".

As a second side-effect, the extra argument to ahci_cond_engine_start
is removed in favor of consistent behavior.

Signed-off-by: John Snow <address@hidden>
Message-id: address@hidden


  Commit: f16368459957603b8b3efa83353cc7e13ab6abd3
      
https://github.com/qemu/qemu/commit/f16368459957603b8b3efa83353cc7e13ab6abd3
  Author: Peter Maydell <address@hidden>
  Date:   2016-02-11 (Thu, 11 Feb 2016)

  Changed paths:
    M hw/block/fdc.c
    M hw/ide/ahci.c
    M hw/ide/core.c
    M hw/ide/internal.h
    M hw/ide/pci.c

  Log Message:
  -----------
  Merge remote-tracking branch 'remotes/jnsnow/tags/ide-pull-request' into 
staging

# gpg: Signature made Wed 10 Feb 2016 19:23:29 GMT using RSA key ID AAFC390E
# gpg: Good signature from "John Snow (John Huston) <address@hidden>"

* remotes/jnsnow/tags/ide-pull-request:
  ahci: prohibit "restarting" the FIS or CLB engines
  ahci: explicitly reject bad engine states on post_load
  ahci: handle LIST_ON and FIS_ON in map helpers
  ahci: Do not unmap NULL addresses
  fdc: always compile-check debug prints
  ide: fix device_reset to not ignore pending AIO
  ide: Add silent DRQ cancellation
  ide: replace blk_drain_all by blk_drain
  ide: move buffered DMA cancel to core
  ide: code motion
  ide: Prohibit RESET on IDE drives

Signed-off-by: Peter Maydell <address@hidden>


Compare: https://github.com/qemu/qemu/compare/36a9abd9be2f...f16368459957
reply via email to
[Prev in Thread] Current Thread [Next in Thread]