qemu-commits
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-commits] [qemu/qemu] 2c6484: ivshmem: no need for opaque argument


From: GitHub
Subject: [Qemu-commits] [qemu/qemu] 2c6484: ivshmem: no need for opaque argument
Date: Tue, 02 Feb 2016 06:30:04 -0800

  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: 2c64846972897fc3aec4072f849fae2b00322f8b
      
https://github.com/qemu/qemu/commit/2c64846972897fc3aec4072f849fae2b00322f8b
  Author: Marc-André Lureau <address@hidden>
  Date:   2016-02-02 (Tue, 02 Feb 2016)

  Changed paths:
    M hw/misc/ivshmem.c

  Log Message:
  -----------
  ivshmem: no need for opaque argument

Signed-off-by: Marc-André Lureau <address@hidden>
Reviewed-by: Markus Armbruster <address@hidden>


  Commit: 47213eb1104709bf238c8d16db20aa47d37b1c59
      
https://github.com/qemu/qemu/commit/47213eb1104709bf238c8d16db20aa47d37b1c59
  Author: Marc-André Lureau <address@hidden>
  Date:   2016-02-02 (Tue, 02 Feb 2016)

  Changed paths:
    M hw/misc/ivshmem.c

  Log Message:
  -----------
  ivshmem: remove redundant assignment, fix crash with msi=off

Fix crash when msi=false introduced in 660c97ee (msi_vectors is NULL in
this case)

Signed-off-by: Marc-André Lureau <address@hidden>
Reviewed-by: Markus Armbruster <address@hidden>


  Commit: 1760048a5d21bacf0e4838da2f61b2d8db7d2866
      
https://github.com/qemu/qemu/commit/1760048a5d21bacf0e4838da2f61b2d8db7d2866
  Author: Marc-André Lureau <address@hidden>
  Date:   2016-02-02 (Tue, 02 Feb 2016)

  Changed paths:
    M tests/ivshmem-test.c

  Log Message:
  -----------
  ivshmem-test: leak fixes

Add a cleanup_vm() function to free QPCIDevice & QPCIBus when cleaning
up the IVState.

Signed-off-by: Marc-André Lureau <address@hidden>
Reviewed-by: Markus Armbruster <address@hidden>


  Commit: ea53854a54bc54dddeec0c56572adf53384e960c
      
https://github.com/qemu/qemu/commit/ea53854a54bc54dddeec0c56572adf53384e960c
  Author: Marc-André Lureau <address@hidden>
  Date:   2016-02-02 (Tue, 02 Feb 2016)

  Changed paths:
    M tests/libqos/pci.c

  Log Message:
  -----------
  libqos: remove some leaks

qpci_device_find() returns allocated data, don't leak it.

Signed-off-by: Marc-André Lureau <address@hidden>
Reviewed-by: Markus Armbruster <address@hidden>


  Commit: 00ffc3c166d2100e1fb6b5bd192868d338ee825e
      
https://github.com/qemu/qemu/commit/00ffc3c166d2100e1fb6b5bd192868d338ee825e
  Author: Marc-André Lureau <address@hidden>
  Date:   2016-02-02 (Tue, 02 Feb 2016)

  Changed paths:
    M tests/ivshmem-test.c

  Log Message:
  -----------
  ivshmem-test: test both msi & irq cases

Recent commit 660c97ee introduced a regression in irq case, make
sure this code path is also tested.

Signed-off-by: Marc-André Lureau <address@hidden>
Reviewed-by: Markus Armbruster <address@hidden>


  Commit: fd47bfe5ad423b4b09dc0244bda3b1346fa189ba
      
https://github.com/qemu/qemu/commit/fd47bfe5ad423b4b09dc0244bda3b1346fa189ba
  Author: Marc-André Lureau <address@hidden>
  Date:   2016-02-02 (Tue, 02 Feb 2016)

  Changed paths:
    M hw/misc/ivshmem.c

  Log Message:
  -----------
  ivshmem: generalize ivshmem_setup_interrupts

Call ivshmem_setup_interrupts() with or without MSI, always allocate
msi_vectors that is going to be used in all case in the following patch.

Signed-off-by: Marc-André Lureau <address@hidden>
Reviewed-by: Markus Armbruster <address@hidden>


  Commit: 9940c3236f318949c92099163281d5d23a9fcf4f
      
https://github.com/qemu/qemu/commit/9940c3236f318949c92099163281d5d23a9fcf4f
  Author: Marc-André Lureau <address@hidden>
  Date:   2016-02-02 (Tue, 02 Feb 2016)

  Changed paths:
    M hw/misc/ivshmem.c

  Log Message:
  -----------
  ivshmem: use a single eventfd callback, get rid of CharDriver

Simplify the interrupt handling by having a single callback on irq&msi
cases. Remove usage of CharDriver, replace it with
qemu_set_fd_handler(). Use event_notifier_test_and_clear() to read the
eventfd.

Before this patch, ivshmem writes the first byte received to
s->intrstatus. But ivshmem_device_spec.txt says "The status register is
set to 1 when an interrupt occurs." Fortunately, the byte usually comes
from another ivshmem device, and those always write 1.

After this commit, follows the specification, set to 1 when an interrupt
occurs.

Signed-off-by: Marc-André Lureau <address@hidden>
Acked-by: Markus Armbruster <address@hidden>


  Commit: 6db262557260129883c5aa47d47556f4075a3e5c
      
https://github.com/qemu/qemu/commit/6db262557260129883c5aa47d47556f4075a3e5c
  Author: Marc-André Lureau <address@hidden>
  Date:   2016-02-02 (Tue, 02 Feb 2016)

  Changed paths:
    M include/sysemu/char.h
    M qemu-char.c

  Log Message:
  -----------
  char: remove qemu_chr_open_eventfd

Broken since d0d7708ba29cbc, since the backend is NULL.

And now no longer needed by ivshmem.

Signed-off-by: Marc-André Lureau <address@hidden>
Reviewed-by: Markus Armbruster <address@hidden>


  Commit: 074d1ccb42296f7a83ec10f3344c15be7c21fb75
      
https://github.com/qemu/qemu/commit/074d1ccb42296f7a83ec10f3344c15be7c21fb75
  Author: Peter Maydell <address@hidden>
  Date:   2016-02-02 (Tue, 02 Feb 2016)

  Changed paths:
    M hw/misc/ivshmem.c
    M include/sysemu/char.h
    M qemu-char.c
    M tests/ivshmem-test.c
    M tests/libqos/pci.c

  Log Message:
  -----------
  Merge remote-tracking branch 'remotes/elmarco/tags/ivshmem-pull-request' into 
staging

# gpg: Signature made Tue 02 Feb 2016 12:43:03 GMT using RSA key ID 75969CE5
# gpg: Good signature from "Marc-André Lureau <address@hidden>"
# gpg:                 aka "Marc-André Lureau <address@hidden>"
# gpg: WARNING: This key is not certified with sufficiently trusted signatures!
# gpg:          It is not certain that the signature belongs to the owner.
# Primary key fingerprint: 87A9 BD93 3F87 C606 D276  F62D DAE8 E109 7596 9CE5

* remotes/elmarco/tags/ivshmem-pull-request:
  char: remove qemu_chr_open_eventfd
  ivshmem: use a single eventfd callback, get rid of CharDriver
  ivshmem: generalize ivshmem_setup_interrupts
  ivshmem-test: test both msi & irq cases
  libqos: remove some leaks
  ivshmem-test: leak fixes
  ivshmem: remove redundant assignment, fix crash with msi=off
  ivshmem: no need for opaque argument

Signed-off-by: Peter Maydell <address@hidden>


Compare: https://github.com/qemu/qemu/compare/10ae9d76388e...074d1ccb4229

reply via email to

[Prev in Thread] Current Thread [Next in Thread]