[Qemu-commits] [qemu/qemu] cc75a5: io: fix sign of errno value passed to error report

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: cc75a50c68ccea2068e76fc59e5492899abd3bdb
      
https://github.com/qemu/qemu/commit/cc75a50c68ccea2068e76fc59e5492899abd3bdb
  Author: Daniel P. Berrange <address@hidden>
  Date:   2016-01-19 (Tue, 19 Jan 2016)

  Changed paths:
    M io/channel-socket.c

  Log Message:
  -----------
  io: fix sign of errno value passed to error report

When reporting the number of FDs has been exceeded, pass
EINVAL to error_setg_errno, rather than -EINVAL.

Signed-off-by: Daniel P. Berrange <address@hidden>


  Commit: 0c0a55b229bb6d61408394766bcbb04beecd5fa5
      
https://github.com/qemu/qemu/commit/0c0a55b229bb6d61408394766bcbb04beecd5fa5
  Author: Daniel P. Berrange <address@hidden>
  Date:   2016-01-19 (Tue, 19 Jan 2016)

  Changed paths:
    M io/channel-command.c

  Log Message:
  -----------
  io: increment counter when killing off subcommand

When killing the subcommand, it is intended to first send
SIGTERM, then SIGKILL and only report an error if it still
doesn't die after SIGKILL. The 'step' counter was not
being incremented though, so the code never got past the
SIGTERM stage.

Signed-off-by: Daniel P. Berrange <address@hidden>


  Commit: e155494cf0b876c45c3c68a9ab6c641aac22dfdf
      
https://github.com/qemu/qemu/commit/e155494cf0b876c45c3c68a9ab6c641aac22dfdf
  Author: Daniel P. Berrange <address@hidden>
  Date:   2016-01-20 (Wed, 20 Jan 2016)

  Changed paths:
    M io/channel-command.c

  Log Message:
  -----------
  io: some fixes to handling of /dev/null when running commands

The /dev/null file handle was leaked in a couple of places.
There is also the possibility that both readfd and writefd
point to the same /dev/null file handle, so care must be
taken not to close the same file handle twice.

Reviewed-by: Paolo Bonzini <address@hidden>
Signed-off-by: Daniel P. Berrange <address@hidden>


  Commit: 821791b5055788937ddfa67a183c0ff54129efe4
      
https://github.com/qemu/qemu/commit/821791b5055788937ddfa67a183c0ff54129efe4
  Author: Daniel P. Berrange <address@hidden>
  Date:   2016-01-20 (Wed, 20 Jan 2016)

  Changed paths:
    M include/io/channel-command.h
    M include/io/channel-socket.h
    M include/io/channel-tls.h
    M include/io/channel.h

  Log Message:
  -----------
  io: fix description of @errp parameter initialization

The "Error **errp" parameters must be NULL initialized
not uninitialized.

Signed-off-by: Daniel P. Berrange <address@hidden>


  Commit: ccf1e2dcd6091eea1fc2341c63201aa1a6094978
      
https://github.com/qemu/qemu/commit/ccf1e2dcd6091eea1fc2341c63201aa1a6094978
  Author: Daniel P. Berrange <address@hidden>
  Date:   2016-01-20 (Wed, 20 Jan 2016)

  Changed paths:
    M io/channel-socket.c

  Log Message:
  -----------
  io: use memset instead of { 0 } for initializing array

Some versions of GCC on OS-X complain about CMSG_SPACE
not being constant size, which prevents use of { 0 }

io/channel-socket.c: In function 'qio_channel_socket_writev':
io/channel-socket.c:497:18: error: variable-sized object may not be initialized
     char control[CMSG_SPACE(sizeof(int) * SOCKET_MAX_FDS)] = { 0 };

The compiler is at fault here, but it is nicer to avoid
tickling this compiler bug by using memset instead.

Reviewed-By: John Arbuckle <address@hidden>
Signed-off-by: Daniel P. Berrange <address@hidden>


  Commit: 3ed0b659ca810161f8222769b1f6de7c2aa54d83
      
https://github.com/qemu/qemu/commit/3ed0b659ca810161f8222769b1f6de7c2aa54d83
  Author: Peter Maydell <address@hidden>
  Date:   2016-01-21 (Thu, 21 Jan 2016)

  Changed paths:
    M include/io/channel-command.h
    M include/io/channel-socket.h
    M include/io/channel-tls.h
    M include/io/channel.h
    M io/channel-command.c
    M io/channel-socket.c

  Log Message:
  -----------
  Merge remote-tracking branch 
'remotes/berrange/tags/pull-io-next-2016-01-20-1' into staging

I/O channels fixes 2016/01/20 v1

# gpg: Signature made Wed 20 Jan 2016 11:31:47 GMT using RSA key ID 15104FDF
# gpg: Good signature from "Daniel P. Berrange <address@hidden>"
# gpg:                 aka "Daniel P. Berrange <address@hidden>"

* remotes/berrange/tags/pull-io-next-2016-01-20-1:
  io: use memset instead of { 0 } for initializing array
  io: fix description of @errp parameter initialization
  io: some fixes to handling of /dev/null when running commands
  io: increment counter when killing off subcommand
  io: fix sign of errno value passed to error report

Signed-off-by: Peter Maydell <address@hidden>


Compare: https://github.com/qemu/qemu/compare/a953853ebab4...3ed0b659ca81