[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-commits] [qemu/qemu] 8d780f: error: Document how to accumulate mul
|
From: |
GitHub |
|
Subject: |
[Qemu-commits] [qemu/qemu] 8d780f: error: Document how to accumulate multiple errors |
|
Date: |
Thu, 14 Jan 2016 06:30:05 -0800 |
Branch: refs/heads/master
Home: https://github.com/qemu/qemu
Commit: 8d780f43921feb7fd8d0b58f779a22d1265f2378
https://github.com/qemu/qemu/commit/8d780f43921feb7fd8d0b58f779a22d1265f2378
Author: Markus Armbruster <address@hidden>
Date: 2016-01-13 (Wed, 13 Jan 2016)
Changed paths:
M include/qapi/error.h
Log Message:
-----------
error: Document how to accumulate multiple errors
Suggested-by: Eric Blake <address@hidden>
Signed-off-by: Markus Armbruster <address@hidden>
Reviewed-by: Eric Blake <address@hidden>
Message-Id: <address@hidden>
Commit: 007b06578ab6063d49b6834d95274c37387a1efb
https://github.com/qemu/qemu/commit/007b06578ab6063d49b6834d95274c37387a1efb
Author: Markus Armbruster <address@hidden>
Date: 2016-01-13 (Wed, 13 Jan 2016)
Changed paths:
M hw/arm/exynos4210.c
M hw/arm/highbank.c
M hw/arm/integratorcp.c
M hw/arm/realview.c
M hw/arm/versatilepb.c
M hw/arm/vexpress.c
M hw/arm/xilinx_zynq.c
M hw/char/serial.c
M hw/core/qdev-properties-system.c
M hw/i386/pc.c
M hw/smbios/smbios.c
M numa.c
M vl.c
Log Message:
-----------
Use error_fatal to simplify obvious fatal errors
Done with this Coccinelle semantic patch:
@@
type T;
identifier FUN, RET;
expression list ARGS;
expression ERR, EC;
@@
(
- T RET = FUN(ARGS, &ERR);
+ T RET = FUN(ARGS, &error_fatal);
|
- RET = FUN(ARGS, &ERR);
+ RET = FUN(ARGS, &error_fatal);
|
- FUN(ARGS, &ERR);
+ FUN(ARGS, &error_fatal);
)
- if (ERR != NULL) {
- error_report_err(ERR);
- exit(EC);
- }
This is actually a more elegant version of my initial semantic patch
by courtesy of Eduardo.
It leaves dead Error * variables behind, cleaned up manually.
Cc: address@hidden
Cc: "Michael S. Tsirkin" <address@hidden>
Cc: Eduardo Habkost <address@hidden>
Cc: Paolo Bonzini <address@hidden>
Signed-off-by: Markus Armbruster <address@hidden>
Reviewed-by: Eduardo Habkost <address@hidden>
Commit: 6231a6da9f40c3a33589402c9c57557e3a4f05ad
https://github.com/qemu/qemu/commit/6231a6da9f40c3a33589402c9c57557e3a4f05ad
Author: Markus Armbruster <address@hidden>
Date: 2016-01-13 (Wed, 13 Jan 2016)
Changed paths:
M hw/arm/nseries.c
M hw/block/fdc.c
M hw/block/nand.c
M hw/core/qdev-properties-system.c
M hw/ide/qdev.c
M hw/isa/pc87312.c
M hw/ppc/spapr.c
M include/hw/qdev-properties.h
Log Message:
-----------
hw: Inline the qdev_prop_set_drive_nofail() wrapper
Signed-off-by: Markus Armbruster <address@hidden>
Message-Id: <address@hidden>
Reviewed-by: Peter Maydell <address@hidden>
Commit: c525436e69bb7e74ca96982a40b8ead037186049
https://github.com/qemu/qemu/commit/c525436e69bb7e74ca96982a40b8ead037186049
Author: Markus Armbruster <address@hidden>
Date: 2016-01-13 (Wed, 13 Jan 2016)
Changed paths:
M hw/alpha/dp264.c
M hw/arm/highbank.c
M hw/char/exynos4210_uart.c
M hw/m68k/an5206.c
M hw/ppc/mac_newworld.c
M hw/ppc/mac_oldworld.c
M hw/ppc/prep.c
M hw/unicore32/puv3.c
Log Message:
-----------
hw: Don't use hw_error() for machine initialization errors
Printing CPU registers is not helpful during machine initialization.
Moreover, these are straightforward configuration or "can get
resources" errors, so dumping core isn't appropriate either. Replace
hw_error() by error_report(); exit(1). Matches how we report these
errors in other machine initializations.
Cc: Richard Henderson <address@hidden>
Cc: address@hidden
Cc: address@hidden
Cc: Guan Xuetao <address@hidden>
Signed-off-by: Markus Armbruster <address@hidden>
Reviewed-by: Peter Maydell <address@hidden>
Reviewed-by: Thomas Huth <address@hidden>
Message-Id: <address@hidden>
Reviewed-by: Richard Henderson <address@hidden>
Commit: 84a3a53cf61ef691478bd91afa455c801696053c
https://github.com/qemu/qemu/commit/84a3a53cf61ef691478bd91afa455c801696053c
Author: Markus Armbruster <address@hidden>
Date: 2016-01-13 (Wed, 13 Jan 2016)
Changed paths:
M hw/gpio/omap_gpio.c
M hw/i2c/omap_i2c.c
M hw/intc/omap_intc.c
Log Message:
-----------
omap: Don't use hw_error() in device init() methods
Device init() methods aren't supposed to call hw_error(), they should
report the error and fail cleanly. Do that.
The errors are all device misconfiguration. All callers use
qdev_init_nofail(), so this patch merely converts hw_error() crashes
into &error_abort crashes. Improvement, because now it crashes closer
to where the misconfiguration bug would be, and a few more bad
examples of hw_error() use are gone.
Cc: Peter Maydell <address@hidden>
Signed-off-by: Markus Armbruster <address@hidden>
Reviewed-by: Peter Maydell <address@hidden>
Message-Id: <address@hidden>
Commit: b097e481217ac30eeac675ec16711ef360ccce72
https://github.com/qemu/qemu/commit/b097e481217ac30eeac675ec16711ef360ccce72
Author: Markus Armbruster <address@hidden>
Date: 2016-01-13 (Wed, 13 Jan 2016)
Changed paths:
M hw/timer/arm_mptimer.c
Log Message:
-----------
arm_mptimer: Don't use hw_error() in realize() method
Device realize() methods aren't supposed to call hw_error(), they
should set an error and fail cleanly. Do that.
Cc: Peter Maydell <address@hidden>
Cc: address@hidden
Signed-off-by: Markus Armbruster <address@hidden>
Reviewed-by: Peter Maydell <address@hidden>
Message-Id: <address@hidden>
Commit: 5a8de107e3496855147e823de32ff70cada725d1
https://github.com/qemu/qemu/commit/5a8de107e3496855147e823de32ff70cada725d1
Author: Markus Armbruster <address@hidden>
Date: 2016-01-13 (Wed, 13 Jan 2016)
Changed paths:
M hw/net/etraxfs_eth.c
Log Message:
-----------
etraxfs_eth: Don't use hw_error() in init() method
Device init() methods aren't supposed to call hw_error(), they should
report the error and fail cleanly. Do that.
Cc: "Edgar E. Iglesias" <address@hidden>
Signed-off-by: Markus Armbruster <address@hidden>
Reviewed-by: Edgar E. Iglesias <address@hidden>
Message-Id: <address@hidden>
Commit: 9280eb34deb032d7c86275a92651ae63cc5418d5
https://github.com/qemu/qemu/commit/9280eb34deb032d7c86275a92651ae63cc5418d5
Author: Markus Armbruster <address@hidden>
Date: 2016-01-13 (Wed, 13 Jan 2016)
Changed paths:
M hw/pci-host/prep.c
Log Message:
-----------
raven: Mark use of hw_error() in realize() FIXME
Device realize() methods aren't supposed to call hw_error(), they
should set an error and fail cleanly. Blindly doing that would be
easy enough, but then realize() would fail without undoing its side
effects. Just mark it FIXME for now.
Cc: "Andreas Färber" <address@hidden>
Cc: address@hidden
Signed-off-by: Markus Armbruster <address@hidden>
Reviewed-by: Thomas Huth <address@hidden>
Message-Id: <address@hidden>
Commit: 543202c0ddbcc4ee97d82fe45356e1ab00093f90
https://github.com/qemu/qemu/commit/543202c0ddbcc4ee97d82fe45356e1ab00093f90
Author: Markus Armbruster <address@hidden>
Date: 2016-01-13 (Wed, 13 Jan 2016)
Changed paths:
M qdev-monitor.c
M util/error.c
M util/qemu-option.c
Log Message:
-----------
error: Don't append a newline when printing the error hint
Since commit 50b7b00, we have error_append_hint() to conveniently
accumulate Error member @hint. error_report_err() prints it with a
newline appended. Consequently, users of error_append_hint() need to
know whether theirs is the final line of the hint to decide whether it
needs a newline. Not a nice interface.
Change error_report_err() to print just the hint, and the (still few)
users of error_append_hint() to add the required newline.
Cc: Eric Blake <address@hidden>
Signed-off-by: Markus Armbruster <address@hidden>
Reviewed-by: Eric Blake <address@hidden>
Message-Id: <address@hidden>
Commit: 7b55044f9d96ec518e7ab58bd8a3637b52a35f79
https://github.com/qemu/qemu/commit/7b55044f9d96ec518e7ab58bd8a3637b52a35f79
Author: Markus Armbruster <address@hidden>
Date: 2016-01-13 (Wed, 13 Jan 2016)
Changed paths:
M hw/arm/virt.c
Log Message:
-----------
hw/arm/virt: Fix property "gic-version" error handling
virt_set_gic_version() calls exit(1) when passed an invalid property
value. Property setters are not supposed to do that. Screwed up in
commit b92ad39. Harmless, because the property belongs to a machine.
Set an error object instead.
Cc: Peter Maydell <address@hidden>
Cc: address@hidden
Signed-off-by: Markus Armbruster <address@hidden>
Reviewed-by: Peter Maydell <address@hidden>
Commit: c72fbf98cb243df53b92081dd9daae21c7ea0d46
https://github.com/qemu/qemu/commit/c72fbf98cb243df53b92081dd9daae21c7ea0d46
Author: Markus Armbruster <address@hidden>
Date: 2016-01-13 (Wed, 13 Jan 2016)
Changed paths:
M hw/core/platform-bus.c
Log Message:
-----------
sysbus: Don't use hw_error() in machine_init_done_notifiers
platform_bus_map_irq() and platform_bus_map_mmio() use hw_error() to
fail. They run in machine_init_done_notifiers, via
platform_bus_init_notify() and link_sysbus_device(). Printing CPU
registers is not helpful there.
Replace hw_error() by error_report(); exit(1). If these are
programming errors, it should be replaced by an assertion instead.
While there, observe that both functions always return 0, and
link_sysbus_device() ignores the return value. Change them to void.
Cc: Alexander Graf <address@hidden>
Signed-off-by: Markus Armbruster <address@hidden>
Reviewed-by: Thomas Huth <address@hidden>
Message-Id: <address@hidden>
Commit: 3a80ceadcbfa2bfd65ecfa81e389e93b738aaef0
https://github.com/qemu/qemu/commit/3a80ceadcbfa2bfd65ecfa81e389e93b738aaef0
Author: Markus Armbruster <address@hidden>
Date: 2016-01-13 (Wed, 13 Jan 2016)
Changed paths:
M hw/isa/lpc_ich9.c
M hw/sparc64/sun4u.c
Log Message:
-----------
isa: Trivially convert remaining PCI-ISA bridges to realize()
These are "ICH9-LPC" and "ebus".
Cc: "Michael S. Tsirkin" <address@hidden>
Cc: Mark Cave-Ayland <address@hidden>
Signed-off-by: Markus Armbruster <address@hidden>
Reviewed-by: Marcel Apfelbaum <address@hidden>
Reviewed-by: Michael S. Tsirkin <address@hidden>
Message-Id: <address@hidden>
Commit: d10e54329bbfe6bfacf75eb33caead39eef9f3c8
https://github.com/qemu/qemu/commit/d10e54329bbfe6bfacf75eb33caead39eef9f3c8
Author: Markus Armbruster <address@hidden>
Date: 2016-01-13 (Wed, 13 Jan 2016)
Changed paths:
M hw/alpha/typhoon.c
M hw/i386/pc_piix.c
M hw/isa/i82378.c
M hw/isa/isa-bus.c
M hw/isa/lpc_ich9.c
M hw/isa/piix4.c
M hw/isa/vt82c686.c
M hw/mips/mips_jazz.c
M hw/mips/mips_r4k.c
M hw/pci-host/piix.c
M hw/sparc64/sun4u.c
M include/hw/isa/isa.h
Log Message:
-----------
isa: Clean up error handling around isa_bus_new()
We can have at most one ISA bus. If you try to create another one,
isa_bus_new() complains to stderr and returns null.
isa_bus_new() is called in two contexts, machine's init() and device's
realize() methods. Since complaining to stderr is not proper in the
latter context, convert isa_bus_new() to Error.
Machine's init():
* mips_jazz_init(), called from the init() methods of machines
"magnum" and "pica"
* mips_r4k_init(), the init() method of machine "mips"
* pc_init1() called from the init() methods of non-q35 PC machines
* typhoon_init(), called from clipper_init(), the init() method of
machine "clipper"
These callers always create the first ISA bus, hence isa_bus_new()
can't fail. Simply pass &error_abort.
Device's realize():
* i82378_realize(), of PCI device "i82378"
* ich9_lpc_realize(), of PCI device "ICH9-LPC"
* pci_ebus_realize(), of PCI device "ebus"
* piix3_realize(), of PCI device "pci-piix3", abstract parent of
"PIIX3" and "PIIX3-xen"
* piix4_realize(), of PCI device "PIIX4"
* vt82c686b_realize(), of PCI device "VT82C686B"
Propagate the error. Note that these devices are typically created
only by machine init() methods with qdev_init_nofail() or similar. If
we screwed up and created an ISA bus before that call, we now give up
right away. Before, we'd hobble on, and typically die in
isa_bus_irqs(). Similar if someone finds a way to hot-plug one of
these critters.
Cc: Richard Henderson <address@hidden>
Cc: "Michael S. Tsirkin" <address@hidden>
Cc: "Hervé Poussineau" <address@hidden>
Cc: Aurelien Jarno <address@hidden>
Cc: Mark Cave-Ayland <address@hidden>
Signed-off-by: Markus Armbruster <address@hidden>
Reviewed-by: Marcel Apfelbaum <address@hidden>
Reviewed-by: Hervé Poussineau <address@hidden>
Reviewed-by: Michael S. Tsirkin <address@hidden>
Message-Id: <address@hidden>
Commit: 675463d9b6b2c2b65a713a6d906aeebe9e6750ae
https://github.com/qemu/qemu/commit/675463d9b6b2c2b65a713a6d906aeebe9e6750ae
Author: Markus Armbruster <address@hidden>
Date: 2016-01-13 (Wed, 13 Jan 2016)
Changed paths:
M hw/isa/isa-bus.c
Log Message:
-----------
isa: Clean up inappropriate hw_error()
isa_bus_irqs(), isa_create() and isa_try_create() call hw_error() when
passed a null bus. Use of hw_error() has always been questionable,
because these are used only during machine initialization, and
printing CPU registers isn't useful there.
Since the previous commit, passing a null bus is a programming error.
Drop the hw_error() and simply let it crash.
Cc: Richard Henderson <address@hidden>
Cc: "Michael S. Tsirkin" <address@hidden>
Cc: "Hervé Poussineau" <address@hidden>
Cc: Aurelien Jarno <address@hidden>
Cc: Mark Cave-Ayland <address@hidden>
Signed-off-by: Markus Armbruster <address@hidden>
Reviewed-by: Hervé Poussineau <address@hidden>
Message-Id: <address@hidden>
Reviewed-by: Richard Henderson <address@hidden>
Commit: 7e274652e4e2225298a2735c3dcc74f2f8ba7b07
https://github.com/qemu/qemu/commit/7e274652e4e2225298a2735c3dcc74f2f8ba7b07
Author: Markus Armbruster <address@hidden>
Date: 2016-01-13 (Wed, 13 Jan 2016)
Changed paths:
M audio/audio.c
Log Message:
-----------
audio: Clean up inappropriate and unreachable use of hw_error()
audio_init() should not use hw_error(), because dumping CPU registers
is unhelpful there, and aborting is wrong, because it can be called
called from an audio device's realize() method.
The two uses of hw_error() come from commit 0d9acba:
* When qemu_new_timer() fails. It couldn't fail back then, and it
can't fail now. Drop the unreachable error handling.
* When no_audio_driver can't be initialized. It couldn't fail back
then, and it can't fail now. Replace the error handling by an
assertion.
Cc: Gerd Hoffmann <address@hidden>
Signed-off-by: Markus Armbruster <address@hidden>
Reviewed-by: Gerd Hoffmann <address@hidden>
Commit: acef5c02e54e6fb60f8f41a85772be47e5196e81
https://github.com/qemu/qemu/commit/acef5c02e54e6fb60f8f41a85772be47e5196e81
Author: Markus Armbruster <address@hidden>
Date: 2016-01-13 (Wed, 13 Jan 2016)
Changed paths:
M xen-hvm.c
Log Message:
-----------
xen-hvm: Mark inappropriate error handling FIXME
Cc: Stefano Stabellini <address@hidden>
Cc: address@hidden
Signed-off-by: Markus Armbruster <address@hidden>
Message-Id: <address@hidden>
Commit: 85b01e096088832e68fb862e6277a3f858d69cbe
https://github.com/qemu/qemu/commit/85b01e096088832e68fb862e6277a3f858d69cbe
Author: Markus Armbruster <address@hidden>
Date: 2016-01-13 (Wed, 13 Jan 2016)
Changed paths:
M qemu-nbd.c
Log Message:
-----------
qemu-nbd: Replace BSDism <err.h> by error_report()
Coccinelle semantic patch
@@
expression E;
expression list ARGS;
@@
- errx(E, ARGS);
+ error_report(ARGS);
+ exit(E);
@@
expression E, FMT;
expression list ARGS;
@@
- err(E, FMT, ARGS);
+ error_report(FMT /*": %s"*/, ARGS, strerror(errno));
+ exit(E);
followed by a replace of '"/*": %s"*/' by ' : %s"', because I can't
figure out how to make Coccinelle transform strings.
A few of the error messages touched have trailing newlines. They'll
be stripped later in this series.
Signed-off-by: Markus Armbruster <address@hidden>
Reviewed-by: Eric Blake <address@hidden>
Message-Id: <address@hidden>
Commit: 4fffeb5e197e4e5ca01c8ec386ecd712f3319dcf
https://github.com/qemu/qemu/commit/4fffeb5e197e4e5ca01c8ec386ecd712f3319dcf
Author: Markus Armbruster <address@hidden>
Date: 2016-01-13 (Wed, 13 Jan 2016)
Changed paths:
M block/sheepdog.c
M hw/arm/imx25_pdk.c
M hw/arm/kzm.c
M hw/arm/netduino2.c
M hw/arm/xlnx-ep108.c
M hw/ppc/spapr_drc.c
M qemu-nbd.c
M vl.c
Log Message:
-----------
error: Use error_report_err() where appropriate (again)
Same Coccinelle semantic patch as in commit 565f65d.
We now use the original error whole instead of just its message
obtained with error_get_pretty(). This avoids suppressing its hint
(see commit 50b7b00), but I don't think the errors touched in this
commit can come with hints.
Signed-off-by: Markus Armbruster <address@hidden>
Reviewed-by: Eric Blake <address@hidden>
Message-Id: <address@hidden>
Commit: 193227f9e565803b1167fa01301bdf9f6d294d6a
https://github.com/qemu/qemu/commit/193227f9e565803b1167fa01301bdf9f6d294d6a
Author: Markus Armbruster <address@hidden>
Date: 2016-01-13 (Wed, 13 Jan 2016)
Changed paths:
M hmp.c
M hw/s390x/s390-skeys.c
M migration/savevm.c
M monitor.c
Log Message:
-----------
error: Use error_report_err() instead of monitor_printf()
Both error_report_err() and monitor_printf() print to the same
destination when monitor_printf() is used correctly, i.e. within an
HMP monitor. Elsewhere, monitor_printf() does nothing, while
error_report_err() reports to stderr.
Most changed functions are HMP command handlers. These should only
run within an HMP monitor. The one exception is bdrv_password_cb(),
which should also only run within an HMP monitor.
Four command handlers prefix the error message with the command name:
balloon, migrate_set_capability, migrate_set_parameter, migrate.
Pointless, drop.
Unlike monitor_printf(), error_report_err() uses the error whole
instead of just its message obtained with error_get_pretty(). This
avoids suppressing its hint (see commit 50b7b00). Example:
(qemu) device_add ivshmem,id=666
Parameter 'id' expects an identifier
Identifiers consist of letters, digits, '-', '.', '_', starting with a
letter.
Try "help device_add" for more information
The "Identifiers consist of..." line is new with this patch.
Coccinelle semantic patch:
@@
expression M, E;
@@
- monitor_printf(M, "%s\n", error_get_pretty(E));
- error_free(E);
+ error_report_err(E);
@r1@
expression M, E;
format F;
position p;
@@
- monitor_printf(M, "address@hidden@\n", error_get_pretty(E));@p
- error_free(E);
+ error_report_err(E);
@script:python@
p << r1.p;
@@
print "%s:%s:%s: prefix dropped" % (p[0].file, p[0].line, p[0].column)
Signed-off-by: Markus Armbruster <address@hidden>
Reviewed-by: Eric Blake <address@hidden>
Message-Id: <address@hidden>
Commit: 782886719822c956e800dfb9c0665e2b301cb1fb
https://github.com/qemu/qemu/commit/782886719822c956e800dfb9c0665e2b301cb1fb
Author: Markus Armbruster <address@hidden>
Date: 2016-01-13 (Wed, 13 Jan 2016)
Changed paths:
M contrib/ivshmem-server/main.c
M qdev-monitor.c
M qemu-nbd.c
Log Message:
-----------
error: Use error_report_err() instead of ad hoc prints
Unlike ad hoc prints, error_report_err() uses the error whole instead
of just its message obtained with error_get_pretty(). This avoids
suppressing its hint (see commit 50b7b00). Example:
$ bld/ivshmem-server -l 42@
Parameter 'shm_size' expects a size
You may use k, M, G or T suffixes for kilobytes, megabytes, gigabytes and
terabytes.
The last line is new with this patch.
While there, drop a "cannot parse shm size: " message prefix; it's
redundant, because the error message proper is always of the form
"Parameter 'shm_size' expects ...".
Signed-off-by: Markus Armbruster <address@hidden>
Reviewed-by: Eric Blake <address@hidden>
Message-Id: <address@hidden>
Commit: f4d0064afcff4c38b379800674938cde8f069dcd
https://github.com/qemu/qemu/commit/f4d0064afcff4c38b379800674938cde8f069dcd
Author: Markus Armbruster <address@hidden>
Date: 2016-01-13 (Wed, 13 Jan 2016)
Changed paths:
M include/qapi/error.h
M util/error.c
M util/qemu-error.c
Log Message:
-----------
error: Improve documentation
While there, tighten error_append_hint()'s assertion.
Signed-off-by: Markus Armbruster <address@hidden>
Message-Id: <address@hidden>
Reviewed-by: Eric Blake <address@hidden>
Commit: cd5c2dac2e6e60b4f7048d932530cec9d3fdc5da
https://github.com/qemu/qemu/commit/cd5c2dac2e6e60b4f7048d932530cec9d3fdc5da
Author: Markus Armbruster <address@hidden>
Date: 2016-01-13 (Wed, 13 Jan 2016)
Changed paths:
M block.c
Log Message:
-----------
block: Clean up "Could not create temporary overlay" error message
bdrv_create() sets an error and returns -errno on failure. When the
latter is interesting, the error is created with error_setg_errno().
bdrv_append_temp_snapshot() uses the error's message to create a new
one with error_setg_errno(). This adds a strerror() that is either
uninteresting or duplicate. Use error_setg() instead.
Signed-off-by: Markus Armbruster <address@hidden>
Reviewed-by: Eric Blake <address@hidden>
Message-Id: <address@hidden>
Commit: a4699e55f596e552c9b45028a0e831c3438f768d
https://github.com/qemu/qemu/commit/a4699e55f596e552c9b45028a0e831c3438f768d
Author: Markus Armbruster <address@hidden>
Date: 2016-01-13 (Wed, 13 Jan 2016)
Changed paths:
M qemu-nbd.c
Log Message:
-----------
qemu-nbd: Clean up "Failed to load snapshot" error message
bdrv_snapshot_load_tmp() sets an error and returns -errno on failure.
We report both even though the error message is self-contained. Drop
the redundant strerror().
While there: setting errno right before exit() is pointless, so drop
that, too.
Signed-off-by: Markus Armbruster <address@hidden>
Reviewed-by: Eric Blake <address@hidden>
Message-Id: <address@hidden>
Commit: 73eaa04777001e6d68181910ed36729528f77d74
https://github.com/qemu/qemu/commit/73eaa04777001e6d68181910ed36729528f77d74
Author: Markus Armbruster <address@hidden>
Date: 2016-01-13 (Wed, 13 Jan 2016)
Changed paths:
M tests/test-throttle.c
Log Message:
-----------
test-throttle: Simplify qemu_init_main_loop() error handling
The code looks like it tries to check for both qemu_init_main_loop()
and qemu_get_aio_context() failure in one conditional. In fact,
qemu_get_aio_context() can fail only after qemu_init_main_loop()
failed.
Simplify accordingly: check for qemu_init_main_loop() error directly,
without bothering to improve its error message. Call
qemu_get_aio_context() only when qemu_get_aio_context() succeeded. It
can't fail then, so no need to check.
Signed-off-by: Markus Armbruster <address@hidden>
Reviewed-by: Eric Blake <address@hidden>
Message-Id: <address@hidden>
Commit: 8277d2aa58fe4f8f3ee394ea647ea652faf822a4
https://github.com/qemu/qemu/commit/8277d2aa58fe4f8f3ee394ea647ea652faf822a4
Author: Markus Armbruster <address@hidden>
Date: 2016-01-13 (Wed, 13 Jan 2016)
Changed paths:
M include/qapi/error.h
M util/error.c
Log Message:
-----------
error: New error_prepend(), error_reportf_err()
Instead of simply propagating an error verbatim, we sometimes want to
add to its message, like this:
frobnicate(arg, &err);
error_setg(errp, "Can't frobnicate %s: %s",
arg, error_get_pretty(err));
error_free(err);
This is suboptimal, because it loses err's hint (if any). Moreover,
when errp is &error_abort or is subsequently propagated to
&error_abort, the abort message points to the place where we last
added to the error, not to the place where it originated.
To avoid these issues, provide means to add to an error's message in
place:
frobnicate(arg, errp);
error_prepend(errp, "Can't frobnicate %s: ", arg);
Likewise, reporting an error like
frobnicate(arg, &err);
error_report("Can't frobnicate %s: %s", arg, error_get_pretty(err));
can lose err's hint. To avoid:
error_reportf_err(err, "Can't frobnicate %s: ", arg);
The next commits will put these functions to use.
Signed-off-by: Markus Armbruster <address@hidden>
Reviewed-by: Eric Blake <address@hidden>
Message-Id: <address@hidden>
Commit: 8aa802a6b768e811e492c7404a58c52ecfb382ed
https://github.com/qemu/qemu/commit/8aa802a6b768e811e492c7404a58c52ecfb382ed
Author: Markus Armbruster <address@hidden>
Date: 2016-01-13 (Wed, 13 Jan 2016)
Changed paths:
M hw/core/qdev-properties.c
M qemu-img.c
M tests/test-aio.c
M tests/test-thread-pool.c
Log Message:
-----------
error: Don't decorate original error message when adding to it
Prepend the additional information, colon, space to the original
message without enclosing it in parenthesis or quotes, like we do
elsewhere.
Signed-off-by: Markus Armbruster <address@hidden>
Reviewed-by: Eric Blake <address@hidden>
Message-Id: <address@hidden>
Commit: c29b77f955ff2f7b57c1e71e9dc26243eefd0b28
https://github.com/qemu/qemu/commit/c29b77f955ff2f7b57c1e71e9dc26243eefd0b28
Author: Markus Armbruster <address@hidden>
Date: 2016-01-13 (Wed, 13 Jan 2016)
Changed paths:
M arch_init.c
M block/sheepdog.c
M blockdev.c
M hw/arm/cubieboard.c
M hw/arm/digic_boards.c
M hw/core/qdev-properties.c
M hw/core/qdev.c
M hw/i386/pc.c
M hw/ppc/e500.c
M hw/usb/bus.c
M qemu-img.c
M qemu-nbd.c
M replay/replay.c
M tests/test-aio.c
M tests/test-thread-pool.c
M ui/vnc.c
M vl.c
Log Message:
-----------
error: Use error_reportf_err() where it makes obvious sense
Done with this Coccinelle semantic patch
@@
expression FMT, E, S;
expression list ARGS;
@@
- error_report(FMT, ARGS, error_get_pretty(E));
+ error_reportf_err(E, FMT/*@@@*/, ARGS);
(
- error_free(E);
|
exit(S);
|
abort();
)
followed by a replace of '%s"/*@@@*/' by '"' and some line rewrapping,
because I can't figure out how to make Coccinelle transform strings.
We now use the error whole instead of just its message obtained with
error_get_pretty(). This avoids suppressing its hint (see commit
50b7b00), but I can't see how the errors touched in this commit could
come with hints.
Signed-off-by: Markus Armbruster <address@hidden>
Message-Id: <address@hidden>
Reviewed-by: Eric Blake <address@hidden>
Commit: e43bfd9c876676e884b561eca009a571992a4b76
https://github.com/qemu/qemu/commit/e43bfd9c876676e884b561eca009a571992a4b76
Author: Markus Armbruster <address@hidden>
Date: 2016-01-13 (Wed, 13 Jan 2016)
Changed paths:
M block.c
M block/qcow2.c
M block/qed.c
M hw/block/dataplane/virtio-blk.c
M hw/scsi/vhost-scsi.c
M hw/usb/bus.c
Log Message:
-----------
error: Use error_prepend() where it makes obvious sense
Done with this Coccinelle semantic patch
@@
expression FMT, E1, E2;
expression list ARGS;
@@
- error_setg(E1, FMT, ARGS, error_get_pretty(E2));
+ error_propagate(E1, E2);/*###*/
+ error_prepend(E1, FMT/*@@@*/, ARGS);
followed by manual cleanup, first because I can't figure out how to
make Coccinelle transform strings, and second to get rid of now
superfluous error_propagate().
We now use or propagate the original error whole instead of just its
message obtained with error_get_pretty(). This avoids suppressing its
hint (see commit 50b7b00), but I can't see how the errors touched in
this commit could come with hints. It also improves the message
printed with &error_abort when we screw up (see commit 1e9b65b).
Signed-off-by: Markus Armbruster <address@hidden>
Reviewed-by: Eric Blake <address@hidden>
Commit: b83baa6025d0bf921f2fc4514df4f60493ea41de
https://github.com/qemu/qemu/commit/b83baa6025d0bf921f2fc4514df4f60493ea41de
Author: Markus Armbruster <address@hidden>
Date: 2016-01-13 (Wed, 13 Jan 2016)
Changed paths:
M hw/ppc/spapr.c
Log Message:
-----------
spapr: Use error_reportf_err()
Not caught by Coccinelle, because we report the error only
conditionally here.
Signed-off-by: Markus Armbruster <address@hidden>
Reviewed-by: Eric Blake <address@hidden>
Message-Id: <address@hidden>
Commit: d410fe145446968055f3807b0d41ae8150eb0926
https://github.com/qemu/qemu/commit/d410fe145446968055f3807b0d41ae8150eb0926
Author: Markus Armbruster <address@hidden>
Date: 2016-01-13 (Wed, 13 Jan 2016)
Changed paths:
M migration/savevm.c
Log Message:
-----------
migration: Use error_reportf_err() instead of monitor_printf()
Both error_reportf_err() and monitor_printf() print to the same
destination when monitor_printf() is used correctly, i.e. within an
HMP monitor. Elsewhere, monitor_printf() does nothing, while
error_reportf_err() reports to stderr.
Both changed functions are HMP command handlers. These should only
run within an HMP monitor.
Unlike monitor_printf(), error_reportf_err() uses the error whole
instead of just its message obtained with error_get_pretty(). This
avoids suppressing its hint (see commit 50b7b00), but I don't think
the errors touched in this commit can come with hints.
Signed-off-by: Markus Armbruster <address@hidden>
Reviewed-by: Eric Blake <address@hidden>
Message-Id: <address@hidden>
Commit: b9884681491fbe8b3fa32d58f35bcc5f725c5258
https://github.com/qemu/qemu/commit/b9884681491fbe8b3fa32d58f35bcc5f725c5258
Author: Markus Armbruster <address@hidden>
Date: 2016-01-13 (Wed, 13 Jan 2016)
Changed paths:
M qemu-io.c
M qemu-nbd.c
M tests/qemu-iotests/059.out
M tests/qemu-iotests/060.out
M tests/qemu-iotests/069.out
M tests/qemu-iotests/070.out
M tests/qemu-iotests/075.out
M tests/qemu-iotests/076.out
M tests/qemu-iotests/078.out
M tests/qemu-iotests/080.out
M tests/qemu-iotests/083.out
M tests/qemu-iotests/088.out
M tests/qemu-iotests/092.out
M tests/qemu-iotests/103.out
M tests/qemu-iotests/114.out
M tests/qemu-iotests/116.out
M tests/qemu-iotests/131.out
Log Message:
-----------
qemu-io qemu-nbd: Use error_report() etc. instead of fprintf()
Just three instances left.
Signed-off-by: Markus Armbruster <address@hidden>
Reviewed-by: Eric Blake <address@hidden>
Message-Id: <address@hidden>
Commit: 9af9e0fed76e91ed42cb6d31ab6c665f7d691c1c
https://github.com/qemu/qemu/commit/9af9e0fed76e91ed42cb6d31ab6c665f7d691c1c
Author: Markus Armbruster <address@hidden>
Date: 2016-01-13 (Wed, 13 Jan 2016)
Changed paths:
M block/vmdk.c
M hw/arm/xlnx-zynqmp.c
M hw/ppc/spapr.c
M hw/s390x/ipl.c
M hw/s390x/s390-skeys-kvm.c
M hw/s390x/s390-skeys.c
M hw/tpm/tpm_tis.c
M migration/ram.c
M migration/savevm.c
M net/vhost-user.c
M qemu-nbd.c
M qga/commands-posix.c
M target-arm/cpu.c
M target-arm/machine.c
Log Message:
-----------
error: Strip trailing '\n' from error string arguments (again)
Commit 6daf194d, be62a2eb and 312fd5f got rid of a bunch, but they
keep coming back. Tracked down with the Coccinelle semantic patch
from commit 312fd5f.
Cc: Fam Zheng <address@hidden>
Cc: Peter Crosthwaite <address@hidden>
Cc: Bharata B Rao <address@hidden>
Cc: Dominik Dingel <address@hidden>
Cc: David Hildenbrand <address@hidden>
Cc: Jason J. Herne <address@hidden>
Cc: Stefan Berger <address@hidden>
Cc: Dr. David Alan Gilbert <address@hidden>
Cc: Changchun Ouyang <address@hidden>
Cc: zhanghailiang <address@hidden>
Cc: Pavel Fedin <address@hidden>
Signed-off-by: Markus Armbruster <address@hidden>
Reviewed-by: Dr. David Alan Gilbert <address@hidden>
Acked-by: Cornelia Huck <address@hidden>
Acked-by: Bharata B Rao <address@hidden>
Acked-by: Fam Zheng <address@hidden>
Signed-off-by: Markus Armbruster <address@hidden>
Reviewed-by: Eric Blake <address@hidden>
Message-Id: <address@hidden>
Commit: e4937694b66d1468aec3cd95e90888f291c3f599
https://github.com/qemu/qemu/commit/e4937694b66d1468aec3cd95e90888f291c3f599
Author: Markus Armbruster <address@hidden>
Date: 2016-01-13 (Wed, 13 Jan 2016)
Changed paths:
M block/vmdk.c
Log Message:
-----------
vmdk: Clean up control flow in vmdk_parse_extents() a bit
Factor out loop stepping to turn a while-loop with goto into a
for-loop with continue.
Cc: Fam Zheng <address@hidden>
Signed-off-by: Markus Armbruster <address@hidden>
Reviewed-by: Eric Blake <address@hidden>
Reviewed-by: Fam Zheng <address@hidden>
Message-Id: <address@hidden>
Commit: d28d737fb9b1f6c2a58821f8a4640adecf99249b
https://github.com/qemu/qemu/commit/d28d737fb9b1f6c2a58821f8a4640adecf99249b
Author: Markus Armbruster <address@hidden>
Date: 2016-01-13 (Wed, 13 Jan 2016)
Changed paths:
M block/vmdk.c
M tests/qemu-iotests/059.out
Log Message:
-----------
vmdk: Clean up "Invalid extent lines" error message
vmdk_parse_extents() reports parse errors like this:
error_setg(errp, "Invalid extent lines:\n%s", p);
where p points to the beginning of the malformed line in the image
descriptor. This results in a multi-line error message
Invalid extent lines:
<first line that doesn't parse>
<remaining text that may or may not parse, if any>
Error messages should not have newlines embedded. Since the remaining
text is not helpful, we can simply report:
Invalid extent line: <first line that doesn't parse>
Cc: Fam Zheng <address@hidden>
Signed-off-by: Markus Armbruster <address@hidden>
Reviewed-by: Eric Blake <address@hidden>
Message-Id: <address@hidden>
Reviewed-by: Fam Zheng <address@hidden>
Commit: c3d2d68ad68d044417bbecaa0ebb0aa0dfb44b5f
https://github.com/qemu/qemu/commit/c3d2d68ad68d044417bbecaa0ebb0aa0dfb44b5f
Author: Markus Armbruster <address@hidden>
Date: 2016-01-13 (Wed, 13 Jan 2016)
Changed paths:
M hw/i386/kvm/pci-assign.c
Log Message:
-----------
pci-assign: Clean up "Failed to assign" error messages
The arguments of error_setg() & friends should yield a short error
string without newlines.
Two places try to append additional help to the error message by
embedding newlines in the error string. That's nice, but let's do it
the right way, with error_append_hint().
Cc: Laszlo Ersek <address@hidden>
Signed-off-by: Markus Armbruster <address@hidden>
Reviewed-by: Eric Blake <address@hidden>
Message-Id: <address@hidden>
Reviewed-by: Laszlo Ersek <address@hidden>
Commit: bf89e87427fb99b994eb0dfb710bb4b45785f733
https://github.com/qemu/qemu/commit/bf89e87427fb99b994eb0dfb710bb4b45785f733
Author: Markus Armbruster <address@hidden>
Date: 2016-01-13 (Wed, 13 Jan 2016)
Changed paths:
M block/vhdx-log.c
M tests/qemu-iotests/070.out
Log Message:
-----------
vhdx: Fix "log that needs to be replayed" error message
The arguments of error_setg_errno() should yield a short error string
without newlines.
Here, we try to append additional help to the error message by
embedding newlines in the error string. That's nice, but it's doesn't
play nicely with the errno part. tests/qemu-iotests/070.out shows the
resulting mess:
can't open device TEST_DIR/iotest-dirtylog-10G-4M.vhdx: VHDX image file
'TEST_DIR/iotest-dirtylog-10G-4M.vhdx' opened read-only, but contains a log
that needs to be replayed. To replay the log, execute:
qemu-img check -r all 'TEST_DIR/iotest-dirtylog-10G-4M.vhdx': Operation
not permitted
Switch to error_setg() and error_append_hint(). Result:
can't open device TEST_DIR/iotest-dirtylog-10G-4M.vhdx: VHDX image file
'TEST_DIR/iotest-dirtylog-10G-4M.vhdx' opened read-only, but contains a log
that needs to be replayed
To replay the log, run:
qemu-img check -r all 'TEST_DIR/iotest-dirtylog-10G-4M.vhdx'
Signed-off-by: Markus Armbruster <address@hidden>
Reviewed-by: Eric Blake <address@hidden>
Message-Id: <address@hidden>
Commit: 433672b0d5cfdd4acbf269e6aef079e162af5bad
https://github.com/qemu/qemu/commit/433672b0d5cfdd4acbf269e6aef079e162af5bad
Author: Markus Armbruster <address@hidden>
Date: 2016-01-13 (Wed, 13 Jan 2016)
Changed paths:
M hw/i386/pc.c
M kvm-all.c
M qemu-nbd.c
Log Message:
-----------
error: Clean up errors with embedded newlines (again)
The arguments of error_report() should yield a short error string
without newlines.
A few places try to print additional help after the error message by
embedding newlines in the error string. That's nice, but let's do it
the right way. Commit 474c213 cleaned up some, but they keep coming
back. Offenders tracked down with the Coccinelle semantic patch from
commit 312fd5f.
Cc: Laszlo Ersek <address@hidden>
Cc: Pavel Fedin <address@hidden>
Signed-off-by: Markus Armbruster <address@hidden>
Reviewed-by: Laszlo Ersek <address@hidden>
Reviewed-by: Eric Blake <address@hidden>
Signed-off-by: Markus Armbruster <address@hidden>
Commit: e6da780d5f8e258f4a97631612d2b841faed4885
https://github.com/qemu/qemu/commit/e6da780d5f8e258f4a97631612d2b841faed4885
Author: Markus Armbruster <address@hidden>
Date: 2016-01-13 (Wed, 13 Jan 2016)
Changed paths:
M hw/s390x/ipl.c
M hw/s390x/sclp.c
Log Message:
-----------
hw/s390x: Rename local variables Error *l_err to just err
Let's follow established naming practice here as well.
Cc: David Hildenbrand <address@hidden>
Signed-off-by: Markus Armbruster <address@hidden>
Acked-by: Cornelia Huck <address@hidden>
Reviewed-by: David Hildenbrand <address@hidden>
Reviewed-by: Eric Blake <address@hidden>
Message-Id: <address@hidden>
Commit: 24da21f265b091dee756398a24d63dd8a2f3d5ab
https://github.com/qemu/qemu/commit/24da21f265b091dee756398a24d63dd8a2f3d5ab
Author: Markus Armbruster <address@hidden>
Date: 2016-01-13 (Wed, 13 Jan 2016)
Changed paths:
M hw/s390x/sclp.c
Log Message:
-----------
s390/sclp: Simplify control flow in sclp_realize()
Suggested-by: David Hildenbrand <address@hidden>
Signed-off-by: Markus Armbruster <address@hidden>
Reviewed-by: David Hildenbrand <address@hidden>
Acked-by: Cornelia Huck <address@hidden>
Reviewed-by: Eric Blake <address@hidden>
Message-Id: <address@hidden>
Commit: 533fdaedeb7f7ae90866312f57249ebbb7e3c97f
https://github.com/qemu/qemu/commit/533fdaedeb7f7ae90866312f57249ebbb7e3c97f
Author: Markus Armbruster <address@hidden>
Date: 2016-01-13 (Wed, 13 Jan 2016)
Changed paths:
M contrib/ivshmem-server/main.c
M hmp.c
M hw/core/nmi.c
M include/qemu/sockets.h
M tests/test-string-output-visitor.c
Log Message:
-----------
error: Consistently name Error * objects err, and not errp
Signed-off-by: Markus Armbruster <address@hidden>
Message-Id: <address@hidden>
Reviewed-by: Eric Blake <address@hidden>
Commit: 5d596c245d675000ddee69e87616d537ef273be5
https://github.com/qemu/qemu/commit/5d596c245d675000ddee69e87616d537ef273be5
Author: Jason J. Herne <address@hidden>
Date: 2016-01-13 (Wed, 13 Jan 2016)
Changed paths:
M scripts/checkpatch.pl
Log Message:
-----------
checkpatch: Detect newlines in error_report and other error functions
We don't want newlines embedded in error messages. This seems to be a common
problem with new code so let's try to catch it with checkpatch.
This will not catch cases where newlines are inserted into the middle of an
existing multi-line statement. But those cases should be rare.
Signed-off-by: Jason J. Herne <address@hidden>
Message-Id: <address@hidden>
[Rephrased "Error function text" to "Error messages", dropped
error_vprintf, error_printf, error_printf from $qemu_error_funcs,
because they may legitimately print newlines]
Signed-off-by: Markus Armbruster <address@hidden>
Commit: 17c8a2197888bac8ec0256b16919b721c76c5e62
https://github.com/qemu/qemu/commit/17c8a2197888bac8ec0256b16919b721c76c5e62
Author: Peter Maydell <address@hidden>
Date: 2016-01-14 (Thu, 14 Jan 2016)
Changed paths:
M arch_init.c
M audio/audio.c
M block.c
M block/qcow2.c
M block/qed.c
M block/sheepdog.c
M block/vhdx-log.c
M block/vmdk.c
M blockdev.c
M contrib/ivshmem-server/main.c
M hmp.c
M hw/alpha/dp264.c
M hw/alpha/typhoon.c
M hw/arm/cubieboard.c
M hw/arm/digic_boards.c
M hw/arm/exynos4210.c
M hw/arm/highbank.c
M hw/arm/imx25_pdk.c
M hw/arm/integratorcp.c
M hw/arm/kzm.c
M hw/arm/netduino2.c
M hw/arm/nseries.c
M hw/arm/realview.c
M hw/arm/versatilepb.c
M hw/arm/vexpress.c
M hw/arm/virt.c
M hw/arm/xilinx_zynq.c
M hw/arm/xlnx-ep108.c
M hw/arm/xlnx-zynqmp.c
M hw/block/dataplane/virtio-blk.c
M hw/block/fdc.c
M hw/block/nand.c
M hw/char/exynos4210_uart.c
M hw/char/serial.c
M hw/core/nmi.c
M hw/core/platform-bus.c
M hw/core/qdev-properties-system.c
M hw/core/qdev-properties.c
M hw/core/qdev.c
M hw/gpio/omap_gpio.c
M hw/i2c/omap_i2c.c
M hw/i386/kvm/pci-assign.c
M hw/i386/pc.c
M hw/i386/pc_piix.c
M hw/ide/qdev.c
M hw/intc/omap_intc.c
M hw/isa/i82378.c
M hw/isa/isa-bus.c
M hw/isa/lpc_ich9.c
M hw/isa/pc87312.c
M hw/isa/piix4.c
M hw/isa/vt82c686.c
M hw/m68k/an5206.c
M hw/mips/mips_jazz.c
M hw/mips/mips_r4k.c
M hw/net/etraxfs_eth.c
M hw/pci-host/piix.c
M hw/pci-host/prep.c
M hw/ppc/e500.c
M hw/ppc/mac_newworld.c
M hw/ppc/mac_oldworld.c
M hw/ppc/prep.c
M hw/ppc/spapr.c
M hw/ppc/spapr_drc.c
M hw/s390x/ipl.c
M hw/s390x/s390-skeys-kvm.c
M hw/s390x/s390-skeys.c
M hw/s390x/sclp.c
M hw/scsi/vhost-scsi.c
M hw/smbios/smbios.c
M hw/sparc64/sun4u.c
M hw/timer/arm_mptimer.c
M hw/tpm/tpm_tis.c
M hw/unicore32/puv3.c
M hw/usb/bus.c
M include/hw/isa/isa.h
M include/hw/qdev-properties.h
M include/qapi/error.h
M include/qemu/sockets.h
M kvm-all.c
M migration/ram.c
M migration/savevm.c
M monitor.c
M net/vhost-user.c
M numa.c
M qdev-monitor.c
M qemu-img.c
M qemu-io.c
M qemu-nbd.c
M qga/commands-posix.c
M replay/replay.c
M scripts/checkpatch.pl
M target-arm/cpu.c
M target-arm/machine.c
M tests/qemu-iotests/059.out
M tests/qemu-iotests/060.out
M tests/qemu-iotests/069.out
M tests/qemu-iotests/070.out
M tests/qemu-iotests/075.out
M tests/qemu-iotests/076.out
M tests/qemu-iotests/078.out
M tests/qemu-iotests/080.out
M tests/qemu-iotests/083.out
M tests/qemu-iotests/088.out
M tests/qemu-iotests/092.out
M tests/qemu-iotests/103.out
M tests/qemu-iotests/114.out
M tests/qemu-iotests/116.out
M tests/qemu-iotests/131.out
M tests/test-aio.c
M tests/test-string-output-visitor.c
M tests/test-thread-pool.c
M tests/test-throttle.c
M ui/vnc.c
M util/error.c
M util/qemu-error.c
M util/qemu-option.c
M vl.c
M xen-hvm.c
Log Message:
-----------
Merge remote-tracking branch 'remotes/armbru/tags/pull-error-2016-01-13' into
staging
Error reporting patches for 2016-01-13
# gpg: Signature made Wed 13 Jan 2016 14:21:48 GMT using RSA key ID EB918653
# gpg: Good signature from "Markus Armbruster <address@hidden>"
# gpg: aka "Markus Armbruster <address@hidden>"
* remotes/armbru/tags/pull-error-2016-01-13: (41 commits)
checkpatch: Detect newlines in error_report and other error functions
error: Consistently name Error * objects err, and not errp
s390/sclp: Simplify control flow in sclp_realize()
hw/s390x: Rename local variables Error *l_err to just err
error: Clean up errors with embedded newlines (again)
vhdx: Fix "log that needs to be replayed" error message
pci-assign: Clean up "Failed to assign" error messages
vmdk: Clean up "Invalid extent lines" error message
vmdk: Clean up control flow in vmdk_parse_extents() a bit
error: Strip trailing '\n' from error string arguments (again)
qemu-io qemu-nbd: Use error_report() etc. instead of fprintf()
migration: Use error_reportf_err() instead of monitor_printf()
spapr: Use error_reportf_err()
error: Use error_prepend() where it makes obvious sense
error: Use error_reportf_err() where it makes obvious sense
error: Don't decorate original error message when adding to it
error: New error_prepend(), error_reportf_err()
test-throttle: Simplify qemu_init_main_loop() error handling
qemu-nbd: Clean up "Failed to load snapshot" error message
block: Clean up "Could not create temporary overlay" error message
...
Signed-off-by: Peter Maydell <address@hidden>
Compare: https://github.com/qemu/qemu/compare/cd0b19a20b80...17c8a2197888
| [Prev in Thread] |
Current Thread |
[Next in Thread] |
- [Qemu-commits] [qemu/qemu] 8d780f: error: Document how to accumulate multiple errors,
GitHub <=