[Qemu-commits] [qemu/qemu] e4d2ed: io: bind to loopback IP addrs in test suite

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: e4d2edc9d0c58de421eb349871e90b67edec0b9c
      
https://github.com/qemu/qemu/commit/e4d2edc9d0c58de421eb349871e90b67edec0b9c
  Author: Daniel P. Berrange <address@hidden>
  Date:   2015-12-22 (Tue, 22 Dec 2015)

  Changed paths:
    M tests/test-io-channel-socket.c

  Log Message:
  -----------
  io: bind to loopback IP addrs in test suite

The test suite currently binds to 0.0.0.0 or ::, which covers
all interfaces of the machine. It is bad practice for test
suite to open publically accessible ports on a machine, so
switch to use loopback addrs 127.0.0.1 or ::1.

Reported-by: Peter Maydell <address@hidden>
Reviewed-by: Eric Blake <address@hidden>
Signed-off-by: Daniel P. Berrange <address@hidden>


  Commit: bead59946a8b54398f4ba3c9c8ecd15eeac78c53
      
https://github.com/qemu/qemu/commit/bead59946a8b54398f4ba3c9c8ecd15eeac78c53
  Author: Daniel P. Berrange <address@hidden>
  Date:   2015-12-22 (Tue, 22 Dec 2015)

  Changed paths:
    M io/channel-socket.c
    M tests/test-io-channel-socket.c

  Log Message:
  -----------
  io: fix setting of QIO_CHANNEL_FEATURE_FD_PASS on server connections

The QIO_CHANNEL_FEATURE_FD_PASS feature flag is set in the
qio_channel_socket_set_fd() method, however, this only deals
with client side connections.

To ensure server side connections also have the feature flag
set, we must set it in qio_channel_socket_accept() too. This
also highlighted a typo fix where the code updated the
sockaddr struct in the wrong object instance.

Reviewed-by: Eric Blake <address@hidden>
Signed-off-by: Daniel P. Berrange <address@hidden>


  Commit: 7b3c618ad0cd0154993b5b5dbd34e0010960585a
      
https://github.com/qemu/qemu/commit/7b3c618ad0cd0154993b5b5dbd34e0010960585a
  Author: Daniel P. Berrange <address@hidden>
  Date:   2015-12-23 (Wed, 23 Dec 2015)

  Changed paths:
    M io/channel-socket.c
    M tests/test-io-channel-socket.c

  Log Message:
  -----------
  io: fix stack allocation when sending of file descriptors

When sending file descriptors over a socket, we have to
allocate a data buffer to hold the FDs in the scmsghdr.
Unfortunately we allocated the buffer on the stack inside
an if () {} block, but called sendmsg() outside the block.
So the stack bytes holding the FDs were liable to be
overwritten with other data. By luck this was not a problem
when sending 1 FD, but if sending 2 or more then it would
fail.

The fix is to simply move the variables outside the nested
'if' block. To keep valgrind quiet we also zero-initialize
the 'control' buffer.

Reviewed-by: Eric Blake <address@hidden>
Signed-off-by: Daniel P. Berrange <address@hidden>


  Commit: e833dfddb47d2e6d91c6612d6cf92fc5f0a057c7
      
https://github.com/qemu/qemu/commit/e833dfddb47d2e6d91c6612d6cf92fc5f0a057c7
  Author: Peter Maydell <address@hidden>
  Date:   2015-12-23 (Wed, 23 Dec 2015)

  Changed paths:
    M io/channel-socket.c
    M tests/test-io-channel-socket.c

  Log Message:
  -----------
  Merge remote-tracking branch 
'remotes/berrange/tags/pull-io-fixes-2015-12-23-1' into staging

Merge misc I/O channel fixes

# gpg: Signature made Wed 23 Dec 2015 10:54:52 GMT using RSA key ID 15104FDF
# gpg: Good signature from "Daniel P. Berrange <address@hidden>"
# gpg:                 aka "Daniel P. Berrange <address@hidden>"

* remotes/berrange/tags/pull-io-fixes-2015-12-23-1:
  io: fix stack allocation when sending of file descriptors
  io: fix setting of QIO_CHANNEL_FEATURE_FD_PASS on server connections
  io: bind to loopback IP addrs in test suite

Signed-off-by: Peter Maydell <address@hidden>


Compare: https://github.com/qemu/qemu/compare/5fbba5607382...e833dfddb47d