qemu-commits
[Top][All Lists]
Advanced
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-commits] [qemu/qemu] 49cffb: virtio-blk: trivial code optimization

From: GitHub
Subject: [Qemu-commits] [qemu/qemu] 49cffb: virtio-blk: trivial code optimization
Date: Tue, 22 Dec 2015 07:00:03 -0800 
  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: 49cffbc6079c27432b4635d5d03ce14a249d86e2
      
https://github.com/qemu/qemu/commit/49cffbc6079c27432b4635d5d03ce14a249d86e2
  Author: Gonglei <address@hidden>
  Date:   2015-12-22 (Tue, 22 Dec 2015)

  Changed paths:
    M hw/block/virtio-blk.c

  Log Message:
  -----------
  virtio-blk: trivial code optimization

1. avoid possible superflous checking
2. make code more robustness

["make code more robustness" refers to avoiding integer
underflows/overflows.
--Stefan]

Signed-off-by: Gonglei <address@hidden>
Message-id: address@hidden
Signed-off-by: Stefan Hajnoczi <address@hidden>


  Commit: bd44feb754bdb1354f9813ca5dfe883f3d058193
      
https://github.com/qemu/qemu/commit/bd44feb754bdb1354f9813ca5dfe883f3d058193
  Author: Stefan Hajnoczi <address@hidden>
  Date:   2015-12-22 (Tue, 22 Dec 2015)

  Changed paths:
    M block/io.c
    M include/block/block_int.h

  Log Message:
  -----------
  block: add BlockLimits.max_iov field

The maximum number of struct iovec elements depends on the
BlockDriverState.  The raw-posix and iSCSI protocols have a maximum of
IOV_MAX but others could have different values.

Cc: Peter Lieven <address@hidden>
Suggested-by: Kevin Wolf <address@hidden>
Signed-off-by: Stefan Hajnoczi <address@hidden>


  Commit: 648296e067e617e140032c0ab329fb89ffb92aaa
      
https://github.com/qemu/qemu/commit/648296e067e617e140032c0ab329fb89ffb92aaa
  Author: Stefan Hajnoczi <address@hidden>
  Date:   2015-12-22 (Tue, 22 Dec 2015)

  Changed paths:
    M block/block-backend.c
    M include/sysemu/block-backend.h

  Log Message:
  -----------
  block-backend: add blk_get_max_iov()

Add a function to query BlockLimits.max_iov.

Signed-off-by: Stefan Hajnoczi <address@hidden>


  Commit: 222565f65c3fba6825912c2561de7831e514ef3c
      
https://github.com/qemu/qemu/commit/222565f65c3fba6825912c2561de7831e514ef3c
  Author: Stefan Hajnoczi <address@hidden>
  Date:   2015-12-22 (Tue, 22 Dec 2015)

  Changed paths:
    M block/io.c
    M hw/block/virtio-blk.c

  Log Message:
  -----------
  block: replace IOV_MAX with BlockLimits.max_iov

Request merging must not result in a huge request that exceeds the
maximum number of iovec elements.  Use BlockLimits.max_iov instead of
hardcoding IOV_MAX.

Signed-off-by: Stefan Hajnoczi <address@hidden>


  Commit: 3515727f31a2377ec94d0adb450cc175f33138f7
      
https://github.com/qemu/qemu/commit/3515727f31a2377ec94d0adb450cc175f33138f7
  Author: Stefan Hajnoczi <address@hidden>
  Date:   2015-12-22 (Tue, 22 Dec 2015)

  Changed paths:
    M block/mirror.c

  Log Message:
  -----------
  block/mirror: replace IOV_MAX with blk_get_max_iov()

Use blk_get_max_iov() instead of hardcoding IOV_MAX, which may not apply
to all BlockDrivers.

Signed-off-by: Stefan Hajnoczi <address@hidden>


  Commit: b4a9e25b7b8f258f0692d273e59e3e20347cdf28
      
https://github.com/qemu/qemu/commit/b4a9e25b7b8f258f0692d273e59e3e20347cdf28
  Author: Vladimir Sementsov-Ogievskiy <address@hidden>
  Date:   2015-12-22 (Tue, 22 Dec 2015)

  Changed paths:
    M MAINTAINERS
    A docs/specs/parallels.txt

  Log Message:
  -----------
  parallels: add format spec

This specifies Parallels image format as implemented in Parallels Cloud
Server 6.10

Signed-off-by: Vladimir Sementsov-Ogievskiy <address@hidden>
Signed-off-by: Denis V. Lunev <address@hidden>
Message-id: address@hidden
CC: Eric Blake <address@hidden>
CC: John Snow <address@hidden>
CC: Stefan Hajnoczi <address@hidden>
Signed-off-by: Stefan Hajnoczi <address@hidden>


  Commit: d6b6913276535bc0bc0d519d94ba0c908d8cfed8
      
https://github.com/qemu/qemu/commit/d6b6913276535bc0bc0d519d94ba0c908d8cfed8
  Author: Yang Wei <address@hidden>
  Date:   2015-12-22 (Tue, 22 Dec 2015)

  Changed paths:
    M scripts/qemugdb/mtree.py

  Log Message:
  -----------
  scripts/gdb: Fix a python exception in mtree.py

The following exception is threw:
Python Exception <class 'NameError'> name 'long' is not defined:
Error occurred in Python command: name 'long' is not defined

Python 2.4+, int()/long() have been unified, so replace long
with int.

Signed-off-by: Yang Wei <address@hidden>
Message-id: address@hidden
Signed-off-by: Stefan Hajnoczi <address@hidden>


  Commit: 6890a695d954f33c8a9c4efd3037fdb707fe28ec
      
https://github.com/qemu/qemu/commit/6890a695d954f33c8a9c4efd3037fdb707fe28ec
  Author: Peter Crosthwaite <address@hidden>
  Date:   2015-12-22 (Tue, 22 Dec 2015)

  Changed paths:
    M hw/sd/sdhci.c

  Log Message:
  -----------
  sd: sdhci: Delete over-zealous power check

This check was conditionalising SD card operation on the card being
powered by the SDHCI host controller. It is however possible
(particularly in embedded systems) for the power control of the SD card
to be managed outside of SDHCI. This can be as trivial as hard-wiring
the SD slot VCC to a constant power-rail.

This means the guest SDHCI can validly opt-out of the SDHCI power
control feature while still using the card. So delete this check to
allow operation of the card with SDHCI power control.

This is needed for at least Xilinx Zynq and Raspberry Pi, and
also makes Freescale i.MX25 work for me. The digilent Zybo board
has a public schematic which shows SD VCC hardwiring:

http://digilentinc.com/Data/Products/ZYBO/ZYBO_sch_VB.3.pdf
bottom of page 3.

Signed-off-by: Peter Crosthwaite <address@hidden>
Reviewed-by: Sai Pavan Boddu <address@hidden>
Signed-off-by: Andrew Baumann <address@hidden>
Message-id: address@hidden
[AB: Add Pi to list of devices fixed in commit message]
Signed-off-by: Andrew Baumann <address@hidden>
Signed-off-by: Stefan Hajnoczi <address@hidden>


  Commit: 62d32ec817f985ce1c38868d279d449c80975ff2
      
https://github.com/qemu/qemu/commit/62d32ec817f985ce1c38868d279d449c80975ff2
  Author: Andrew Baumann <address@hidden>
  Date:   2015-12-22 (Tue, 22 Dec 2015)

  Changed paths:
    M hw/sd/sdhci.c

  Log Message:
  -----------
  sdhci: don't raise a command index error for an unexpected response

This deletes a block of code that raised a command index error if a
command returned response data, but the guest did not set the
appropriate bits in the response register to handle such a response. I
cannot find any documentation that suggests the controller should
behave in this way, the error code doesn't make sense (command index
error is defined for the case where the index in a response does not
match that of the issued command), and in at least one case (CMD23
issued by UEFI on Raspberry Pi 2), actual hardware does not do this.

Signed-off-by: Andrew Baumann <address@hidden>
Reviewed-by: Peter Crosthwaite <address@hidden>
Message-id: address@hidden
Signed-off-by: Stefan Hajnoczi <address@hidden>


  Commit: 723697551a7e926abe7d3c7f2966012b8075143d
      
https://github.com/qemu/qemu/commit/723697551a7e926abe7d3c7f2966012b8075143d
  Author: Andrew Baumann <address@hidden>
  Date:   2015-12-22 (Tue, 22 Dec 2015)

  Changed paths:
    M hw/sd/sdhci.c
    M include/hw/sd/sdhci.h

  Log Message:
  -----------
  sdhci: add optional quirk property to disable card insertion/removal 
interrupts

This is needed for a quirk of the Raspberry Pi (bcm2835/6) MMC
controller, where the card insert bit is documented as unimplemented
(always reads zero, doesn't generate interrupts) but is in fact
observed on hardware as set at power on, but is cleared (and remains
clear) on subsequent controller resets.

Signed-off-by: Andrew Baumann <address@hidden>
Reviewed-by: Peter Crosthwaite <address@hidden>
Message-id: address@hidden
Signed-off-by: Stefan Hajnoczi <address@hidden>


  Commit: 5dc42c186d63b7b338594fc071cf290805dcc5a5
      
https://github.com/qemu/qemu/commit/5dc42c186d63b7b338594fc071cf290805dcc5a5
  Author: Peter Maydell <address@hidden>
  Date:   2015-12-22 (Tue, 22 Dec 2015)

  Changed paths:
    M MAINTAINERS
    M block/block-backend.c
    M block/io.c
    M block/mirror.c
    A docs/specs/parallels.txt
    M hw/block/virtio-blk.c
    M hw/sd/sdhci.c
    M include/block/block_int.h
    M include/hw/sd/sdhci.h
    M include/sysemu/block-backend.h
    M scripts/qemugdb/mtree.py

  Log Message:
  -----------
  Merge remote-tracking branch 'remotes/stefanha/tags/block-pull-request' into 
staging

# gpg: Signature made Tue 22 Dec 2015 08:52:55 GMT using RSA key ID 81AB73C8
# gpg: Good signature from "Stefan Hajnoczi <address@hidden>"
# gpg:                 aka "Stefan Hajnoczi <address@hidden>"

* remotes/stefanha/tags/block-pull-request:
  sdhci: add optional quirk property to disable card insertion/removal 
interrupts
  sdhci: don't raise a command index error for an unexpected response
  sd: sdhci: Delete over-zealous power check
  scripts/gdb: Fix a python exception in mtree.py
  parallels: add format spec
  block/mirror: replace IOV_MAX with blk_get_max_iov()
  block: replace IOV_MAX with BlockLimits.max_iov
  block-backend: add blk_get_max_iov()
  block: add BlockLimits.max_iov field
  virtio-blk: trivial code optimization

Signed-off-by: Peter Maydell <address@hidden>


Compare: https://github.com/qemu/qemu/compare/c595b2188870...5dc42c186d63
reply via email to
[Prev in Thread] Current Thread [Next in Thread]