qemu-commits
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-commits] [qemu/qemu] 2f6f82: numa: Clean up query-memdev error han


From: GitHub
Subject: [Qemu-commits] [qemu/qemu] 2f6f82: numa: Clean up query-memdev error handling
Date: Tue, 22 Dec 2015 06:30:03 -0800

  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: 2f6f826e03e09eb3b65b3a764580d66b857e3a23
      
https://github.com/qemu/qemu/commit/2f6f826e03e09eb3b65b3a764580d66b857e3a23
  Author: Markus Armbruster <address@hidden>
  Date:   2015-12-18 (Fri, 18 Dec 2015)

  Changed paths:
    M numa.c

  Log Message:
  -----------
  numa: Clean up query-memdev error handling

qmp_query_memdev() has two error paths:

* When object_get_objects_root() returns null.  It never does, so
  simply drop the useless error handling.

* When query_memdev() fails.  It leaks err then.  But any failure
  there is actually a programming error.  Switch it to &error_abort,
  and drop the useless error handling.

Messed up in commit 76b5d85 "qmp: add query-memdev".

Signed-off-by: Markus Armbruster <address@hidden>
Reviewed-by: Eduardo Habkost <address@hidden>
Signed-off-by: Eduardo Habkost <address@hidden>


  Commit: c595b21888705dc28f36808e2e87f4c09d1b6a7f
      
https://github.com/qemu/qemu/commit/c595b21888705dc28f36808e2e87f4c09d1b6a7f
  Author: Peter Maydell <address@hidden>
  Date:   2015-12-18 (Fri, 18 Dec 2015)

  Changed paths:
    M numa.c

  Log Message:
  -----------
  Merge remote-tracking branch 'remotes/ehabkost/tags/numa-pull-request' into 
staging

NUMA queue, 2015-12-18

# gpg: Signature made Fri 18 Dec 2015 17:53:48 GMT using RSA key ID 984DC5A6
# gpg: Good signature from "Eduardo Habkost <address@hidden>"

* remotes/ehabkost/tags/numa-pull-request:
  numa: Clean up query-memdev error handling

Signed-off-by: Peter Maydell <address@hidden>


Compare: https://github.com/qemu/qemu/compare/c688084506cf...c595b2188870

reply via email to

[Prev in Thread] Current Thread [Next in Thread]