[Qemu-commits] [qemu/qemu] 04d252: ui: convert VNC server to use QIOChannelSocket

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: 04d2529da27db512dcbd5e99d0e26d333f16efcc
      
https://github.com/qemu/qemu/commit/04d2529da27db512dcbd5e99d0e26d333f16efcc
  Author: Daniel P. Berrange <address@hidden>
  Date:   2015-12-18 (Fri, 18 Dec 2015)

  Changed paths:
    M ui/vnc-auth-sasl.c
    M ui/vnc-auth-vencrypt.c
    M ui/vnc-jobs.c
    M ui/vnc-ws.c
    M ui/vnc-ws.h
    M ui/vnc.c
    M ui/vnc.h

  Log Message:
  -----------
  ui: convert VNC server to use QIOChannelSocket

The minimal first step conversion to use QIOChannelSocket
classes instead of directly using POSIX sockets API. This
will later be extended to also cover the TLS, SASL and
websockets code.

Reviewed-by: Gerd Hoffmann <address@hidden>
Signed-off-by: Daniel P. Berrange <address@hidden>


  Commit: 2cc452281e1746f9c02d3c66633ce9e5bc391cae
      
https://github.com/qemu/qemu/commit/2cc452281e1746f9c02d3c66633ce9e5bc391cae
  Author: Daniel P. Berrange <address@hidden>
  Date:   2015-12-18 (Fri, 18 Dec 2015)

  Changed paths:
    M ui/vnc-auth-vencrypt.c
    M ui/vnc-ws.c
    M ui/vnc.c
    M ui/vnc.h

  Log Message:
  -----------
  ui: convert VNC server to use QIOChannelTLS

Switch VNC server over to using the QIOChannelTLS object for
the TLS session. This removes all remaining VNC specific code
for dealing with TLS handshakes.

Reviewed-by: Gerd Hoffmann <address@hidden>
Signed-off-by: Daniel P. Berrange <address@hidden>


  Commit: d5f042232cca1c3e2d16b49607632fe4c0f86453
      
https://github.com/qemu/qemu/commit/d5f042232cca1c3e2d16b49607632fe4c0f86453
  Author: Daniel P. Berrange <address@hidden>
  Date:   2015-12-18 (Fri, 18 Dec 2015)

  Changed paths:
    M ui/vnc-ws.c
    M ui/vnc-ws.h
    M ui/vnc.c
    M ui/vnc.h

  Log Message:
  -----------
  ui: convert VNC server to use QIOChannelWebsock

Remove custom websock handling code from the VNC server and use
the QIOChannelWebsock class instead.

Reviewed-by: Gerd Hoffmann <address@hidden>
Signed-off-by: Daniel P. Berrange <address@hidden>


  Commit: f9e98e5d7a67367b862941e339a98b8322fa0cea
      
https://github.com/qemu/qemu/commit/f9e98e5d7a67367b862941e339a98b8322fa0cea
  Author: Stefano Stabellini <address@hidden>
  Date:   2015-12-18 (Fri, 18 Dec 2015)

  Changed paths:
    M hw/block/xen_blkif.h

  Log Message:
  -----------
  xen/blkif: Avoid double access to src->nr_segments

src is stored in shared memory and src->nr_segments is dereferenced
twice at the end of the function.  If a compiler decides to compile this
into two separate memory accesses then the size limitation could be
bypassed.

Fix it by removing the double access to src->nr_segments.

This is part of XSA-155.

Signed-off-by: Stefano Stabellini <address@hidden>


  Commit: 7ea11bf376aea4bf8340eb363de9777c7f93e556
      
https://github.com/qemu/qemu/commit/7ea11bf376aea4bf8340eb363de9777c7f93e556
  Author: Stefano Stabellini <address@hidden>
  Date:   2015-12-18 (Fri, 18 Dec 2015)

  Changed paths:
    M hw/display/xenfb.c

  Log Message:
  -----------
  xenfb: avoid reading twice the same fields from the shared page

Reading twice the same field could give the guest an attack of
opportunity. In the case of event->type, gcc could compile the switch
statement into a jump table, effectively ending up reading the type
field multiple times.

This is part of XSA-155.

Signed-off-by: Stefano Stabellini <address@hidden>


  Commit: 6126bc55220f7cde3392ef1fbbffcbc67240d4f0
      
https://github.com/qemu/qemu/commit/6126bc55220f7cde3392ef1fbbffcbc67240d4f0
  Author: Peter Maydell <address@hidden>
  Date:   2015-12-18 (Fri, 18 Dec 2015)

  Changed paths:
    M hw/block/xen_blkif.h
    M hw/display/xenfb.c

  Log Message:
  -----------
  Merge remote-tracking branch 'remotes/sstabellini/tags/xsa155' into staging

XSA-155 fixes

# gpg: Signature made Fri 18 Dec 2015 15:16:18 GMT using RSA key ID 70E1AE90
# gpg: Good signature from "Stefano Stabellini <address@hidden>"

* remotes/sstabellini/tags/xsa155:
  xenfb: avoid reading twice the same fields from the shared page
  xen/blkif: Avoid double access to src->nr_segments

Signed-off-by: Peter Maydell <address@hidden>


  Commit: b06f904f2e37eb2a9ab0a8344faec7e5d609508a
      
https://github.com/qemu/qemu/commit/b06f904f2e37eb2a9ab0a8344faec7e5d609508a
  Author: Peter Maydell <address@hidden>
  Date:   2015-12-18 (Fri, 18 Dec 2015)

  Changed paths:
    M ui/vnc-auth-sasl.c
    M ui/vnc-auth-vencrypt.c
    M ui/vnc-jobs.c
    M ui/vnc-ws.c
    M ui/vnc-ws.h
    M ui/vnc.c
    M ui/vnc.h

  Log Message:
  -----------
  Merge remote-tracking branch 
'remotes/berrange/tags/pull-io-channel-vnc-2015-12-18-1' into staging

Merge VNC conversion to I/O channels

# gpg: Signature made Fri 18 Dec 2015 15:44:30 GMT using RSA key ID 15104FDF
# gpg: Good signature from "Daniel P. Berrange <address@hidden>"
# gpg:                 aka "Daniel P. Berrange <address@hidden>"

* remotes/berrange/tags/pull-io-channel-vnc-2015-12-18-1:
  ui: convert VNC server to use QIOChannelWebsock
  ui: convert VNC server to use QIOChannelTLS
  ui: convert VNC server to use QIOChannelSocket

Signed-off-by: Peter Maydell <address@hidden>


Compare: https://github.com/qemu/qemu/compare/18f49881cf83...b06f904f2e37