qemu-commits
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-commits] [qemu/qemu] 79f217: sdhci: Sanitize "sdhci-pci" propertie


From: GitHub
Subject: [Qemu-commits] [qemu/qemu] 79f217: sdhci: Sanitize "sdhci-pci" properties for future ...
Date: Mon, 07 Dec 2015 10:00:04 -0800

  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: 79f21707898aaeebb070cb7301846562b77e6fbf
      
https://github.com/qemu/qemu/commit/79f21707898aaeebb070cb7301846562b77e6fbf
  Author: Markus Armbruster <address@hidden>
  Date:   2015-12-07 (Mon, 07 Dec 2015)

  Changed paths:
    M hw/sd/sdhci.c
    M include/hw/sd/sdhci.h

  Log Message:
  -----------
  sdhci: Sanitize "sdhci-pci" properties for future qomification

We currently fuse controller and card into a single device model, but
we intend qomify things properly and separate the two.  The properties
that really belong to the card would then have to somehow pass-through
to the card's properties.  To avoid that complication, either mark
them experimental or drop them.

Properties "capareg", "maxcurr" and the usual PCI device properties
belong to the controller.  Property "drive" belongs to the card;
rename it to "x-drive".  Properties "logical_block_size",
"physical_block_size", "min_io_size", "opt_io_size",
"discard_granularity" belong to the card, but have no effect; drop
them.

Signed-off-by: Markus Armbruster <address@hidden>
Reviewed-by: Peter Maydell <address@hidden>
Message-id: address@hidden
Signed-off-by: Peter Maydell <address@hidden>


  Commit: ba306c7a55a2fcdb51c279612f0f8fbd9a24a7ba
      
https://github.com/qemu/qemu/commit/ba306c7a55a2fcdb51c279612f0f8fbd9a24a7ba
  Author: Markus Armbruster <address@hidden>
  Date:   2015-12-07 (Mon, 07 Dec 2015)

  Changed paths:
    M hw/sd/sd.c

  Log Message:
  -----------
  sd: Mark brittle abuse of blk_attach_dev() FIXME

blk_attach_dev() fails here only when we're working for device
"sdhci-pci" (which already attached the backend), and then we don't
want to attach a second time.  If we ever create another failure mode,
we're setting up ourselves to using the same backend from multiple
frontends, which is likely to end in tears.  Can't clean this up this
close to the release, so mark it FIXME.

Signed-off-by: Markus Armbruster <address@hidden>
Reviewed-by: Peter Maydell <address@hidden>
Message-id: address@hidden
Signed-off-by: Peter Maydell <address@hidden>


  Commit: c3626ca7df027dabf0568284360a23faf18f0884
      
https://github.com/qemu/qemu/commit/c3626ca7df027dabf0568284360a23faf18f0884
  Author: Peter Maydell <address@hidden>
  Date:   2015-12-07 (Mon, 07 Dec 2015)

  Changed paths:
    M VERSION

  Log Message:
  -----------
  Update version for v2.5.0-rc3 release

Signed-off-by: Peter Maydell <address@hidden>


Compare: https://github.com/qemu/qemu/compare/a616fb75c23d...c3626ca7df02

reply via email to

[Prev in Thread] Current Thread [Next in Thread]