qemu-commits
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-commits] [qemu/qemu] c75304: spapr_drc: Handle visitor errors prop


From: GitHub
Subject: [Qemu-commits] [qemu/qemu] c75304: spapr_drc: Handle visitor errors properly
Date: Fri, 04 Dec 2015 03:00:05 -0800

  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: c75304a13906e2a91752a12ef90e31ab18467453
      
https://github.com/qemu/qemu/commit/c75304a13906e2a91752a12ef90e31ab18467453
  Author: Markus Armbruster <address@hidden>
  Date:   2015-12-04 (Fri, 04 Dec 2015)

  Changed paths:
    M hw/ppc/spapr_drc.c

  Log Message:
  -----------
  spapr_drc: Handle visitor errors properly

Since prop_get_fdt() is only used with QmpOutputVisitor, errors
shouldn't actually happen, so this is only a latent bug.

Signed-off-by: Markus Armbruster <address@hidden>
Signed-off-by: David Gibson <address@hidden>


  Commit: c401ae8c9cd4e335dca59661f2849e7a26b5eb31
      
https://github.com/qemu/qemu/commit/c401ae8c9cd4e335dca59661f2849e7a26b5eb31
  Author: Markus Armbruster <address@hidden>
  Date:   2015-12-04 (Fri, 04 Dec 2015)

  Changed paths:
    M hw/ppc/spapr_drc.c

  Log Message:
  -----------
  spapr_drc: Make device "spapr-dr-connector" unavailable with -device

It should only be created via spapr_dr_connector_new().  Attempting to
create it with -device crashes.

Signed-off-by: Markus Armbruster <address@hidden>
Signed-off-by: David Gibson <address@hidden>


  Commit: ab8bf1d735133df5b5847bef0b0bea496d614a5a
      
https://github.com/qemu/qemu/commit/ab8bf1d735133df5b5847bef0b0bea496d614a5a
  Author: Markus Armbruster <address@hidden>
  Date:   2015-12-04 (Fri, 04 Dec 2015)

  Changed paths:
    M hw/ppc/spapr_drc.c

  Log Message:
  -----------
  spapr_drc: Change value of property "fdt" from null back to {}

prop_get_fdt() misuses the visitor API: when fdt is null, it doesn't
visit anything.  object_property_get_qobject() happily
object_property_get_qobject().  Amazingly, the latter survives the
misuse.  Turns out we've papered over it long before prop_get_fdt()
existed, in commit 1d10b44.

However, commit 6c2f9a1 changed how we paper over it, and as a side
effect changed qom-get's value from {} to null.  Change it right back
by fixing the visitor misuse.

Signed-off-by: Markus Armbruster <address@hidden>
Signed-off-by: David Gibson <address@hidden>


  Commit: f33d046d233084f908825bc1a4ec79f1796ca803
      
https://github.com/qemu/qemu/commit/f33d046d233084f908825bc1a4ec79f1796ca803
  Author: Peter Maydell <address@hidden>
  Date:   2015-12-04 (Fri, 04 Dec 2015)

  Changed paths:
    M hw/ppc/spapr_drc.c

  Log Message:
  -----------
  Merge remote-tracking branch 'remotes/dgibson/tags/ppc-for-2.5-20151204' into 
staging

ppc patch queue for 2.5 2015-12-04

This contains some last minute QOM behaviour fixes from Markus
Armbruster.

# gpg: Signature made Fri 04 Dec 2015 06:43:54 GMT using RSA key ID 20D9B392
# gpg: Good signature from "David Gibson <address@hidden>"
# gpg:                 aka "David Gibson (Red Hat) <address@hidden>"
# gpg:                 aka "David Gibson (ozlabs.org) <address@hidden>"
# gpg: WARNING: This key is not certified with sufficiently trusted signatures!
# gpg:          It is not certain that the signature belongs to the owner.
# Primary key fingerprint: 75F4 6586 AE61 A66C C44E  87DC 6C38 CACA 20D9 B392

* remotes/dgibson/tags/ppc-for-2.5-20151204:
  spapr_drc: Change value of property "fdt" from null back to {}
  spapr_drc: Make device "spapr-dr-connector" unavailable with -device
  spapr_drc: Handle visitor errors properly

Signed-off-by: Peter Maydell <address@hidden>


Compare: https://github.com/qemu/qemu/compare/4c65fed8bdf9...f33d046d2330

reply via email to

[Prev in Thread] Current Thread [Next in Thread]