[Qemu-commits] [qemu/qemu] 4e39f5: migration: Clean up use of g_poll() in socket_writ...

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: 4e39f57c0010b689ffa15658ff063006b45309db
      
https://github.com/qemu/qemu/commit/4e39f57c0010b689ffa15658ff063006b45309db
  Author: Markus Armbruster <address@hidden>
  Date:   2015-12-03 (Thu, 03 Dec 2015)

  Changed paths:
    M migration/qemu-file-unix.c

  Log Message:
  -----------
  migration: Clean up use of g_poll() in socket_writev_buffer()

socket_writev_buffer() writes in a loop, using g_poll() to block.  If
g_poll() fails, it tries to write more before the file descriptor is
ready.  In theory, this could go into a tight loop.  In practice,
errors other than EINTR are really unlikely, and when they happen,
we're probably screwed anyway, so we can just as well loop.

Clean it up a bit: retry poll on EINTR, keep ignoring other errors.

Signed-off-by: Markus Armbruster <address@hidden>
Reviewed-by: Paolo Bonzini <address@hidden>
Reviewed-by: Juan Quintela <address@hidden>
Signed-off-by: Juan Quintela <address@hidden>


  Commit: a694ee343d13159d214823294bbda08e4bdac685
      
https://github.com/qemu/qemu/commit/a694ee343d13159d214823294bbda08e4bdac685
  Author: Paolo Bonzini <address@hidden>
  Date:   2015-12-03 (Thu, 03 Dec 2015)

  Changed paths:
    M migration/migration.c

  Log Message:
  -----------
  migration: do floating-point division

Dividing integer expressions transferred_bytes and time_spent, and then 
converting
the integer quotient to type double. Any remainder, or fractional part of the
quotient, is ignored.  Fix this.

Signed-off-by: Paolo Bonzini <address@hidden>
Reviewed-by: Juan Quintela <address@hidden>
Signed-off-by: Juan Quintela <address@hidden>


  Commit: eab0ebc7fe3662ebb4348ac763e7aabc7e355566
      
https://github.com/qemu/qemu/commit/eab0ebc7fe3662ebb4348ac763e7aabc7e355566
  Author: Peter Maydell <address@hidden>
  Date:   2015-12-03 (Thu, 03 Dec 2015)

  Changed paths:
    M migration/migration.c
    M migration/qemu-file-unix.c

  Log Message:
  -----------
  Merge remote-tracking branch 'remotes/juanquintela/tags/migration/20151203' 
into staging

migration/next for 20151203

# gpg: Signature made Wed 02 Dec 2015 23:19:10 GMT using RSA key ID 5872D723
# gpg: Good signature from "Juan Quintela <address@hidden>"
# gpg:                 aka "Juan Quintela <address@hidden>"

* remotes/juanquintela/tags/migration/20151203:
  migration: do floating-point division
  migration: Clean up use of g_poll() in socket_writev_buffer()

Signed-off-by: Peter Maydell <address@hidden>


Compare: https://github.com/qemu/qemu/compare/ec1b9aa89d79...eab0ebc7fe36