qemu-commits
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-commits] [qemu/qemu] 1d7414: Assume madvise for (no)hugepage works


From: GitHub
Subject: [Qemu-commits] [qemu/qemu] 1d7414: Assume madvise for (no)hugepage works
Date: Thu, 26 Nov 2015 02:00:04 -0800

  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: 1d7414396f926651c4d7a673eb3a10aca5246d76
      
https://github.com/qemu/qemu/commit/1d7414396f926651c4d7a673eb3a10aca5246d76
  Author: Dr. David Alan Gilbert <address@hidden>
  Date:   2015-11-25 (Wed, 25 Nov 2015)

  Changed paths:
    M migration/postcopy-ram.c

  Log Message:
  -----------
  Assume madvise for (no)hugepage works

madvise() returns EINVAL in the case of many failures, but also
returns it in cases where the host kernel doesn't have THP enabled.
Postcopy only really cares that THP is off before it detects faults,
and turns it back on afterwards; so we're going to have
to assume that if the madvise fails then the host just doesn't do
THP and we can carry on with the postcopy.

Signed-off-by: Dr. David Alan Gilbert <address@hidden>
Tested-by: Jason J. Herne <address@hidden>
Reviewed-by: Juan Quintela <address@hidden>
Reviewed-by: Amit Shah <address@hidden>
Signed-off-by: Juan Quintela <address@hidden>


  Commit: f77dcdbc76dbf9bade9739e85e1013639e535835
      
https://github.com/qemu/qemu/commit/f77dcdbc76dbf9bade9739e85e1013639e535835
  Author: Wen Congyang <address@hidden>
  Date:   2015-11-25 (Wed, 25 Nov 2015)

  Changed paths:
    M migration/block.c

  Log Message:
  -----------
  block-migration: limit the memory usage

If we set migration speed in a very large value, block-migration will try to 
read
all data to the memory. Because
    (block_mig_state.submitted + block_mig_state.read_done) * BLOCK_SIZE
will be overflow, and it will be always less than rate limit.

There is no need to read too many data into memory when the rate limit is very 
large.
So limit the memory usage can fix the overflow problem.

Signed-off-by: Wen Congyang <address@hidden>
Reviewed-by: Juan Quintela <address@hidden>
Reviewed-by: Stefan Hajnoczi <address@hidden>
Signed-off-by: Juan Quintela <address@hidden>


  Commit: c7933a80bc6f3bb79c341f8fc17b4cf76622e2f3
      
https://github.com/qemu/qemu/commit/c7933a80bc6f3bb79c341f8fc17b4cf76622e2f3
  Author: Peter Maydell <address@hidden>
  Date:   2015-11-25 (Wed, 25 Nov 2015)

  Changed paths:
    M migration/block.c
    M migration/postcopy-ram.c

  Log Message:
  -----------
  Merge remote-tracking branch 'remotes/juanquintela/tags/migration/20151125' 
into staging

migration/next for 20151125

# gpg: Signature made Wed 25 Nov 2015 14:28:47 GMT using RSA key ID 5872D723
# gpg: Good signature from "Juan Quintela <address@hidden>"
# gpg:                 aka "Juan Quintela <address@hidden>"

* remotes/juanquintela/tags/migration/20151125:
  block-migration: limit the memory usage
  Assume madvise for (no)hugepage works

Signed-off-by: Peter Maydell <address@hidden>


Compare: https://github.com/qemu/qemu/compare/1a4dab849d5d...c7933a80bc6f

reply via email to

[Prev in Thread] Current Thread [Next in Thread]