qemu-commits
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-commits] [qemu/qemu] f348da: tests: fix cdrom_pio_impl in ide-test


From: GitHub
Subject: [Qemu-commits] [qemu/qemu] f348da: tests: fix cdrom_pio_impl in ide-test
Date: Fri, 20 Nov 2015 10:00:08 -0800

  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: f348daf3d5d2e349519764cd0c3ec3aaca113732
      
https://github.com/qemu/qemu/commit/f348daf3d5d2e349519764cd0c3ec3aaca113732
  Author: Peter Lieven <address@hidden>
  Date:   2015-11-20 (Fri, 20 Nov 2015)

  Changed paths:
    M tests/ide-test.c

  Log Message:
  -----------
  tests: fix cdrom_pio_impl in ide-test

The check for the cleared BSY flag has to be performed
before each data transfer and not just before the
first one.

Commit 5f81724d revealed this glitch as the BSY flag
was not set in ATAPI PIO transfers before.

While at it fix the descriptions and add a comment before
the nested for loop that transfers the data.

Signed-off-by: Peter Lieven <address@hidden>
Message-id: address@hidden
Reviewed-by: Kevin Wolf <address@hidden>
Reviewed-by: John Snow <address@hidden>
Signed-off-by: Peter Maydell <address@hidden>


  Commit: 541abd10a01da56c5f16582cd32d67114ec22a5c
      
https://github.com/qemu/qemu/commit/541abd10a01da56c5f16582cd32d67114ec22a5c
  Author: Peter Maydell <address@hidden>
  Date:   2015-11-20 (Fri, 20 Nov 2015)

  Changed paths:
    M VERSION

  Log Message:
  -----------
  Update version for v2.5.0-rc1 release

Signed-off-by: Peter Maydell <address@hidden>


Compare: https://github.com/qemu/qemu/compare/28c3e6ee72a3...541abd10a01d

reply via email to

[Prev in Thread] Current Thread [Next in Thread]