qemu-commits
[Top][All Lists]
Advanced
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-commits] [qemu/qemu] 84e7b8: Set last_sent_block

From: GitHub
Subject: [Qemu-commits] [qemu/qemu] 84e7b8: Set last_sent_block
Date: Thu, 19 Nov 2015 08:00:04 -0800 
  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: 84e7b80a05c0c44b90533c6cd2f1db5c932ccf77
      
https://github.com/qemu/qemu/commit/84e7b80a05c0c44b90533c6cd2f1db5c932ccf77
  Author: Dr. David Alan Gilbert <address@hidden>
  Date:   2015-11-19 (Thu, 19 Nov 2015)

  Changed paths:
    M migration/ram.c

  Log Message:
  -----------
  Set last_sent_block

In a82d593b61054b3dea43 I accidentally removed the setting of
last_sent_block,  put it back.

Symptoms:
  Multithreaded compression only uses one thread.
  Migration is a bit less efficient since it won't use 'cont' flags.

Signed-off-by: Dr. David Alan Gilbert <address@hidden>
Fixes: a82d593b61054b3dea43
Signed-off-by: Juan Quintela <address@hidden>


  Commit: 95a7788b2faa81ff95675f1e46a3272a612b35de
      
https://github.com/qemu/qemu/commit/95a7788b2faa81ff95675f1e46a3272a612b35de
  Author: Dr. David Alan Gilbert <address@hidden>
  Date:   2015-11-19 (Thu, 19 Nov 2015)

  Changed paths:
    M migration/migration.c

  Log Message:
  -----------
  migration: Dead assignment of current_time

I set current_time before the postcopy test but never use it;
(I think this was from the original version where it was time based).
Spotted by coverity, CID 1339208

Signed-off-by: Dr. David Alan Gilbert <address@hidden>
Signed-off-by: Juan Quintela <address@hidden>


  Commit: 5df5416e639cd75bd85d243af41387c2418fa580
      
https://github.com/qemu/qemu/commit/5df5416e639cd75bd85d243af41387c2418fa580
  Author: Dr. David Alan Gilbert <address@hidden>
  Date:   2015-11-19 (Thu, 19 Nov 2015)

  Changed paths:
    M migration/migration.c

  Log Message:
  -----------
  Unneeded NULL check

The check is unneccesary, we read the value at the start of the
thread, use it, and never change it.  The value is checked to be
non-NULL before thread creation.

Spotted by coverity, CID 1339211

Signed-off-by: Dr. David Alan Gilbert <address@hidden>
Signed-off-by: Juan Quintela <address@hidden>


  Commit: e9ff957ac26e0e11869a3568cfa7423ae33c51e7
      
https://github.com/qemu/qemu/commit/e9ff957ac26e0e11869a3568cfa7423ae33c51e7
  Author: Denis V. Lunev <address@hidden>
  Date:   2015-11-19 (Thu, 19 Nov 2015)

  Changed paths:
    M block/snapshot.c
    M include/block/snapshot.h
    M migration/savevm.c

  Log Message:
  -----------
  snapshot: create helper to test that block drivers supports snapshots

The patch enforces proper locking for this operation.

Signed-off-by: Denis V. Lunev <address@hidden>
Reviewed-by: Greg Kurz <address@hidden>
Reviewed-by: Stefan Hajnoczi <address@hidden>
Reviewed-by: Fam Zheng <address@hidden>
Reviewed-by: Juan Quintela <address@hidden>
CC: Kevin Wolf <address@hidden>
Tested-by: Greg Kurz <address@hidden>
Signed-off-by: Juan Quintela <address@hidden>


  Commit: 25af925fffc29f2e4c05aee10c61c823c4cdf398
      
https://github.com/qemu/qemu/commit/25af925fffc29f2e4c05aee10c61c823c4cdf398
  Author: Denis V. Lunev <address@hidden>
  Date:   2015-11-19 (Thu, 19 Nov 2015)

  Changed paths:
    M block/snapshot.c
    M include/block/snapshot.h

  Log Message:
  -----------
  snapshot: return error code from bdrv_snapshot_delete_by_id_or_name

this will make code better in the next patch

Signed-off-by: Denis V. Lunev <address@hidden>
Reviewed-by: Stefan Hajnoczi <address@hidden>
Reviewed-by: Fam Zheng <address@hidden>
Reviewed-by: Juan Quintela <address@hidden>
CC: Kevin Wolf <address@hidden>
Tested-by: Greg Kurz <address@hidden>
Signed-off-by: Juan Quintela <address@hidden>


  Commit: 9b00ea376d42e543feb12d7ce5435366d01aab1b
      
https://github.com/qemu/qemu/commit/9b00ea376d42e543feb12d7ce5435366d01aab1b
  Author: Denis V. Lunev <address@hidden>
  Date:   2015-11-19 (Thu, 19 Nov 2015)

  Changed paths:
    M block/snapshot.c
    M include/block/snapshot.h
    M migration/savevm.c

  Log Message:
  -----------
  snapshot: create bdrv_all_delete_snapshot helper

to delete snapshots from all loaded block drivers.

The patch also ensures proper locking.

Signed-off-by: Denis V. Lunev <address@hidden>
Reviewed-by: Stefan Hajnoczi <address@hidden>
Reviewed-by: Fam Zheng <address@hidden>
Reviewed-by: Juan Quintela <address@hidden>
CC: Kevin Wolf <address@hidden>
Tested-by: Greg Kurz <address@hidden>
Signed-off-by: Juan Quintela <address@hidden>


  Commit: 4c1cdbaad07d067f3d156687d79014ab44387e2c
      
https://github.com/qemu/qemu/commit/4c1cdbaad07d067f3d156687d79014ab44387e2c
  Author: Denis V. Lunev <address@hidden>
  Date:   2015-11-19 (Thu, 19 Nov 2015)

  Changed paths:
    M block/snapshot.c
    M include/block/snapshot.h
    M migration/savevm.c

  Log Message:
  -----------
  snapshot: create bdrv_all_goto_snapshot helper

to switch to snapshot on all loaded block drivers.

The patch also ensures proper locking.

Signed-off-by: Denis V. Lunev <address@hidden>
Reviewed-by: Greg Kurz <address@hidden>
Reviewed-by: Stefan Hajnoczi <address@hidden>
Reviewed-by: Fam Zheng <address@hidden>
Reviewed-by: Juan Quintela <address@hidden>
CC: Kevin Wolf <address@hidden>
Tested-by: Greg Kurz <address@hidden>
Signed-off-by: Juan Quintela <address@hidden>


  Commit: 849f96e2f71b52444516a0880fd9d12691b63d20
      
https://github.com/qemu/qemu/commit/849f96e2f71b52444516a0880fd9d12691b63d20
  Author: Denis V. Lunev <address@hidden>
  Date:   2015-11-19 (Thu, 19 Nov 2015)

  Changed paths:
    M migration/savevm.c

  Log Message:
  -----------
  migration: factor our snapshottability check in load_vmstate

We should check that all inserted and not read-only images support
snapshotting. This could be made using already invented helper
bdrv_all_can_snapshot().

Signed-off-by: Denis V. Lunev <address@hidden>
Reviewed-by: Juan Quintela <address@hidden>
Reviewed-by: Fam Zheng <address@hidden>
CC: Stefan Hajnoczi <address@hidden>
CC: Kevin Wolf <address@hidden>
Tested-by: Greg Kurz <address@hidden>
Signed-off-by: Juan Quintela <address@hidden>


  Commit: 723ccda1a0eecece8e70dbcdd35a603f6c41a475
      
https://github.com/qemu/qemu/commit/723ccda1a0eecece8e70dbcdd35a603f6c41a475
  Author: Denis V. Lunev <address@hidden>
  Date:   2015-11-19 (Thu, 19 Nov 2015)

  Changed paths:
    M block/snapshot.c
    M include/block/snapshot.h
    M migration/savevm.c

  Log Message:
  -----------
  snapshot: create bdrv_all_find_snapshot helper

to check that snapshot is available for all loaded block drivers.
The check bs != bs1 in hmp_info_snapshots is an optimization. The check
for availability of this snapshot will return always true as the list
of snapshots was collected from that image.

The patch also ensures proper locking.

Signed-off-by: Denis V. Lunev <address@hidden>
Reviewed-by: Fam Zheng <address@hidden>
Reviewed-by: Juan Quintela <address@hidden>
CC: Stefan Hajnoczi <address@hidden>
CC: Kevin Wolf <address@hidden>
Tested-by: Greg Kurz <address@hidden>
Signed-off-by: Juan Quintela <address@hidden>


  Commit: c6258b04f19bc690b576b089f621cb5333c533d7
      
https://github.com/qemu/qemu/commit/c6258b04f19bc690b576b089f621cb5333c533d7
  Author: Denis V. Lunev <address@hidden>
  Date:   2015-11-19 (Thu, 19 Nov 2015)

  Changed paths:
    M migration/savevm.c

  Log Message:
  -----------
  migration: drop find_vmstate_bs check in hmp_delvm

There is no much sense to do the check and write warning.

Signed-off-by: Denis V. Lunev <address@hidden>
Reviewed-by: Stefan Hajnoczi <address@hidden>
Reviewed-by: Fam Zheng <address@hidden>
Reviewed-by: Juan Quintela <address@hidden>
Tested-by: Greg Kurz <address@hidden>
Signed-off-by: Juan Quintela <address@hidden>


  Commit: a9085f9b5583ba7a02b412ba08f929555112c244
      
https://github.com/qemu/qemu/commit/a9085f9b5583ba7a02b412ba08f929555112c244
  Author: Denis V. Lunev <address@hidden>
  Date:   2015-11-19 (Thu, 19 Nov 2015)

  Changed paths:
    M block/snapshot.c
    M include/block/snapshot.h
    M migration/savevm.c

  Log Message:
  -----------
  snapshot: create bdrv_all_create_snapshot helper

to create snapshot for all loaded block drivers.

The patch also ensures proper locking.

Signed-off-by: Denis V. Lunev <address@hidden>
Reviewed-by: Stefan Hajnoczi <address@hidden>
Reviewed-by: Fam Zheng <address@hidden>
Reviewed-by: Juan Quintela <address@hidden>
CC: Kevin Wolf <address@hidden>
Tested-by: Greg Kurz <address@hidden>
Signed-off-by: Juan Quintela <address@hidden>


  Commit: 0b46160521ab72744da94988583a45d4d45e2986
      
https://github.com/qemu/qemu/commit/0b46160521ab72744da94988583a45d4d45e2986
  Author: Denis V. Lunev <address@hidden>
  Date:   2015-11-19 (Thu, 19 Nov 2015)

  Changed paths:
    M migration/savevm.c

  Log Message:
  -----------
  migration: reorder processing in hmp_savevm

State deletion can be performed on running VM which reduces VM downtime
This approach looks a bit more natural.

Signed-off-by: Denis V. Lunev <address@hidden>
Reviewed-by: Stefan Hajnoczi <address@hidden>
Reviewed-by: Fam Zheng <address@hidden>
Reviewed-by: Juan Quintela <address@hidden>
Tested-by: Greg Kurz <address@hidden>
Signed-off-by: Juan Quintela <address@hidden>


  Commit: 7cb14481498e7acd969a76b53be0535cd90f7d53
      
https://github.com/qemu/qemu/commit/7cb14481498e7acd969a76b53be0535cd90f7d53
  Author: Denis V. Lunev <address@hidden>
  Date:   2015-11-19 (Thu, 19 Nov 2015)

  Changed paths:
    M block/snapshot.c
    M include/block/snapshot.h
    M migration/savevm.c

  Log Message:
  -----------
  migration: implement bdrv_all_find_vmstate_bs helper

The patch also ensures proper locking for the operation.

Signed-off-by: Denis V. Lunev <address@hidden>
Reviewed-by: Stefan Hajnoczi <address@hidden>
Reviewed-by: Fam Zheng <address@hidden>
Reviewed-by: Juan Quintela <address@hidden>
CC: Kevin Wolf <address@hidden>
Tested-by: Greg Kurz <address@hidden>
Signed-off-by: Juan Quintela <address@hidden>


  Commit: 79b3c12ac5714e036a16d1a163a3517d74504f87
      
https://github.com/qemu/qemu/commit/79b3c12ac5714e036a16d1a163a3517d74504f87
  Author: Denis V. Lunev <address@hidden>
  Date:   2015-11-19 (Thu, 19 Nov 2015)

  Changed paths:
    M migration/savevm.c

  Log Message:
  -----------
  migration: normalize locking in migration/savevm.c

basically all bdrv_* operations must be called under aio_context_acquire
except ones with bdrv_all prefix.

Signed-off-by: Denis V. Lunev <address@hidden>
Reviewed-by: Stefan Hajnoczi <address@hidden>
Reviewed-by: Fam Zheng <address@hidden>
CC: Juan Quintela <address@hidden>
CC: Kevin Wolf <address@hidden>
Tested-by: Greg Kurz <address@hidden>
Signed-off-by: Juan Quintela <address@hidden>


  Commit: 80fda8f609457736ab43f0cb8027abb0e28a67f8
      
https://github.com/qemu/qemu/commit/80fda8f609457736ab43f0cb8027abb0e28a67f8
  Author: Peter Maydell <address@hidden>
  Date:   2015-11-19 (Thu, 19 Nov 2015)

  Changed paths:
    M block/snapshot.c
    M include/block/snapshot.h
    M migration/migration.c
    M migration/ram.c
    M migration/savevm.c

  Log Message:
  -----------
  Merge remote-tracking branch 'remotes/juanquintela/tags/migration/20151119' 
into staging

migration/next for 20151119

# gpg: Signature made Thu 19 Nov 2015 11:17:07 GMT using RSA key ID 5872D723
# gpg: Good signature from "Juan Quintela <address@hidden>"
# gpg:                 aka "Juan Quintela <address@hidden>"

* remotes/juanquintela/tags/migration/20151119:
  migration: normalize locking in migration/savevm.c
  migration: implement bdrv_all_find_vmstate_bs helper
  migration: reorder processing in hmp_savevm
  snapshot: create bdrv_all_create_snapshot helper
  migration: drop find_vmstate_bs check in hmp_delvm
  snapshot: create bdrv_all_find_snapshot helper
  migration: factor our snapshottability check in load_vmstate
  snapshot: create bdrv_all_goto_snapshot helper
  snapshot: create bdrv_all_delete_snapshot helper
  snapshot: return error code from bdrv_snapshot_delete_by_id_or_name
  snapshot: create helper to test that block drivers supports snapshots
  Unneeded NULL check
  migration: Dead assignment of current_time
  Set last_sent_block

Signed-off-by: Peter Maydell <address@hidden>


Compare: https://github.com/qemu/qemu/compare/8f2803090303...80fda8f60945
reply via email to
[Prev in Thread] Current Thread [Next in Thread]