[Qemu-commits] [qemu/qemu] 61b925: crypto: fix leak of gnutls_dh_params_t data on cre...

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: 61b9251a3aaa65e65c4aab3a6800e884bb3b82f9
      
https://github.com/qemu/qemu/commit/61b9251a3aaa65e65c4aab3a6800e884bb3b82f9
  Author: Daniel P. Berrange <address@hidden>
  Date:   2015-11-18 (Wed, 18 Nov 2015)

  Changed paths:
    M crypto/tlscredsx509.c

  Log Message:
  -----------
  crypto: fix leak of gnutls_dh_params_t data on credential unload

The QCryptoTLSCredsX509 object was not free'ing the allocated
gnutls_dh_params_t data when unloading the credentials

Signed-off-by: Daniel P. Berrange <address@hidden>


  Commit: 6ef8cd7a4142049707b70b8278aaa9d8ee2bc5f5
      
https://github.com/qemu/qemu/commit/6ef8cd7a4142049707b70b8278aaa9d8ee2bc5f5
  Author: Daniel P. Berrange <address@hidden>
  Date:   2015-11-18 (Wed, 18 Nov 2015)

  Changed paths:
    M crypto/tlssession.c

  Log Message:
  -----------
  crypto: fix mistaken setting of Error in success code path

The qcrypto_tls_session_check_certificate() method was setting
an Error even when the ACL check suceeded. This didn't affect
the callers detection of errors because they relied on the
function return status, but this did cause a memory leak since
the caller would not free an Error they did not expect to be
set.

Signed-off-by: Daniel P. Berrange <address@hidden>


  Commit: 7b35030eedc26eff82210caa2b0fff2f9d0df453
      
https://github.com/qemu/qemu/commit/7b35030eedc26eff82210caa2b0fff2f9d0df453
  Author: Daniel P. Berrange <address@hidden>
  Date:   2015-11-18 (Wed, 18 Nov 2015)

  Changed paths:
    M tests/crypto-tls-x509-helpers.c

  Log Message:
  -----------
  crypto: fix leaks in TLS x509 helper functions

The test_tls_get_ipaddr() method forgot to free the returned data
from getaddrinfo().

The test_tls_write_cert_chain() method forgot to free the allocated
buffer holding the certificate data after writing it out to a file.

Signed-off-by: Daniel P. Berrange <address@hidden>


  Commit: 08cb175a24d642a40e41db2fef2892b0a1ab504e
      
https://github.com/qemu/qemu/commit/08cb175a24d642a40e41db2fef2892b0a1ab504e
  Author: Daniel P. Berrange <address@hidden>
  Date:   2015-11-18 (Wed, 18 Nov 2015)

  Changed paths:
    M crypto/tlscredsx509.c

  Log Message:
  -----------
  crypto: avoid passing NULL to access() syscall

The qcrypto_tls_creds_x509_sanity_check() checks whether
certs exist by calling access(). It is valid for this
method to be invoked with certfile==NULL though, since
for client credentials the cert is optional. This caused
it to call access(NULL), which happens to be harmless on
current Linux, but should none the less be avoided.

Signed-off-by: Daniel P. Berrange <address@hidden>


  Commit: 7199c89d8c6bbd0eda2cadb0d3fc7149934202bf
      
https://github.com/qemu/qemu/commit/7199c89d8c6bbd0eda2cadb0d3fc7149934202bf
  Author: Peter Maydell <address@hidden>
  Date:   2015-11-18 (Wed, 18 Nov 2015)

  Changed paths:
    M crypto/tlscredsx509.c
    M crypto/tlssession.c
    M tests/crypto-tls-x509-helpers.c

  Log Message:
  -----------
  Merge remote-tracking branch 'remotes/berrange/tags/qcrypto-fixes-20151118-1' 
into staging

Pull qcrypto fixes 2015/11/18 v1

# gpg: Signature made Wed 18 Nov 2015 15:44:07 GMT using RSA key ID 15104FDF
# gpg: Good signature from "Daniel P. Berrange <address@hidden>"
# gpg:                 aka "Daniel P. Berrange <address@hidden>"

* remotes/berrange/tags/qcrypto-fixes-20151118-1:
  crypto: avoid passing NULL to access() syscall
  crypto: fix leaks in TLS x509 helper functions
  crypto: fix mistaken setting of Error in success code path
  crypto: fix leak of gnutls_dh_params_t data on credential unload

Signed-off-by: Peter Maydell <address@hidden>


Compare: https://github.com/qemu/qemu/compare/ab9b872ab314...7199c89d8c6b