qemu-commits
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-commits] [qemu/qemu] 0282ab: vfio/pci: Hide device PCIe capability


From: GitHub
Subject: [Qemu-commits] [qemu/qemu] 0282ab: vfio/pci: Hide device PCIe capability on non-expre...
Date: Wed, 11 Nov 2015 02:00:05 -0800

  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: 0282abf078c3353a178ab77a115828ce333181dd
      
https://github.com/qemu/qemu/commit/0282abf078c3353a178ab77a115828ce333181dd
  Author: Alex Williamson <address@hidden>
  Date:   2015-11-10 (Tue, 10 Nov 2015)

  Changed paths:
    M hw/vfio/pci.c

  Log Message:
  -----------
  vfio/pci: Hide device PCIe capability on non-express buses for PCIe VMs

When we have a PCIe VM, such as Q35, guests start to care more about
valid configurations of devices relative to the VM view of the PCI
topology.  Windows will error with a Code 10 for an assigned device if
a PCIe capability is found for a device on a conventional bus.  We
also have the possibility of IOMMUs, like VT-d, where the where the
guest may be acutely aware of valid express capabilities on physical
hardware.

Some devices, like tg3 are adversely affected by this due to driver
dependencies on the PCIe capability.  The only solution for such
devices is to attach them to an express capable bus in the VM.

Signed-off-by: Alex Williamson <address@hidden>


  Commit: bdd81addf4033ce26e6cd180b060f63095f3ded9
      
https://github.com/qemu/qemu/commit/bdd81addf4033ce26e6cd180b060f63095f3ded9
  Author: Markus Armbruster <address@hidden>
  Date:   2015-11-10 (Tue, 10 Nov 2015)

  Changed paths:
    M hw/vfio/pci-quirks.c
    M hw/vfio/pci.c
    M hw/vfio/platform.c

  Log Message:
  -----------
  vfio: Use g_new() & friends where that makes obvious sense

g_new(T, n) is neater than g_malloc(sizeof(T) * n).  It's also safer,
for two reasons.  One, it catches multiplication overflowing size_t.
Two, it returns T * rather than void *, which lets the compiler catch
more type errors.

This commit only touches allocations with size arguments of the form
sizeof(T).  Same Coccinelle semantic patch as in commit b45c03f.

Signed-off-by: Markus Armbruster <address@hidden>
Signed-off-by: Alex Williamson <address@hidden>


  Commit: d93ae5b69621b7ec6ecfa405ec656d5b5f5e4770
      
https://github.com/qemu/qemu/commit/d93ae5b69621b7ec6ecfa405ec656d5b5f5e4770
  Author: Peter Maydell <address@hidden>
  Date:   2015-11-10 (Tue, 10 Nov 2015)

  Changed paths:
    M hw/vfio/pci-quirks.c
    M hw/vfio/pci.c
    M hw/vfio/platform.c

  Log Message:
  -----------
  Merge remote-tracking branch 'remotes/awilliam/tags/vfio-update-20151110.0' 
into staging

VFIO updates 2015-11-10

 - Make Windows happy with vfio-pci devices exposed on conventional
   PCI buses on q35 by hiding PCIe capability (Alex Williamson)
 - Convert to g_new() where appropriate (Markus Armbruster)

# gpg: Signature made Tue 10 Nov 2015 19:46:41 GMT using RSA key ID 3BB08B22
# gpg: Good signature from "Alex Williamson <address@hidden>"
# gpg:                 aka "Alex Williamson <address@hidden>"
# gpg:                 aka "Alex Williamson <address@hidden>"
# gpg:                 aka "Alex Williamson <address@hidden>"

* remotes/awilliam/tags/vfio-update-20151110.0:
  vfio: Use g_new() & friends where that makes obvious sense
  vfio/pci: Hide device PCIe capability on non-express buses for PCIe VMs

Signed-off-by: Peter Maydell <address@hidden>


Compare: https://github.com/qemu/qemu/compare/a77067f6ac9b...d93ae5b69621

reply via email to

[Prev in Thread] Current Thread [Next in Thread]