[Qemu-commits] [qemu/qemu] cbf82f: ehci: clear suspend bit on detach

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: cbf82fa01e6fd4ecb234b235b10ffce548154a95
      
https://github.com/qemu/qemu/commit/cbf82fa01e6fd4ecb234b235b10ffce548154a95
  Author: Gerd Hoffmann <address@hidden>
  Date:   2015-11-03 (Tue, 03 Nov 2015)

  Changed paths:
    M hw/usb/hcd-ehci.c

  Log Message:
  -----------
  ehci: clear suspend bit on detach

When a device is detached, clear the suspend bit (PORTSC_SUSPEND)
in the port status register.

The specs are not *that* clear what is supposed to happen in case
a suspended device is unplugged.  But the enable bit (PORTSC_PED)
is cleared, and the specs mention setting suspend with enable being
unset is undefined behavior.  So clearing them both looks reasonable,
and it actually fixes the reported bug.

https://bugzilla.redhat.com/show_bug.cgi?id=1268879

Cc: Hans de Goede <address@hidden>
Signed-off-by: Gerd Hoffmann <address@hidden>
Reviewed-by: Hans de Goede <address@hidden>
Message-id: address@hidden


  Commit: a9be4e7c48c4892c836bda1be4d550bb1a6732bd
      
https://github.com/qemu/qemu/commit/a9be4e7c48c4892c836bda1be4d550bb1a6732bd
  Author: Gerd Hoffmann <address@hidden>
  Date:   2015-11-03 (Tue, 03 Nov 2015)

  Changed paths:
    M hw/usb/host-libusb.c

  Log Message:
  -----------
  usb-host: fix usb3ep0quirk test

usb->speed is the usb speed the device is actually running on in the
qemu emulation (i.e. from the guests point of view).  So when plugging
usb3 devices into ehci hostadapter this is HIGH not SUPER.

To figure whenever the host talks to the device with superspeed we
have to check speedmask instead and see whenever the superspeed bit
is set there.

Signed-off-by: Gerd Hoffmann <address@hidden>
Message-id: address@hidden


  Commit: 19bb5467135df4b234af2c93bf6c50284158d6ca
      
https://github.com/qemu/qemu/commit/19bb5467135df4b234af2c93bf6c50284158d6ca
  Author: Peter Maydell <address@hidden>
  Date:   2015-11-03 (Tue, 03 Nov 2015)

  Changed paths:
    M hw/usb/hcd-ehci.c
    M hw/usb/host-libusb.c

  Log Message:
  -----------
  Merge remote-tracking branch 'remotes/kraxel/tags/pull-usb-20151103-1' into 
staging

usb: two bugfixes for ehci & usb-host.

# gpg: Signature made Tue 03 Nov 2015 10:57:28 GMT using RSA key ID D3E87138
# gpg: Good signature from "Gerd Hoffmann (work) <address@hidden>"
# gpg:                 aka "Gerd Hoffmann <address@hidden>"
# gpg:                 aka "Gerd Hoffmann (private) <address@hidden>"

* remotes/kraxel/tags/pull-usb-20151103-1:
  usb-host: fix usb3ep0quirk test
  ehci: clear suspend bit on detach

Signed-off-by: Peter Maydell <address@hidden>


Compare: https://github.com/qemu/qemu/compare/130d0bc6594d...19bb5467135d