[Qemu-commits] [qemu/qemu] 5ec911: sdhci: Pass drive parameter to sdhci-pci via qdev ...

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: 5ec911c30ff4337d4185e29e82a254349f5a22da
      
https://github.com/qemu/qemu/commit/5ec911c30ff4337d4185e29e82a254349f5a22da
  Author: Kevin O'Connor <address@hidden>
  Date:   2015-10-12 (Mon, 12 Oct 2015)

  Changed paths:
    M hw/sd/sd.c
    M hw/sd/sdhci.c
    M hw/sd/sdhci.h

  Log Message:
  -----------
  sdhci: Pass drive parameter to sdhci-pci via qdev property

Commit 19109131 disabled the sdhci-pci support because it used
drive_get_next().  This patch reenables sdhci-pci and changes it to
pass the drive via a qdev property - for example:
 -device sdhci-pci,drive=drive0 -drive id=drive0,if=sd,file=myimage

Reviewed-by: Stefan Hajnoczi <address@hidden>
Signed-off-by: Kevin O'Connor <address@hidden>
Signed-off-by: Stefan Hajnoczi <address@hidden>


  Commit: fc73548e444ae3239f6cef44a5200b5d2c3e85d1
      
https://github.com/qemu/qemu/commit/fc73548e444ae3239f6cef44a5200b5d2c3e85d1
  Author: Stefan Hajnoczi <address@hidden>
  Date:   2015-10-12 (Mon, 12 Oct 2015)

  Changed paths:
    M hw/block/virtio-blk.c

  Log Message:
  -----------
  virtio-blk: use blk_io_plug/unplug for Linux AIO batching

The raw-posix block driver implements Linux AIO batching so multiple
requests can be submitted with a single io_submit(2) system call.
Batching is currently only used by virtio-scsi and
virtio-blk-data-plane.

Enable batching for regular virtio-blk so the number of io_submit(2)
system calls is reduced for workloads with queue depth > 1.

In 4KB random read performance tests with queue depth 32, the CPU
utilization on the host is reduced by 9.4%.  The fio job is as follows:

  [global]
  bs=4k
  ioengine=libaio
  iodepth=32
  direct=1
  sync=0
  time_based=1
  runtime=30
  clocksource=gettimeofday
  ramp_time=5

  [job1]
  rw=randread
  filename=/dev/vdb
  size=4096M
  write_bw_log=fio
  write_iops_log=fio
  write_lat_log=fio
  log_avg_msec=1000

This benchmark was run on an raw image on LVM.  The disk was an SSD
drive and -drive cache=none,aio=native was used.

Tested-by: Pradeep Surisetty <address@hidden>
Signed-off-by: Stefan Hajnoczi <address@hidden>
Reviewed-by: Fam Zheng <address@hidden>


  Commit: a9718ef0005d6910097788936dc40c0204713729
      
https://github.com/qemu/qemu/commit/a9718ef0005d6910097788936dc40c0204713729
  Author: Pierre Morel <address@hidden>
  Date:   2015-10-12 (Mon, 12 Oct 2015)

  Changed paths:
    M hw/virtio/dataplane/vring.c
    M include/hw/virtio/dataplane/vring.h

  Log Message:
  -----------
  virtio dataplane: adapt dataplane for virtio Version 1

Let dataplane allocate different region for the desc/avail/used
ring regions.
Take VIRTIO_RING_F_EVENT_IDX into account to increase the used/avail
rings accordingly.

[Fix 32-bit builds by changing 16lx format specifier to HWADDR_PRIx.
--Stefan]

Signed-off-by: Pierre Morel <address@hidden>
Tested-by: Greg Kurz <address@hidden>
Signed-off-by: Greg Kurz <address@hidden>
Message-id: address@hidden
(changed __virtio16 into uint16_t,
 map descriptor table and available ring read-only)
Signed-off-by: Greg Kurz <address@hidden>
Signed-off-by: Stefan Hajnoczi <address@hidden>


  Commit: c84b31926f018af6fea2ab37a1fc47060b4bcfa1
      
https://github.com/qemu/qemu/commit/c84b31926f018af6fea2ab37a1fc47060b4bcfa1
  Author: Paolo Bonzini <address@hidden>
  Date:   2015-10-12 (Mon, 12 Oct 2015)

  Changed paths:
    M block/io.c
    M block/mirror.c
    M block/raw-posix.c
    M block/raw-win32.c
    M hw/block/virtio-blk.c

  Log Message:
  -----------
  block: switch from g_slice allocator to malloc

Simplify memory allocation by sticking with a single API.  GSlice
is not that fast anyway (tcmalloc/jemalloc are better).

Signed-off-by: Paolo Bonzini <address@hidden>
Signed-off-by: Stefan Hajnoczi <address@hidden>


  Commit: 9201bb9a8c7cd3ba2382b7db5b2e40f603e61528
      
https://github.com/qemu/qemu/commit/9201bb9a8c7cd3ba2382b7db5b2e40f603e61528
  Author: Alistair Francis <address@hidden>
  Date:   2015-10-12 (Mon, 12 Oct 2015)

  Changed paths:
    M hw/sd/sdhci.c

  Log Message:
  -----------
  sdhci.c: Limit the maximum block size

It is possible for the guest to set an invalid block
size which is larger then the fifo_buffer[] array. This
could cause a buffer overflow.

To avoid this limit the maximum size of the blksize variable.

Signed-off-by: Alistair Francis <address@hidden>
Reported-by: Intel Security ATR <address@hidden>
Reviewed-by: Stefan Hajnoczi <address@hidden>
Reviewed-by: Peter Crosthwaite <address@hidden>
Message-id: address@hidden
Suggested-by: Igor Mitsyanko <address@hidden>
Reported-by: Intel Security ATR <address@hidden>
Reviewed-by: Stefan Hajnoczi <address@hidden>
Signed-off-by: Stefan Hajnoczi <address@hidden>


  Commit: 5451316ed07b758a187dedf21047bed8f843f7f1
      
https://github.com/qemu/qemu/commit/5451316ed07b758a187dedf21047bed8f843f7f1
  Author: Peter Maydell <address@hidden>
  Date:   2015-10-12 (Mon, 12 Oct 2015)

  Changed paths:
    M block/io.c
    M block/mirror.c
    M block/raw-posix.c
    M block/raw-win32.c
    M hw/block/virtio-blk.c
    M hw/sd/sd.c
    M hw/sd/sdhci.c
    M hw/sd/sdhci.h
    M hw/virtio/dataplane/vring.c
    M include/hw/virtio/dataplane/vring.h

  Log Message:
  -----------
  Merge remote-tracking branch 'remotes/stefanha/tags/block-pull-request' into 
staging

Pull request

v2:
 * Fix virtio 16lx -> HWADDR_PRIx format specifier [Peter]

# gpg: Signature made Mon 12 Oct 2015 11:19:06 BST using RSA key ID 81AB73C8
# gpg: Good signature from "Stefan Hajnoczi <address@hidden>"
# gpg:                 aka "Stefan Hajnoczi <address@hidden>"

* remotes/stefanha/tags/block-pull-request:
  sdhci.c: Limit the maximum block size
  block: switch from g_slice allocator to malloc
  virtio dataplane: adapt dataplane for virtio Version 1
  virtio-blk: use blk_io_plug/unplug for Linux AIO batching
  sdhci: Pass drive parameter to sdhci-pci via qdev property

Signed-off-by: Peter Maydell <address@hidden>


Compare: https://github.com/qemu/qemu/compare/0bf224d5da41...5451316ed07b