qemu-commits
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-commits] [qemu/qemu] aa4f40: gtk: check for existing grabs in gd_g


From: GitHub
Subject: [Qemu-commits] [qemu/qemu] aa4f40: gtk: check for existing grabs in gd_grab_{pointer, ...
Date: Tue, 15 Sep 2015 07:30:05 -0700

  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: aa4f4058ba8cde200e62ef3dafc4e1595f6033e9
      
https://github.com/qemu/qemu/commit/aa4f4058ba8cde200e62ef3dafc4e1595f6033e9
  Author: Gerd Hoffmann <address@hidden>
  Date:   2015-09-15 (Tue, 15 Sep 2015)

  Changed paths:
    M ui/gtk.c

  Log Message:
  -----------
  gtk: check for existing grabs in gd_grab_{pointer,keyboard}

If a grab is already active for our window, do nothing.
If a grab is already active for another window, release it.

Cleanup some checks and ungrab calls in the code which are
not needed any more.

Signed-off-by: Gerd Hoffmann <address@hidden>
Reviewed-by: Marc-André Lureau <address@hidden>


  Commit: 695cc59d42f2e285abd5cf278bdc07360a995eaa
      
https://github.com/qemu/qemu/commit/695cc59d42f2e285abd5cf278bdc07360a995eaa
  Author: Gerd Hoffmann <address@hidden>
  Date:   2015-09-15 (Tue, 15 Sep 2015)

  Changed paths:
    M ui/gtk.c

  Log Message:
  -----------
  gtk: move gd_update_caption calls to gd_{grab,ungrab}_{pointer,keyboard}

Then we don't have to pair the grab/ungrab calls with update_caption
calls any more because things happen automatically ;)

Signed-off-by: Gerd Hoffmann <address@hidden>
Reviewed-by: Marc-André Lureau <address@hidden>


  Commit: d531deef119666d4b3605e186a43010782efd899
      
https://github.com/qemu/qemu/commit/d531deef119666d4b3605e186a43010782efd899
  Author: Gerd Hoffmann <address@hidden>
  Date:   2015-09-15 (Tue, 15 Sep 2015)

  Changed paths:
    M trace-events
    M ui/gtk.c

  Log Message:
  -----------
  gtk: trace input grab reason

Add a reason to grab calls and trace points,
so it is easier to debug grab related ui issues.

Signed-off-by: Gerd Hoffmann <address@hidden>
Reviewed-by: Marc-André Lureau <address@hidden>


  Commit: 1d73cd782fb910811a2e6b9d9b3375c4803d731c
      
https://github.com/qemu/qemu/commit/1d73cd782fb910811a2e6b9d9b3375c4803d731c
  Author: Gerd Hoffmann <address@hidden>
  Date:   2015-09-15 (Tue, 15 Sep 2015)

  Changed paths:
    M ui/gtk.c

  Log Message:
  -----------
  gtk: set free_scale when setting zoom_fit

free_scale field tracks zoom-fit menu toggle state,
so we should keep them in sync ...

Signed-off-by: Gerd Hoffmann <address@hidden>
Reviewed-by: Marc-André Lureau <address@hidden>


  Commit: 78aee081122837cb488b12657a00deeb676b4730
      
https://github.com/qemu/qemu/commit/78aee081122837cb488b12657a00deeb676b4730
  Author: Gerd Hoffmann <address@hidden>
  Date:   2015-09-15 (Tue, 15 Sep 2015)

  Changed paths:
    M ui/gtk.c

  Log Message:
  -----------
  gtk: don't grab input when entering fullscreen.

Kick off all grabbing logic from fullscreen mode.  In the current state
it seems to create more problems than it solves.  Try running qemu/gtk
fullscreen on one head of a multihead host for example ...

There probably was a reason the grab-on-fullscreen logic was added in
the first place.  So please test and report any issues so we can try to
find a sane way to handle it.

Signed-off-by: Gerd Hoffmann <address@hidden>
Reviewed-by: Marc-André Lureau <address@hidden>


  Commit: 2cb5d2a47c655331bcf0ab16bab8fe4701182c58
      
https://github.com/qemu/qemu/commit/2cb5d2a47c655331bcf0ab16bab8fe4701182c58
  Author: Alberto Garcia <address@hidden>
  Date:   2015-09-15 (Tue, 15 Sep 2015)

  Changed paths:
    M ui/gtk.c

  Log Message:
  -----------
  gtk: use setlocale() for LC_MESSAGES only

The QEMU code is not internationalized and assumes that it runs under
the C locale, but if we use the GTK+ UI we'll end up importing the
locale settings from the environment. This can break things, such as
the JSON generator and iotest 120 in locales that use a decimal comma.

We do however have translations for a few simple strings for the GTK+
menu items, so in order to run QEMU using the C locale, and yet have a
translated UI let's use setlocale() for LC_MESSAGES only.

Cc: address@hidden
Signed-off-by: Alberto Garcia <address@hidden>
Signed-off-by: Gerd Hoffmann <address@hidden>


  Commit: 1078f5db8ada5097600443838492ef07103790c2
      
https://github.com/qemu/qemu/commit/1078f5db8ada5097600443838492ef07103790c2
  Author: Peter Maydell <address@hidden>
  Date:   2015-09-15 (Tue, 15 Sep 2015)

  Changed paths:
    M trace-events
    M ui/gtk.c

  Log Message:
  -----------
  Merge remote-tracking branch 'remotes/kraxel/tags/pull-gtk-20150915-1' into 
staging

gtk: misc grab tweaks, locale fix.

# gpg: Signature made Tue 15 Sep 2015 11:35:36 BST using RSA key ID D3E87138
# gpg: Good signature from "Gerd Hoffmann (work) <address@hidden>"
# gpg:                 aka "Gerd Hoffmann <address@hidden>"
# gpg:                 aka "Gerd Hoffmann (private) <address@hidden>"

* remotes/kraxel/tags/pull-gtk-20150915-1:
  gtk: use setlocale() for LC_MESSAGES only
  gtk: don't grab input when entering fullscreen.
  gtk: set free_scale when setting zoom_fit
  gtk: trace input grab reason
  gtk: move gd_update_caption calls to gd_{grab,ungrab}_{pointer,keyboard}
  gtk: check for existing grabs in gd_grab_{pointer,keyboard}

Signed-off-by: Peter Maydell <address@hidden>


Compare: https://github.com/qemu/qemu/compare/b76a0d5db25a...1078f5db8ada

reply via email to

[Prev in Thread] Current Thread [Next in Thread]