qemu-commits
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-commits] [qemu/qemu] 38e20c: qapi/qmp-event.c: Don't manually incl


From: GitHub
Subject: [Qemu-commits] [qemu/qemu] 38e20c: qapi/qmp-event.c: Don't manually include os-win32....
Date: Wed, 19 Aug 2015 11:30:04 -0700

  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: 38e20cac669083e2e10a2a9a9602cb99ec19299e
      
https://github.com/qemu/qemu/commit/38e20cac669083e2e10a2a9a9602cb99ec19299e
  Author: Peter Maydell <address@hidden>
  Date:   2015-08-19 (Wed, 19 Aug 2015)

  Changed paths:
    M qapi/qmp-event.c

  Log Message:
  -----------
  qapi/qmp-event.c: Don't manually include os-win32.h/os-posix.h

qmp-event.c already includes qemu-common.h, so manually including
os-win32.h/os-posix.h is unnecessary (and potentially fragile,
since it's duplicating the #ifdef logic that chooses which of the
two we need). Remove the unnecessary include logic.

Signed-off-by: Peter Maydell <address@hidden>
Reviewed-by: Daniel P. Berrange <address@hidden>


  Commit: 71baf787d8fa2a5d186f22d8154069fd212be37f
      
https://github.com/qemu/qemu/commit/71baf787d8fa2a5d186f22d8154069fd212be37f
  Author: Peter Maydell <address@hidden>
  Date:   2015-08-19 (Wed, 19 Aug 2015)

  Changed paths:
    M include/qemu/osdep.h
    M monitor.c
    M user-exec.c

  Log Message:
  -----------
  osdep.h: Remove qemu_printf

qemu_printf is an ancient remnant which has been a simple #define to
printf for over a decade, and is used in only a few places. Expand
it out in those places and remove the #define.

Signed-off-by: Peter Maydell <address@hidden>
Reviewed-by: Daniel P. Berrange <address@hidden>


  Commit: 4912086865083a008f4fb73173fd0ddf2206c4d9
      
https://github.com/qemu/qemu/commit/4912086865083a008f4fb73173fd0ddf2206c4d9
  Author: Peter Maydell <address@hidden>
  Date:   2015-08-19 (Wed, 19 Aug 2015)

  Changed paths:
    M include/qemu/compiler.h
    M include/qemu/osdep.h

  Log Message:
  -----------
  osdep.h: Move some compiler-specific things to compiler.h

osdep.h has a few things which are really compiler specific;
move them to compiler.h, and include compiler.h from osdep.h.

Signed-off-by: Peter Maydell <address@hidden>
Reviewed-by: Daniel P. Berrange <address@hidden>


  Commit: 24134c4e9126bf505b612e901c63a102fc471083
      
https://github.com/qemu/qemu/commit/24134c4e9126bf505b612e901c63a102fc471083
  Author: Peter Maydell <address@hidden>
  Date:   2015-08-19 (Wed, 19 Aug 2015)

  Changed paths:
    M include/qemu/compiler.h

  Log Message:
  -----------
  compiler.h: Use glue() in QEMU_BUILD_BUG_ON define

Rather than rolling custom concatenate-strings macros for the
QEMU_BUILD_BUG_ON macro to use, use the glue() macro we already
have (since it's now available to us in this header).

Signed-off-by: Peter Maydell <address@hidden>
Reviewed-by: Daniel P. Berrange <address@hidden>


  Commit: 1aad8104f3b69206da1f868639e1f69c26f6d482
      
https://github.com/qemu/qemu/commit/1aad8104f3b69206da1f868639e1f69c26f6d482
  Author: Peter Maydell <address@hidden>
  Date:   2015-08-19 (Wed, 19 Aug 2015)

  Changed paths:
    M include/qemu-common.h
    M include/sysemu/os-win32.h

  Log Message:
  -----------
  qemu-common.h: Move Win32 fixups into os-win32.h

qemu-common.h includes some fixups for things the Win32
headers don't define or define weirdly. These really
belong in os-win32.h, so move them there.

Signed-off-by: Peter Maydell <address@hidden>
Reviewed-by: Daniel P. Berrange <address@hidden>


  Commit: bfe7e449f14313f646da621288ca2fd12223414f
      
https://github.com/qemu/qemu/commit/bfe7e449f14313f646da621288ca2fd12223414f
  Author: Peter Maydell <address@hidden>
  Date:   2015-08-19 (Wed, 19 Aug 2015)

  Changed paths:
    M include/qemu-common.h
    M include/qemu/osdep.h

  Log Message:
  -----------
  osdep.h: Move some OS header includes and fixups from qemu-common.h

qemu-common.h has some system header includes and fixups for
things that might be missing. This is really an OS dependency
and belongs in osdep.h, so move it across.

Signed-off-by: Peter Maydell <address@hidden>
Reviewed-by: Daniel P. Berrange <address@hidden>


  Commit: 03557b9abaee78e9d1ef5cd236d32a7b3e75e6f8
      
https://github.com/qemu/qemu/commit/03557b9abaee78e9d1ef5cd236d32a7b3e75e6f8
  Author: Peter Maydell <address@hidden>
  Date:   2015-08-19 (Wed, 19 Aug 2015)

  Changed paths:
    M include/qemu/osdep.h

  Log Message:
  -----------
  osdep.h: Add header comment

Add a header comment to osdep.h, explaining what the header is for
and some rules to avoid circular-include difficulties.

Signed-off-by: Peter Maydell <address@hidden>
Reviewed-by: Daniel P. Berrange <address@hidden>


  Commit: 49caffe0cc95a9d0dc344e3328be8197f3536cf8
      
https://github.com/qemu/qemu/commit/49caffe0cc95a9d0dc344e3328be8197f3536cf8
  Author: Peter Maydell <address@hidden>
  Date:   2015-08-19 (Wed, 19 Aug 2015)

  Changed paths:
    M include/qemu-common.h
    M include/qemu/host-utils.h
    M include/qemu/timer.h

  Log Message:
  -----------
  qemu-common.h: Move muldiv64() to host-utils.h

Move the muldiv64() function from qemu-common.h to host-utils.h.
This puts it together with all the other arithmetic functions
where we provide a version with __int128_t and a fallback
without, and allows headers which need muldiv64() to avoid
including qemu-common.h.

We don't include host-utils from qemu-common.h, to avoid dragging
more things into qemu-common.h than it already has; in practice
everywhere that needs muldiv64() can get it via qemu/timer.h.

Signed-off-by: Peter Maydell <address@hidden>
Reviewed-by: Daniel P. Berrange <address@hidden>


  Commit: 20fbcfdd58ea47607a5755979d43f8c48ac93f08
      
https://github.com/qemu/qemu/commit/20fbcfdd58ea47607a5755979d43f8c48ac93f08
  Author: Peter Maydell <address@hidden>
  Date:   2015-08-19 (Wed, 19 Aug 2015)

  Changed paths:
    M include/hw/i386/apic_internal.h

  Log Message:
  -----------
  apic_internal.h: Include cpu.h directly

apic_internal.h relies on cpu.h having been included (for the
X86CPU type); include it directly rather than relying on it
being pulled in via one of the other includes like timer.h.

Signed-off-by: Peter Maydell <address@hidden>
Reviewed-by: Daniel P. Berrange <address@hidden>


Compare: https://github.com/qemu/qemu/compare/4c4a29cb681e...20fbcfdd58ea

reply via email to

[Prev in Thread] Current Thread [Next in Thread]