[Qemu-commits] [qemu/qemu] 950fe0: xen/pass-through: fold host PCI command register w...

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: 950fe0aa3f55ad6bb135fc9cde9ebf4df05f62fc
      
https://github.com/qemu/qemu/commit/950fe0aa3f55ad6bb135fc9cde9ebf4df05f62fc
  Author: Jan Beulich <address@hidden>
  Date:   2015-06-23 (Tue, 23 Jun 2015)

  Changed paths:
    M hw/xen/xen_pt.c

  Log Message:
  -----------
  xen/pass-through: fold host PCI command register writes

The code introduced to address XSA-126 allows simplification of other
code in xen_pt_initfn(): All we need to do is update "cmd" suitably,
as it'll be written back to the host register near the end of the
function anyway.

Signed-off-by: Stefano Stabellini <address@hidden>
Signed-off-by: Jan Beulich <address@hidden>


  Commit: 69976894c1d91c4b0c985fa05936cb6b8d01382b
      
https://github.com/qemu/qemu/commit/69976894c1d91c4b0c985fa05936cb6b8d01382b
  Author: Jan Beulich <address@hidden>
  Date:   2015-06-23 (Tue, 23 Jun 2015)

  Changed paths:
    M hw/xen/xen_pt.c
    M hw/xen/xen_pt_config_init.c

  Log Message:
  -----------
  xen/pass-through: ROM BAR handling adjustments

Expecting the ROM BAR to be written with an all ones value when sizing
the region is wrong - the low bit has another meaning (enable/disable)
and bits 1..10 are reserved. The PCI spec also mandates writing all
ones to just the address portion of the register.

Use suitable constants also for initializing the ROM BAR register field
description.

Signed-off-by: Stefano Stabellini <address@hidden>
Signed-off-by: Jan Beulich <address@hidden>


  Commit: 3782f60d2047cb86567889307ce78baacf518635
      
https://github.com/qemu/qemu/commit/3782f60d2047cb86567889307ce78baacf518635
  Author: Jan Beulich <address@hidden>
  Date:   2015-06-23 (Tue, 23 Jun 2015)

  Changed paths:
    M hw/xen/xen_pt.c
    M hw/xen/xen_pt_msi.c

  Log Message:
  -----------
  xen/pass-through: log errno values rather than function return ones

Functions setting errno commonly return just -1, which is of no
particular use in the log file.

Signed-off-by: Jan Beulich <address@hidden>
Reviewed-by: Stefano Stabellini <address@hidden>


  Commit: 74526eb01886ca45774c1e9c736f61536fa2bda1
      
https://github.com/qemu/qemu/commit/74526eb01886ca45774c1e9c736f61536fa2bda1
  Author: Jan Beulich <address@hidden>
  Date:   2015-06-23 (Tue, 23 Jun 2015)

  Changed paths:
    M hw/xen/xen_pt.h
    M hw/xen/xen_pt_config_init.c

  Log Message:
  -----------
  xen/pass-through: constify some static data

This is done indirectly by adjusting two typedefs and helps emphasizing
that the respective tables aren't supposed to be modified at runtime
(as they may be shared between devices).

Signed-off-by: Jan Beulich <address@hidden>
Reviewed-by: Stefano Stabellini <address@hidden>


  Commit: ffffbb369f3ed9bca5ff2867143f76d0c6e069c0
      
https://github.com/qemu/qemu/commit/ffffbb369f3ed9bca5ff2867143f76d0c6e069c0
  Author: Stefano Stabellini <address@hidden>
  Date:   2015-06-23 (Tue, 23 Jun 2015)

  Changed paths:
    M xen-hvm.c

  Log Message:
  -----------
  Revert "xen-hvm: increase maxmem before calling xc_domain_populate_physmap"

This reverts commit c1d322e6048796296555dd36fdd102d7fa2f50bf.

The original commit fixes a bug when assigning a large number of
devices which require option roms to a guest.  (One known
configuration that needs extra memory is having more than 4 emulated
NICs assigned.  Three or fewer NICs seems to work without this
functionality.)

However, by unilaterally increasing maxmem, it introduces two
problems.

First, now libxl's calculation of the required maxmem during migration
is broken -- any guest which exercised this functionality will fail on
migration.  (Guests which have the default number of devices are not
affected.)

Secondly, it makes it impossible for a higher-level toolstack or
administer to predict how much memory a VM will actually use, making
it much more difficult to effectively use all of the memory on a
machine.

Signed-off-by: George Dunlap <address@hidden>
Signed-off-by: Stefano Stabellini <address@hidden>


  Commit: 000d6042da0d73e5a71318b5fa96e5a084534d12
      
https://github.com/qemu/qemu/commit/000d6042da0d73e5a71318b5fa96e5a084534d12
  Author: Peter Maydell <address@hidden>
  Date:   2015-06-23 (Tue, 23 Jun 2015)

  Changed paths:
    M hw/xen/xen_pt.c
    M hw/xen/xen_pt.h
    M hw/xen/xen_pt_config_init.c
    M hw/xen/xen_pt_msi.c
    M xen-hvm.c

  Log Message:
  -----------
  Merge remote-tracking branch 'remotes/sstabellini/tags/xen-220615-3' into 
staging

xen-220615, more SOB lines

# gpg: Signature made Tue Jun 23 17:19:08 2015 BST using RSA key ID 70E1AE90
# gpg: Good signature from "Stefano Stabellini <address@hidden>"

* remotes/sstabellini/tags/xen-220615-3:
  Revert "xen-hvm: increase maxmem before calling xc_domain_populate_physmap"
  xen/pass-through: constify some static data
  xen/pass-through: log errno values rather than function return ones
  xen/pass-through: ROM BAR handling adjustments
  xen/pass-through: fold host PCI command register writes

Signed-off-by: Peter Maydell <address@hidden>


Compare: https://github.com/qemu/qemu/compare/6966b2a07190...000d6042da0d