qemu-commits
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-commits] [qemu/qemu] bf6667: virtfs-proxy-helper: add missing long


From: GitHub
Subject: [Qemu-commits] [qemu/qemu] bf6667: virtfs-proxy-helper: add missing long option termi...
Date: Wed, 17 Jun 2015 03:30:08 -0700

  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: bf6667d63ef4c4fbaf91051589a594ec1c235308
      
https://github.com/qemu/qemu/commit/bf6667d63ef4c4fbaf91051589a594ec1c235308
  Author: Stefan Hajnoczi <address@hidden>
  Date:   2015-06-16 (Tue, 16 Jun 2015)

  Changed paths:
    M fsdev/virtfs-proxy-helper.c

  Log Message:
  -----------
  virtfs-proxy-helper: add missing long option terminator

The getopt_long(3) long options array must have a zeroed terminator.

This patch solves a segmentation fault when an unknown command-line
option is encountered:

  $ fsdev/virtfs-proxy-helper --help
  Segmentation fault (core dumped)

Signed-off-by: Stefan Hajnoczi <address@hidden>
Signed-off-by: Aneesh Kumar K.V <address@hidden>


  Commit: f8d30a4f96d6c3a12e692d2e69b8fe4734b916c6
      
https://github.com/qemu/qemu/commit/f8d30a4f96d6c3a12e692d2e69b8fe4734b916c6
  Author: Stefan Hajnoczi <address@hidden>
  Date:   2015-06-16 (Tue, 16 Jun 2015)

  Changed paths:
    M fsdev/virtfs-proxy-helper.c

  Log Message:
  -----------
  virtfs-proxy-helper: fail gracefully if socket path is too long

Replace the assertion check with graceful failure when the socket path
is too long.  Programs should not crash on invalid input.  Print an
error message and exit properly.

Cc: Shannon Zhao <address@hidden>
Signed-off-by: Stefan Hajnoczi <address@hidden>
Signed-off-by: Aneesh Kumar K.V <address@hidden>


  Commit: 8c29f8d6b9595ac0f9ab1b41f22e91aebab482d7
      
https://github.com/qemu/qemu/commit/8c29f8d6b9595ac0f9ab1b41f22e91aebab482d7
  Author: Peter Maydell <address@hidden>
  Date:   2015-06-17 (Wed, 17 Jun 2015)

  Changed paths:
    M fsdev/virtfs-proxy-helper.c

  Log Message:
  -----------
  Merge remote-tracking branch 'remotes/kvaneesh/tags/for-upstream-signed' into 
staging

VirtFS update:

* Fix for virtfs-proxy-helper crash
* Gracefully handle the error condition on input validation in 
virtfs-proxy-helper

# gpg: Signature made Tue Jun 16 16:21:28 2015 BST using RSA key ID 04C4E23A
# gpg: Good signature from "Aneesh Kumar K.V <address@hidden>"
# gpg: WARNING: This key is not certified with a trusted signature!
# gpg:          There is no indication that the signature belongs to the owner.
# Primary key fingerprint: 4846 9DE7 1860 360F A6E9  968C DE41 A4FE 04C4 E23A

* remotes/kvaneesh/tags/for-upstream-signed:
  virtfs-proxy-helper: fail gracefully if socket path is too long
  virtfs-proxy-helper: add missing long option terminator

Signed-off-by: Peter Maydell <address@hidden>


Compare: https://github.com/qemu/qemu/compare/93f6d1c16036...8c29f8d6b959

reply via email to

[Prev in Thread] Current Thread [Next in Thread]