qemu-commits
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-commits] [qemu/qemu] 779cec: monitor: Fix QMP ABI breakage around


From: GitHub
Subject: [Qemu-commits] [qemu/qemu] 779cec: monitor: Fix QMP ABI breakage around "id"
Date: Mon, 08 Jun 2015 05:30:05 -0700

  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: 779cec4d20907cbccb26fbf5f5c19c6cdee33eff
      
https://github.com/qemu/qemu/commit/779cec4d20907cbccb26fbf5f5c19c6cdee33eff
  Author: Markus Armbruster <address@hidden>
  Date:   2015-06-08 (Mon, 08 Jun 2015)

  Changed paths:
    M monitor.c

  Log Message:
  -----------
  monitor: Fix QMP ABI breakage around "id"

Commit 65207c5 accidentally dropped a line of code we need along with
a comment that became wrong then.  This made QMP reject "id":

    {"execute": "system_reset", "id": "1"}
    {"error": {"class": "GenericError", "desc": "QMP input object member 'id' 
is unexpected"}}

Put the lost line right back, so QMP again accepts and returns "id",
as promised by the ABI:

    {"execute": "system_reset", "id": "1"}
    {"return": {}, "id": "1"}

Reported-by: Fabio Fantoni <address@hidden>
Signed-off-by: Markus Armbruster <address@hidden>
Signed-off-by: Don Slutz <address@hidden>
Tested-by: Fabio Fantoni <address@hidden>
Signed-off-by: Wen Congyang <address@hidden>
Signed-off-by: Pavel Fedin <address@hidden>
Tested-by: Eric Blake <address@hidden>
Signed-off-by: Markus Armbruster <address@hidden>
Message-id: address@hidden
Signed-off-by: Peter Maydell <address@hidden>



reply via email to

[Prev in Thread] Current Thread [Next in Thread]