[Qemu-commits] [qemu/qemu] 0e3bd5: pc: Ensure non-zero CPU ref count after attaching ...

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: 0e3bd56294230ad0ee20fce587879c29a83a0d8b
      
https://github.com/qemu/qemu/commit/0e3bd56294230ad0ee20fce587879c29a83a0d8b
  Author: Andreas Färber <address@hidden>
  Date:   2015-06-02 (Tue, 02 Jun 2015)

  Changed paths:
    M hw/i386/pc.c

  Log Message:
  -----------
  pc: Ensure non-zero CPU ref count after attaching to ICC bus

Setting the parent bus of a device increases its ref count, which we
ultimately want to level out. However it is only safe to do so after the
last reference to the device in local code, as qom-set or similar operations
might decrease the ref count.

Therefore move the object_unref() from pc_new_cpu() into its callers.

The APIC operations on the last CPU in pc_cpus_init() are still potentially
insecure, but that is beyond the scope of this code movement.

Signed-off-by: Andreas Färber <address@hidden>
Acked-by: Michael S. Tsirkin <address@hidden>
Reviewed-by: Eduardo Habkost <address@hidden>
Signed-off-by: Eduardo Habkost <address@hidden>


  Commit: 458cf469f4a1cb520b07092f5537c5a6d2389d23
      
https://github.com/qemu/qemu/commit/458cf469f4a1cb520b07092f5537c5a6d2389d23
  Author: Eduardo Habkost <address@hidden>
  Date:   2015-06-02 (Tue, 02 Jun 2015)

  Changed paths:
    M target-i386/cpu.h

  Log Message:
  -----------
  target-i386: Fix signedness of MSR_IA32_APICBASE_BASE

Existing definition triggers the following when using clang
-fsanitize=undefined:

    hw/intc/apic_common.c:314:55: runtime error: left shift of 1048575 by 12
  places cannot be represented in type 'int'

Fix it so we won't try to shift a 1 to the sign bit of a signed integer.

Suggested-by: Peter Maydell <address@hidden>
Reviewed-by: Igor Mammedov <address@hidden>
Signed-off-by: Eduardo Habkost <address@hidden>


  Commit: be9f8a08727e46c790adb8caa8a4525a1e8e9e73
      
https://github.com/qemu/qemu/commit/be9f8a08727e46c790adb8caa8a4525a1e8e9e73
  Author: Zhu Guihua <address@hidden>
  Date:   2015-06-02 (Tue, 02 Jun 2015)

  Changed paths:
    M hw/intc/apic.c

  Log Message:
  -----------
  apic: convert ->busdev.qdev casts to C casts

Use C casts to avoid accessing ICCDevice's qdev field
directly.

Signed-off-by: Zhu Guihua <address@hidden>
Reviewed-by: Igor Mammedov <address@hidden>
Reviewed-by: Andreas Färber <address@hidden>
Acked-by: Andreas Färber <address@hidden>
Signed-off-by: Eduardo Habkost <address@hidden>


  Commit: 38e5c119c2925812bd441450ab9e5e00fc79e662
      
https://github.com/qemu/qemu/commit/38e5c119c2925812bd441450ab9e5e00fc79e662
  Author: Eduardo Habkost <address@hidden>
  Date:   2015-06-02 (Tue, 02 Jun 2015)

  Changed paths:
    M target-i386/cpu.c

  Log Message:
  -----------
  target-i386: Register QOM properties for feature flags

This uses the feature name arrays to register QOM properties for feature
flags. This simply adds properties that can be configured using -global,
but doesn't change x86_cpu_parse_featurestr() to use them yet.

Reviewed-by: Igor Mammedov <address@hidden>
Signed-off-by: Eduardo Habkost <address@hidden>


  Commit: 1b93c9a1040b3c12320cf55c6284882a2e6e8ff3
      
https://github.com/qemu/qemu/commit/1b93c9a1040b3c12320cf55c6284882a2e6e8ff3
  Author: Ikey Doherty <address@hidden>
  Date:   2015-06-02 (Tue, 02 Jun 2015)

  Changed paths:
    M Makefile
    M arch_init.c
    R sysconfigs/target/target-x86_64.conf

  Log Message:
  -----------
  arch_init: Drop target-x86_64.conf

The target-x86_64.conf sysconfig file has been empty and essentially ignored
now for several years. This change removes the unused file to enable moving
towards a stateless configuration.

Signed-off-by: Ikey Doherty <address@hidden>
Acked-by: Paolo Bonzini <address@hidden>
Reviewed-by: Eduardo Habkost <address@hidden>
Signed-off-by: Eduardo Habkost <address@hidden>


  Commit: 6fa6b312765f698dc81b2c30e7eeb9683804a05b
      
https://github.com/qemu/qemu/commit/6fa6b312765f698dc81b2c30e7eeb9683804a05b
  Author: Peter Maydell <address@hidden>
  Date:   2015-06-04 (Thu, 04 Jun 2015)

  Changed paths:
    M Makefile
    M arch_init.c
    M hw/i386/pc.c
    M hw/intc/apic.c
    R sysconfigs/target/target-x86_64.conf
    M target-i386/cpu.c
    M target-i386/cpu.h

  Log Message:
  -----------
  Merge remote-tracking branch 'remotes/ehabkost/tags/x86-pull-request' into 
staging

X86 queue 2015-06-02

# gpg: Signature made Tue Jun  2 20:21:17 2015 BST using RSA key ID 984DC5A6
# gpg: Good signature from "Eduardo Habkost <address@hidden>"
# gpg: WARNING: This key is not certified with sufficiently trusted signatures!
# gpg:          It is not certain that the signature belongs to the owner.
# Primary key fingerprint: 5A32 2FD5 ABC4 D3DB ACCF  D1AA 2807 936F 984D C5A6

* remotes/ehabkost/tags/x86-pull-request:
  arch_init: Drop target-x86_64.conf
  target-i386: Register QOM properties for feature flags
  apic: convert ->busdev.qdev casts to C casts
  target-i386: Fix signedness of MSR_IA32_APICBASE_BASE
  pc: Ensure non-zero CPU ref count after attaching to ICC bus

Signed-off-by: Peter Maydell <address@hidden>


Compare: https://github.com/qemu/qemu/compare/d2ceeb1d68ed...6fa6b312765f