[Qemu-commits] [qemu/qemu] 03a96b: kvm: Silence warning from valgrind

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: 03a96b83b539498510e22aab585e41015ba18247
      
https://github.com/qemu/qemu/commit/03a96b83b539498510e22aab585e41015ba18247
  Author: Thomas Huth <address@hidden>
  Date:   2015-04-30 (Thu, 30 Apr 2015)

  Changed paths:
    M kvm-all.c

  Log Message:
  -----------
  kvm: Silence warning from valgrind

valgrind complains here about uninitialized bytes with the following message:

==17814== Syscall param ioctl(generic) points to uninitialised byte(s)
==17814==    at 0x466A780: ioctl (in /usr/lib64/power8/libc-2.17.so)
==17814==    by 0x100735B7: kvm_vm_ioctl (kvm-all.c:1920)
==17814==    by 0x10074583: kvm_set_ioeventfd_mmio (kvm-all.c:574)

Let's fix it by using a proper struct initializer in kvm_set_ioeventfd_mmio().

Signed-off-by: Thomas Huth <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Paolo Bonzini <address@hidden>


  Commit: 813297541196698f60525d611dd09007fa60b45b
      
https://github.com/qemu/qemu/commit/813297541196698f60525d611dd09007fa60b45b
  Author: Denis V. Lunev <address@hidden>
  Date:   2015-04-30 (Thu, 30 Apr 2015)

  Changed paths:
    M hw/intc/apic_common.c

  Log Message:
  -----------
  apic_common: improve readability of apic_reset_common

Replace call of cpu_is_bsp(s->cpu) which really returns
    !!(s->apicbase & MSR_IA32_APICBASE_BSP)
with directly collected value. Due to this the tracepoint
  trace_cpu_get_apic_base((uint64_t)s->apicbase);
will not be hit anymore in apic_reset_common.

Signed-off-by: Denis V. Lunev <address@hidden>
CC: Andreas Färber <address@hidden>
CC: Paolo Bonzini <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Paolo Bonzini <address@hidden>


  Commit: e48816aac6eef50c851e3833add886f0403b6f11
      
https://github.com/qemu/qemu/commit/e48816aac6eef50c851e3833add886f0403b6f11
  Author: Gerd Hoffmann <address@hidden>
  Date:   2015-04-30 (Thu, 30 Apr 2015)

  Changed paths:
    M memory.c

  Log Message:
  -----------
  mtree: tag & indent a bit better

Signed-off-by: Gerd Hoffmann <address@hidden>
Signed-off-by: Paolo Bonzini <address@hidden>


  Commit: f8a9f720dd2fa5c1560838c26c6dad396a0cef5b
      
https://github.com/qemu/qemu/commit/f8a9f720dd2fa5c1560838c26c6dad396a0cef5b
  Author: Gerd Hoffmann <address@hidden>
  Date:   2015-04-30 (Thu, 30 Apr 2015)

  Changed paths:
    M memory.c

  Log Message:
  -----------
  mtree: also print disabled regions

Signed-off-by: Gerd Hoffmann <address@hidden>
Signed-off-by: Paolo Bonzini <address@hidden>


  Commit: 4c6637525290dc863a00be7f58fc11d07b780bd4
      
https://github.com/qemu/qemu/commit/4c6637525290dc863a00be7f58fc11d07b780bd4
  Author: Paolo Bonzini <address@hidden>
  Date:   2015-04-30 (Thu, 30 Apr 2015)

  Changed paths:
    M include/sysemu/kvm.h
    M kvm-all.c
    M target-arm/kvm.c
    M target-i386/kvm.c
    M target-mips/kvm.c
    M target-ppc/kvm.c
    M target-s390x/kvm.c

  Log Message:
  -----------
  kvm: add support for memory transaction attributes

Let kvm_arch_post_run convert fields in the kvm_run struct to MemTxAttrs.
These are then passed to address_space_rw.

Signed-off-by: Paolo Bonzini <address@hidden>


  Commit: 41063e1e7afcb2f13e103720fe96221657f5dbbc
      
https://github.com/qemu/qemu/commit/41063e1e7afcb2f13e103720fe96221657f5dbbc
  Author: Paolo Bonzini <address@hidden>
  Date:   2015-04-30 (Thu, 30 Apr 2015)

  Changed paths:
    M exec.c
    M hw/vfio/common.c
    M include/exec/memory.h
    M translate-all.c

  Log Message:
  -----------
  exec: move rcu_read_lock/unlock to address_space_translate callers

Once address_space_translate will be called outside the BQL, the returned
MemoryRegion might disappear as soon as the RCU read-side critical section
ends.  Avoid this by moving the critical section to the callers.

Signed-off-by: Paolo Bonzini <address@hidden>
Message-Id: <address@hidden>


  Commit: 768b7855c86c4f46b605183ae9451e9af64ca288
      
https://github.com/qemu/qemu/commit/768b7855c86c4f46b605183ae9451e9af64ca288
  Author: Emilio G. Cota <address@hidden>
  Date:   2015-05-08 (Fri, 08 May 2015)

  Changed paths:
    M configure

  Log Message:
  -----------
  configure: require __thread support

The codebase doesn't build without __thread support.
Formalise this requirement by adding a check for it in the
configure script.

Signed-off-by: Emilio G. Cota <address@hidden>
Signed-off-by: Paolo Bonzini <address@hidden>


  Commit: d24697e1824467f3921c84a94f011f43d6466403
      
https://github.com/qemu/qemu/commit/d24697e1824467f3921c84a94f011f43d6466403
  Author: Fam Zheng <address@hidden>
  Date:   2015-05-08 (Fri, 08 May 2015)

  Changed paths:
    M rules.mak

  Log Message:
  -----------
  rules.mak: Force CFLAGS for all objects in DSO

Because of the trick of process-archive-undefs, all .mo objects, even
with --enable-modules, are dependencies of executables.

This breaks CFLAGS propogation because the compiling of module object
will happen too early before building for DSO.

With GCC 5, the linking would fail because .o doesn't have -fPIC. Also,
BUILD_DSO will be missed. (module-common.o will have it, so the stamp
symbol was still liked in .so).

Fix the problem by forcing the CFLAGS on individual .o-cflags during
unnest-vars.

Reported-by: Alexander Graf <address@hidden>
Signed-off-by: Fam Zheng <address@hidden>
Cc: address@hidden # 2.3
Message-Id: <address@hidden>
Signed-off-by: Paolo Bonzini <address@hidden>


  Commit: ca4414804114fd0095b317785bc0b51862e62ebb
      
https://github.com/qemu/qemu/commit/ca4414804114fd0095b317785bc0b51862e62ebb
  Author: Paolo Bonzini <address@hidden>
  Date:   2015-05-08 (Fri, 08 May 2015)

  Changed paths:
    M nbd.c

  Log Message:
  -----------
  qemu-nbd: only send a limited number of errno codes on the wire

Right now, NBD includes potentially platform-specific error values in
the wire protocol.

Luckily, most common error values are more or less universal: in
particular, of all errno values <= 34 (up to ERANGE), they are all the
same on supported platforms except for 11 (which is EAGAIN on Windows and
Linux, but EDEADLK on Darwin and the *BSDs).  So, in order to guarantee
some portability, only keep a handful of possible error codes and squash
everything else to EINVAL.

This patch defines a limited set of errno values that are valid for the
NBD protocol, and specifies recommendations for what error to return
in specific corner cases.  The set of errno values is roughly based on
the errors listed in the read(2) and write(2) man pages, with some
exceptions:

- ENOMEM is added for servers that implement copy-on-write or other
  formats that require dynamic allocation.

- EDQUOT is not part of the universal set of errors; it can be changed
  to ENOSPC on the wire format.

- EFBIG is part of the universal set of errors, but it is also changed
  to ENOSPC because it is pretty similar to ENOSPC or EDQUOT.

Incoming values will in general match system errno values, but not
on the Hurd which has different errno values (they have a "subsystem
code" equal to 0x10 in bits 24-31).  The Hurd is probably not something
to which QEMU has been ported, but still do the right thing and
reverse-map the NBD errno values to the system errno values.

The corresponding patch to the NBD protocol description can be found at
http://article.gmane.org/gmane.linux.drivers.nbd.general/3154.

Signed-off-by: Paolo Bonzini <address@hidden>


  Commit: b951cda21d6b232f138ccf008e12bce8ddc95465
      
https://github.com/qemu/qemu/commit/b951cda21d6b232f138ccf008e12bce8ddc95465
  Author: Peter Maydell <address@hidden>
  Date:   2015-05-11 (Mon, 11 May 2015)

  Changed paths:
    M configure
    M exec.c
    M hw/intc/apic_common.c
    M hw/vfio/common.c
    M include/exec/memory.h
    M include/sysemu/kvm.h
    M kvm-all.c
    M memory.c
    M nbd.c
    M rules.mak
    M target-arm/kvm.c
    M target-i386/kvm.c
    M target-mips/kvm.c
    M target-ppc/kvm.c
    M target-s390x/kvm.c
    M translate-all.c

  Log Message:
  -----------
  Merge remote-tracking branch 'remotes/bonzini/tags/for-upstream' into staging

- build bugfix from Fam and new configure check from Emilio
- two improvements to "info mtere" from Gerd
- KVM support for memory transaction attributes
- one more small step towards unlocked MMIO dispatch
- one piece of the qemu-nbd errno fixes
- trivial-ish patches from Denis and Thomas

# gpg: Signature made Fri May  8 13:47:29 2015 BST using RSA key ID 78C7AE83
# gpg: Good signature from "Paolo Bonzini <address@hidden>"
# gpg:                 aka "Paolo Bonzini <address@hidden>"
# gpg: WARNING: This key is not certified with sufficiently trusted signatures!
# gpg:          It is not certain that the signature belongs to the owner.
# Primary key fingerprint: 46F5 9FBD 57D6 12E7 BFD4  E2F7 7E15 100C CD36 69B1
#      Subkey fingerprint: F133 3857 4B66 2389 866C  7682 BFFB D25F 78C7 AE83

* remotes/bonzini/tags/for-upstream:
  qemu-nbd: only send a limited number of errno codes on the wire
  rules.mak: Force CFLAGS for all objects in DSO
  configure: require __thread support
  exec: move rcu_read_lock/unlock to address_space_translate callers
  kvm: add support for memory transaction attributes
  mtree: also print disabled regions
  mtree: tag & indent a bit better
  apic_common: improve readability of apic_reset_common
  kvm: Silence warning from valgrind

Signed-off-by: Peter Maydell <address@hidden>


Compare: https://github.com/qemu/qemu/compare/ec62ad1e27ff...b951cda21d6b