[Qemu-commits] [qemu/qemu] a13ab5: AHCI: Do not (re)map FB/CLB buffers while not runn...

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: a13ab5a35bc0435fcfdacb3e171ceedcc077573d
      
https://github.com/qemu/qemu/commit/a13ab5a35bc0435fcfdacb3e171ceedcc077573d
  Author: John Snow <address@hidden>
  Date:   2015-03-27 (Fri, 27 Mar 2015)

  Changed paths:
    M hw/ide/ahci.c

  Log Message:
  -----------
  AHCI: Do not (re)map FB/CLB buffers while not running

The FIS Receive Buffer and Command List Buffer pointers
should not be edited while the FIS receive engine or
Command Receive engines are running.

Currently, we attempt to re-map the buffers every time they
are adjusted, but while the AHCI engines are off, these registers
may contain stale values, so we should not attempt to re-map these
values until the engines are reactivated.

Reported-by: Jordan Hargrave <address@hidden>
Signed-off-by: John Snow <address@hidden>
Reviewed-by: Stefan Hajnoczi <address@hidden>
Message-id: address@hidden


  Commit: fc3d8e1138cd0c843d6fd75272633a31be6554ef
      
https://github.com/qemu/qemu/commit/fc3d8e1138cd0c843d6fd75272633a31be6554ef
  Author: John Snow <address@hidden>
  Date:   2015-03-27 (Fri, 27 Mar 2015)

  Changed paths:
    M hw/ide/ahci.c
    M hw/ide/ahci.h

  Log Message:
  -----------
  AHCI: Protect cmd register

Many bits in the CMD register are supposed to be strictly read-only.
We should not be deleting them on every write.

As a side-effect: pay explicit attention to when a guest marks off
the FIS Receive or Start bits, and disable the status bits ourselves,
instead of letting them implicitly fall off.

Signed-off-by: John Snow <address@hidden>
Reviewed-by: Stefan Hajnoczi <address@hidden>
Message-id: address@hidden


  Commit: 627f91b1f80fecc73d00727181a9ddb6162cc30e
      
https://github.com/qemu/qemu/commit/627f91b1f80fecc73d00727181a9ddb6162cc30e
  Author: Peter Maydell <address@hidden>
  Date:   2015-03-28 (Sat, 28 Mar 2015)

  Changed paths:
    M hw/ide/ahci.c
    M hw/ide/ahci.h

  Log Message:
  -----------
  Merge remote-tracking branch 'remotes/jnsnow/tags/ide-pull-request' into 
staging

# gpg: Signature made Fri Mar 27 22:19:31 2015 GMT using RSA key ID AAFC390E
# gpg: Good signature from "John Snow (John Huston) <address@hidden>"
# gpg: WARNING: This key is not certified with sufficiently trusted signatures!
# gpg:          It is not certain that the signature belongs to the owner.
# Primary key fingerprint: FAEB 9711 A12C F475 812F  18F2 88A9 064D 1835 61EB
#      Subkey fingerprint: F9B7 ABDB BCAC DF95 BE76  CBD0 7DEF 8106 AAFC 390E

* remotes/jnsnow/tags/ide-pull-request:
  AHCI: Protect cmd register
  AHCI: Do not (re)map FB/CLB buffers while not running

Signed-off-by: Peter Maydell <address@hidden>


Compare: https://github.com/qemu/qemu/compare/b27e767e8c8d...627f91b1f80f