[Qemu-commits] [qemu/qemu] 2115f2: nvme: Fix unintentional integer overflow (OVERFLOW...

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: 2115f2a1d8c77c2a735add1ed02ae0c1feae0d9a
      
https://github.com/qemu/qemu/commit/2115f2a1d8c77c2a735add1ed02ae0c1feae0d9a
  Author: Stefan Weil <address@hidden>
  Date:   2015-03-27 (Fri, 27 Mar 2015)

  Changed paths:
    M hw/block/nvme.c

  Log Message:
  -----------
  nvme: Fix unintentional integer overflow (OVERFLOW_BEFORE_WIDEN)

The shift operation on nlb gives a 32 bit result if no type cast is
applied. This bug was reported by Coverity.

Signed-off-by: Stefan Weil <address@hidden>
Message-id: address@hidden
Signed-off-by: Stefan Hajnoczi <address@hidden>


  Commit: fc3959e4669a1c2149b91ccb05101cfc7ae1fc05
      
https://github.com/qemu/qemu/commit/fc3959e4669a1c2149b91ccb05101cfc7ae1fc05
  Author: Fam Zheng <address@hidden>
  Date:   2015-03-27 (Fri, 27 Mar 2015)

  Changed paths:
    M block.c

  Log Message:
  -----------
  block: Fix unaligned zero write

If the zero write is not aligned, bdrv_co_do_pwritev will segfault
because of accessing to the NULL qiov passed in by bdrv_co_write_zeroes.
Fix this by allocating a local qiov in bdrv_co_do_pwritev if the request
is not aligned. (In this case the padding iovs are necessary anyway, so
it doesn't hurt.)

Also add a check at the end of bdrv_co_do_pwritev to clear the zero flag
if padding is involved.

Signed-off-by: Fam Zheng <address@hidden>
Message-id: address@hidden
Signed-off-by: Stefan Hajnoczi <address@hidden>


  Commit: 61815d6e0aa1a549ad55f6621b6816aa6b1ab757
      
https://github.com/qemu/qemu/commit/61815d6e0aa1a549ad55f6621b6816aa6b1ab757
  Author: Fam Zheng <address@hidden>
  Date:   2015-03-27 (Fri, 27 Mar 2015)

  Changed paths:
    M tests/qemu-iotests/033
    M tests/qemu-iotests/033.out

  Log Message:
  -----------
  qemu-iotests: Test unaligned 4k zero write

Signed-off-by: Fam Zheng <address@hidden>
Message-id: address@hidden
Signed-off-by: Stefan Hajnoczi <address@hidden>


  Commit: da2cf4e80355e42fbaeb8bcfa2b07f5bceddd323
      
https://github.com/qemu/qemu/commit/da2cf4e80355e42fbaeb8bcfa2b07f5bceddd323
  Author: Markus Armbruster <address@hidden>
  Date:   2015-03-27 (Fri, 27 Mar 2015)

  Changed paths:
    M qapi/block-core.json
    M qmp-commands.hx

  Log Message:
  -----------
  block: Document blockdev-add's immaturity

Signed-off-by: Markus Armbruster <address@hidden>
Reviewed-by: Eric Blake <address@hidden>
Message-id: address@hidden
Signed-off-by: Stefan Hajnoczi <address@hidden>


  Commit: 500d76a093b81f0aa9a368039518ab333d5dbf7a
      
https://github.com/qemu/qemu/commit/500d76a093b81f0aa9a368039518ab333d5dbf7a
  Author: Peter Maydell <address@hidden>
  Date:   2015-03-27 (Fri, 27 Mar 2015)

  Changed paths:
    M block.c
    M hw/block/nvme.c
    M qapi/block-core.json
    M qmp-commands.hx
    M tests/qemu-iotests/033
    M tests/qemu-iotests/033.out

  Log Message:
  -----------
  Merge remote-tracking branch 'remotes/stefanha/tags/block-pull-request' into 
staging

# gpg: Signature made Fri Mar 27 10:13:35 2015 GMT using RSA key ID 81AB73C8
# gpg: Good signature from "Stefan Hajnoczi <address@hidden>"
# gpg:                 aka "Stefan Hajnoczi <address@hidden>"

* remotes/stefanha/tags/block-pull-request:
  block: Document blockdev-add's immaturity
  qemu-iotests: Test unaligned 4k zero write
  block: Fix unaligned zero write
  nvme: Fix unintentional integer overflow (OVERFLOW_BEFORE_WIDEN)

Signed-off-by: Peter Maydell <address@hidden>


Compare: https://github.com/qemu/qemu/compare/4ad9e2b36e1e...500d76a093b8