[Qemu-commits] [qemu/qemu] 6aff22: ide: fix cmd_write_pio when nsectors > 1

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: 6aff22c013ab6f5f711665e7031fd555086d4464
      
https://github.com/qemu/qemu/commit/6aff22c013ab6f5f711665e7031fd555086d4464
  Author: John Snow <address@hidden>
  Date:   2015-03-23 (Mon, 23 Mar 2015)

  Changed paths:
    M hw/ide/core.c

  Log Message:
  -----------
  ide: fix cmd_write_pio when nsectors > 1

We need to adjust the sector being written to
prior to calling ide_transfer_start, otherwise
we'll write to the same sector again.

Signed-off-by: John Snow <address@hidden>
Reviewed-by: Stefan Hajnoczi <address@hidden>
Tested-by: Andreas Färber <address@hidden>
Message-id: address@hidden


  Commit: dd0bf7baab2201bd8f834be9eb87766662f50b19
      
https://github.com/qemu/qemu/commit/dd0bf7baab2201bd8f834be9eb87766662f50b19
  Author: John Snow <address@hidden>
  Date:   2015-03-23 (Mon, 23 Mar 2015)

  Changed paths:
    M hw/ide/core.c

  Log Message:
  -----------
  ide: fix cmd_read_pio when nsectors > 1

Similar to the cmd_write_pio fix, update the nsector count and
ide sector before we invoke ide_transfer_start.

Signed-off-by: John Snow <address@hidden>
Reviewed-by: Stefan Hajnoczi <address@hidden>
Tested-by: Andreas Färber <address@hidden>
Message-id: address@hidden


  Commit: ac38123609742ce3fbdf53774a797ac230cbf118
      
https://github.com/qemu/qemu/commit/ac38123609742ce3fbdf53774a797ac230cbf118
  Author: John Snow <address@hidden>
  Date:   2015-03-23 (Mon, 23 Mar 2015)

  Changed paths:
    M hw/ide/ahci.c

  Log Message:
  -----------
  ahci: Fix sglist offset manipulation for BE machines

This does not bother DMA, because DMA generally transfers
the entire SGList in one shot if it can.

PIO, on the other hand, tries to transfer just one sector
at a time, and will make multiple visits to the sglist
to fetch memory addresses.

Fix the memory address calculaton when we have an offset
by moving the offset addition OUTSIDE of the le64_to_cpu
calculation.

Signed-off-by: John Snow <address@hidden>
Reviewed-by: Stefan Hajnoczi <address@hidden>
Tested-by: Andreas Färber <address@hidden>
Message-id: address@hidden


  Commit: 54fced034e4d32d8ba6d1e27ecb7e2e2fb2f45d4
      
https://github.com/qemu/qemu/commit/54fced034e4d32d8ba6d1e27ecb7e2e2fb2f45d4
  Author: John Snow <address@hidden>
  Date:   2015-03-23 (Mon, 23 Mar 2015)

  Changed paths:
    M tests/ahci-test.c

  Log Message:
  -----------
  ahci-test: improve rw buffer patterns

My pattern was cyclical every 256 bytes, so it missed a fairly obvious
failure case. Add some rand() pepper into the test pattern, and for large
patterns that exceed 256 sectors, start writing an ID per-sector so that
we never generate identical sector patterns.

Signed-off-by: John Snow <address@hidden>
Reviewed-by: Stefan Hajnoczi <address@hidden>
Tested-by: Andreas Färber <address@hidden>
Message-id: address@hidden


  Commit: 362ca922eea03240916287a8a6267801ab095d12
      
https://github.com/qemu/qemu/commit/362ca922eea03240916287a8a6267801ab095d12
  Author: Peter Maydell <address@hidden>
  Date:   2015-03-23 (Mon, 23 Mar 2015)

  Changed paths:
    M hw/ide/ahci.c
    M hw/ide/core.c
    M tests/ahci-test.c

  Log Message:
  -----------
  Merge remote-tracking branch 'remotes/jnsnow/tags/ide-pull-request' into 
staging

# gpg: Signature made Mon Mar 23 16:51:45 2015 GMT using RSA key ID AAFC390E
# gpg: Can't check signature: public key not found

* remotes/jnsnow/tags/ide-pull-request:
  ahci-test: improve rw buffer patterns
  ahci: Fix sglist offset manipulation for BE machines
  ide: fix cmd_read_pio when nsectors > 1
  ide: fix cmd_write_pio when nsectors > 1

Signed-off-by: Peter Maydell <address@hidden>


Compare: https://github.com/qemu/qemu/compare/e7aab6d6e3f6...362ca922eea0