qemu-commits
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-commits] [qemu/qemu] 9e0f5b: virtio: validate the existence of han


From: GitHub
Subject: [Qemu-commits] [qemu/qemu] 9e0f5b: virtio: validate the existence of handle_output be...
Date: Thu, 19 Mar 2015 05:30:06 -0700

  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: 9e0f5b8108e248b78444c9a2ec41a8309825736c
      
https://github.com/qemu/qemu/commit/9e0f5b8108e248b78444c9a2ec41a8309825736c
  Author: Jason Wang <address@hidden>
  Date:   2015-03-16 (Mon, 16 Mar 2015)

  Changed paths:
    M hw/virtio/virtio.c

  Log Message:
  -----------
  virtio: validate the existence of handle_output before calling it

We don't validate the existence of handle_output which may let a buggy
guest to trigger a SIGSEV easily. E.g:

1) write 10 to queue_sel to a virtio net device with only 1 queue
2) setup an arbitrary pfn
3) then notify queue 10

Fixing this by validating the existence of handle_output before.

Cc: address@hidden
Cc: Michael S. Tsirkin <address@hidden>
Signed-off-by: Jason Wang <address@hidden>
Reviewed-by: Michael S. Tsirkin <address@hidden>
Signed-off-by: Michael S. Tsirkin <address@hidden>
Reviewed-by: Don Koch <address@hidden>
Reviewed-by: Fam Zheng <address@hidden>


  Commit: 6c936b74235c2d920790a0ff9feb00b07db239c9
      
https://github.com/qemu/qemu/commit/6c936b74235c2d920790a0ff9feb00b07db239c9
  Author: Stefan Weil <address@hidden>
  Date:   2015-03-16 (Mon, 16 Mar 2015)

  Changed paths:
    M hw/9pfs/virtio-9p-local.c

  Log Message:
  -----------
  virtio: Fix memory leaks reported by Coverity

All four leaks are similar, so fix them in one patch.

Signed-off-by: Stefan Weil <address@hidden>
Reviewed-by: Michael S. Tsirkin <address@hidden>
Signed-off-by: Michael S. Tsirkin <address@hidden>


  Commit: 30b04f8711c5191929af4ed03a779646ced3456e
      
https://github.com/qemu/qemu/commit/30b04f8711c5191929af4ed03a779646ced3456e
  Author: Chen Fan <address@hidden>
  Date:   2015-03-18 (Wed, 18 Mar 2015)

  Changed paths:
    M hw/pci/pcie.c
    M include/hw/pci/pcie_regs.h

  Log Message:
  -----------
  pcie: correct mistaken register bit for End-End TLP Prefix Blocking

from pcie spec 7.8.17, the End-End TLP Prefix Blocking bit local
is 15(e.g. 0x8000) in device control 2 register.

Signed-off-by: Chen Fan <address@hidden>
Reviewed-by: Michael S. Tsirkin <address@hidden>
Signed-off-by: Michael S. Tsirkin <address@hidden>


  Commit: 77a3c1d730a14c86f3f5692be9906b206afc3d3e
      
https://github.com/qemu/qemu/commit/77a3c1d730a14c86f3f5692be9906b206afc3d3e
  Author: Chen Fan <address@hidden>
  Date:   2015-03-18 (Wed, 18 Mar 2015)

  Changed paths:
    M hw/pci/pcie_aer.c

  Log Message:
  -----------
  aer: fix wrong check on expose aer tlp prefix log

when specify TLP Prefix log as using pcie_aer_inject_error,
the TLP prefix log is always discarded. because the check
is incorrect, the End-End TLP Prefix Supported bit
(PCI_EXP_DEVCAP2_EETLPP) should be in Device Capabilities 2 Register.

Signed-off-by: Chen Fan <address@hidden>
Reviewed-by: Michael S. Tsirkin <address@hidden>
Signed-off-by: Michael S. Tsirkin <address@hidden>


  Commit: b01738c23da718678469cbe85c0a4a82b19652d4
      
https://github.com/qemu/qemu/commit/b01738c23da718678469cbe85c0a4a82b19652d4
  Author: Chen Fan <address@hidden>
  Date:   2015-03-18 (Wed, 18 Mar 2015)

  Changed paths:
    M hw/pci/pcie_aer.c

  Log Message:
  -----------
  pcie_aer: fix typos in pcie_aer_inject_error comment

Refer to "PCI Express Base Spec3.0", this comments can't
fit the description in spec, so we should fix them.

Signed-off-by: Chen Fan <address@hidden>
Reviewed-by: Michael S. Tsirkin <address@hidden>
Signed-off-by: Michael S. Tsirkin <address@hidden>


  Commit: 310e91f7d0aaec27f55969597ccbb4e83612695e
      
https://github.com/qemu/qemu/commit/310e91f7d0aaec27f55969597ccbb4e83612695e
  Author: Chen Fan <address@hidden>
  Date:   2015-03-18 (Wed, 18 Mar 2015)

  Changed paths:
    M hw/pci/pcie_aer.c

  Log Message:
  -----------
  aer: fix a wrong init PCI_ERR_COR_STATUS w1cmask type register

Error Status Register, so this patch fix a wrong definition
for PCI_ERR_COR_STATUS register with w1cmask type.

Signed-off-by: Chen Fan <address@hidden>
Reviewed-by: Michael S. Tsirkin <address@hidden>
Signed-off-by: Michael S. Tsirkin <address@hidden>


  Commit: 98a2f30a1b5b8b7b35229a705149f020b4918ab8
      
https://github.com/qemu/qemu/commit/98a2f30a1b5b8b7b35229a705149f020b4918ab8
  Author: Chen Fan <address@hidden>
  Date:   2015-03-18 (Wed, 18 Mar 2015)

  Changed paths:
    M include/hw/pci/pci.h
    M include/hw/pci/pcie_aer.h

  Log Message:
  -----------
  pci: fix several trivial typos in comment

Signed-off-by: Chen Fan <address@hidden>
Reviewed-by: Michael S. Tsirkin <address@hidden>
Signed-off-by: Michael S. Tsirkin <address@hidden>


  Commit: ce394947a75296fc10f1676932473e92aa8be11a
      
https://github.com/qemu/qemu/commit/ce394947a75296fc10f1676932473e92aa8be11a
  Author: Michael S. Tsirkin <address@hidden>
  Date:   2015-03-18 (Wed, 18 Mar 2015)

  Changed paths:
    M hw/pci/pcie_aer.c

  Log Message:
  -----------
  pcie_aer: fix comment to match pcie spec

Code comment says "table 6-2" but in fact it's is not a table, it is
"Figure 6-2" on page 479.

Cc: Chen Fan <address@hidden>
Reported-by: Michael Tokarev <address@hidden>
Signed-off-by: Michael S. Tsirkin <address@hidden>


  Commit: 2259c16dc21aa55cd3fbc26f9be602949105d249
      
https://github.com/qemu/qemu/commit/2259c16dc21aa55cd3fbc26f9be602949105d249
  Author: Peter Maydell <address@hidden>
  Date:   2015-03-19 (Thu, 19 Mar 2015)

  Changed paths:
    M hw/pci/pcie.c
    M hw/pci/pcie_aer.c
    M hw/virtio/virtio.c
    M include/hw/pci/pci.h
    M include/hw/pci/pcie_aer.h
    M include/hw/pci/pcie_regs.h

  Log Message:
  -----------
  Merge remote-tracking branch 'remotes/mst/tags/for_upstream' into staging

pci, virtio bugfixes for 2.3

Just a bunch of bugfixes. Should be nothing remarkable here.

Signed-off-by: Michael S. Tsirkin <address@hidden>

# gpg: Signature made Wed Mar 18 12:31:03 2015 GMT using RSA key ID D28D5469
# gpg: Good signature from "Michael S. Tsirkin <address@hidden>"
# gpg:                 aka "Michael S. Tsirkin <address@hidden>"
# gpg: WARNING: This key is not certified with a trusted signature!
# gpg:          There is no indication that the signature belongs to the owner.
# Primary key fingerprint: 0270 606B 6F3C DF3D 0B17  0970 C350 3912 AFBE 8E67
#      Subkey fingerprint: 5D09 FD08 71C8 F85B 94CA  8A0D 281F 0DB8 D28D 5469

* remotes/mst/tags/for_upstream:
  pcie_aer: fix comment to match pcie spec
  pci: fix several trivial typos in comment
  aer: fix a wrong init PCI_ERR_COR_STATUS w1cmask type register
  pcie_aer: fix typos in pcie_aer_inject_error comment
  aer: fix wrong check on expose aer tlp prefix log
  pcie: correct mistaken register bit for End-End TLP Prefix Blocking
  virtio: Fix memory leaks reported by Coverity
  virtio: validate the existence of handle_output before calling it

Signed-off-by: Peter Maydell <address@hidden>


Compare: https://github.com/qemu/qemu/compare/1f3500976d3d...2259c16dc21a

reply via email to

[Prev in Thread] Current Thread [Next in Thread]