[Qemu-commits] [qemu/qemu] 03d982: qxl: document minimal video memory for new modes

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: 03d9825d15e17e444e00bd4caa9edb0d57022794
      
https://github.com/qemu/qemu/commit/03d9825d15e17e444e00bd4caa9edb0d57022794
  Author: Radim Krčmář <address@hidden>
  Date:   2015-03-03 (Tue, 03 Mar 2015)

  Changed paths:
    M hw/display/qxl.c

  Log Message:
  -----------
  qxl: document minimal video memory for new modes

The alternative to removing existing comments.

Signed-off-by: Radim Krčmář <address@hidden>
Signed-off-by: Gerd Hoffmann <address@hidden>


  Commit: 876d516311c1538a7d29f2abec48b7cda0645eea
      
https://github.com/qemu/qemu/commit/876d516311c1538a7d29f2abec48b7cda0645eea
  Author: Radim Krčmář <address@hidden>
  Date:   2015-03-03 (Tue, 03 Mar 2015)

  Changed paths:
    M hw/display/qxl.c
    M hw/display/vga.c

  Log Message:
  -----------
  spice: fix invalid memory access to vga.vram

vga_common_init() doesn't allow more than 256 MiB vram size and silently
shrinks any larger value.  qxl_dirty_surfaces() used the unshrinked size
via qxl->shadow_rom.surface0_area_size when accessing the memory, which
resulted in segfault.

Add a workaround for this case and an assert if it happens again.

We have to bump the vga memory limit too, because 256 MiB wouldn't have
allowed 8k (it requires more than 128 MiB).
1024 MiB doesn't work, but 512 MiB seems fine.

Proposed-by: Gerd Hoffmann <address@hidden>
Signed-off-by: Radim Krčmář <address@hidden>
Signed-off-by: Gerd Hoffmann <address@hidden>


  Commit: bb7443f6d6f09411ea10f06e6cb0d416bd1ccebd
      
https://github.com/qemu/qemu/commit/bb7443f6d6f09411ea10f06e6cb0d416bd1ccebd
  Author: Radim Krčmář <address@hidden>
  Date:   2015-03-03 (Tue, 03 Mar 2015)

  Changed paths:
    M hw/display/qxl.c
    M include/qemu-common.h
    M util/cutils.c

  Log Message:
  -----------
  qxl: refactor rounding up to a nearest power of 2

We already have pow2floor, mirror it and use instead of a function with
similar results (same in used domain), to clarify our intent.

Signed-off-by: Radim Krčmář <address@hidden>
Signed-off-by: Gerd Hoffmann <address@hidden>


  Commit: 619616ce31a5a5d167bf26f40d920b26da0a7bfd
      
https://github.com/qemu/qemu/commit/619616ce31a5a5d167bf26f40d920b26da0a7bfd
  Author: Radim Krčmář <address@hidden>
  Date:   2015-03-03 (Tue, 03 Mar 2015)

  Changed paths:
    M hw/display/vga.c

  Log Message:
  -----------
  vga: refactor vram_size clamping and rounding

Make the code a bit more obvious.

We don't have min/max, so a general helper for clamp probably isn't
acceptable either.

Signed-off-by: Radim Krčmář <address@hidden>
Signed-off-by: Gerd Hoffmann <address@hidden>


  Commit: 20ca3763abbb77ae9942f3e854bdeec36a147a29
      
https://github.com/qemu/qemu/commit/20ca3763abbb77ae9942f3e854bdeec36a147a29
  Author: Gerd Hoffmann <address@hidden>
  Date:   2015-03-03 (Tue, 03 Mar 2015)

  Changed paths:
    M hw/display/qxl.c

  Log Message:
  -----------
  qxl: drop update_displaychangelistener call for secondary qxl devices

Commit 3dcadce5076d4b42fa395c39662d65e050b77784 added three
update_displaychangelistener call sites:

Two for primary qxl cards, when entering/leaving vga mode, which are
correct.

One for secondary qxl cards, which is wrong because we don't register
a displaychangelistener in the first place for secondary cards.

Remove it.

Reported-by: Brad Campbell <address@hidden>
Tested-by: Brad Campbell <address@hidden>
Signed-off-by: Gerd Hoffmann <address@hidden>


  Commit: 22fa7da0005c939c940634da069ecb9bbb199a2a
      
https://github.com/qemu/qemu/commit/22fa7da0005c939c940634da069ecb9bbb199a2a
  Author: Cole Robinson <address@hidden>
  Date:   2015-03-03 (Tue, 03 Mar 2015)

  Changed paths:
    M hmp.c

  Log Message:
  -----------
  hmp: info spice: Show string channel name

Useful for debugging.

https://bugzilla.redhat.com/show_bug.cgi?id=822418
Signed-off-by: Cole Robinson <address@hidden>
Reviewed-by: Eric Blake <address@hidden>
Signed-off-by: Gerd Hoffmann <address@hidden>


  Commit: 7c6044a94e52db8aef9a71d616c7a0914adb71ab
      
https://github.com/qemu/qemu/commit/7c6044a94e52db8aef9a71d616c7a0914adb71ab
  Author: Gerd Hoffmann <address@hidden>
  Date:   2015-03-04 (Wed, 04 Mar 2015)

  Changed paths:
    M hmp.c

  Log Message:
  -----------
  hmp: info spice: take out webdav

Obvious suggestion for the next spice-protocol
release: Add some way to #ifdef new stuff.

Signed-off-by: Gerd Hoffmann <address@hidden>
Reviewed-by: Cole Robinson <address@hidden>


  Commit: 033c7ddf86fe4315069ac4cf3cfab9bc6035dee7
      
https://github.com/qemu/qemu/commit/033c7ddf86fe4315069ac4cf3cfab9bc6035dee7
  Author: Peter Maydell <address@hidden>
  Date:   2015-03-08 (Sun, 08 Mar 2015)

  Changed paths:
    M hmp.c
    M hw/display/qxl.c
    M hw/display/vga.c
    M include/qemu-common.h
    M util/cutils.c

  Log Message:
  -----------
  Merge remote-tracking branch 'remotes/spice/tags/pull-spice-20150304-1' into 
staging

misc spice/qxl fixes.

# gpg: Signature made Wed Mar  4 13:57:42 2015 GMT using RSA key ID D3E87138
# gpg: Good signature from "Gerd Hoffmann (work) <address@hidden>"
# gpg:                 aka "Gerd Hoffmann <address@hidden>"
# gpg:                 aka "Gerd Hoffmann (private) <address@hidden>"

* remotes/spice/tags/pull-spice-20150304-1:
  hmp: info spice: take out webdav
  hmp: info spice: Show string channel name
  qxl: drop update_displaychangelistener call for secondary qxl devices
  vga: refactor vram_size clamping and rounding
  qxl: refactor rounding up to a nearest power of 2
  spice: fix invalid memory access to vga.vram
  qxl: document minimal video memory for new modes

Signed-off-by: Peter Maydell <address@hidden>


Compare: https://github.com/qemu/qemu/compare/b6d527fbc0b6...033c7ddf86fe